| Message ID | 20221017235602.86250-4-giulio.benetti@benettiengineering.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1695971wrs;
Mon, 17 Oct 2022 16:58:44 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM57KwLb+8/ri75A46Y9MwvkYv2BH3TjaDU3Z5eu6763rtTf7umKLUfqqV8CvUiJl+hhgEio
X-Received: by 2002:a05:6402:5252:b0:45d:d1a:fe7d with SMTP id
t18-20020a056402525200b0045d0d1afe7dmr160385edd.323.1666051124600;
Mon, 17 Oct 2022 16:58:44 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666051124; cv=none;
d=google.com; s=arc-20160816;
b=QDHXpAGzPkwfktoLbyqS+mhDJwUus526/c0NAxABED9anZLGcLRDO8tnPuwb3lNNYe
EDP5+KJ5ApZPJRMCQyPcOJHBrSRlSRB0POST3oqVXlUnS5Uwrxz8lWGYf9U82YRYnwah
M7LqOXvfbeay2Xx35GkG6gJxmFm48fnuV2XZ+sun/Qe5BsL7aYCzUlTvjO0SPVDxB4tZ
QVi5zuZVAAASw7HQR87NRlD0BhoQoMmpNF4mW2d6FqWsJUzKbI7322ywk7ldQuwtj/8W
6hyFTYfgsuOGCbI3BITsURqx5mX4ycFKxd5+QpDDNGZW8JQrR9JFgNqkDvroQmpXRwCq
vapg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=jQqLZwaGtCHYvLz6HOq6oNN8IT957ilJi6AI9nQbuZU=;
b=d7//eSYX59h0hjTAQ3gZevtSL9a5XrLQ8zgaLNOQ9CM7Lsv9pfXr24DR8Zjgm/2842
5972dcA9k18F9Wzw96Rqdbpd9rzNmbnRYZJHaKWdYPz0cxoQvnWvvi2tiUXqAOoODCgR
OrrGtydOOdqdPAr6oQHN7uAOjsWaZufT/85vCh3KYQaoslaDWs8X98TyjBt8O5y80kvz
9t8lQYjv8KgZ6QvvxrhcAduTTfS7Nj9fZSflhHY8fAtEjRZlMXZO0+ELdRKZXKAp8il5
1w1PUVcpIBqblKOF0dyHvdLPt1dMWz37Y05WIkMHJoQSqkB73gUGsju4whGZwTsFBwJH
ByMQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@aruba.it header.s=a1 header.b=CXmSTPNv;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ga37-20020a1709070c2500b0073d92f83e06si10865506ejc.887.2022.10.17.16.58.17;
Mon, 17 Oct 2022 16:58:44 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@aruba.it header.s=a1 header.b=CXmSTPNv;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231136AbiJQX4Y (ORCPT <rfc822;kernel.ruili@gmail.com>
+ 99 others); Mon, 17 Oct 2022 19:56:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36122 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230151AbiJQX4M (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 17 Oct 2022 19:56:12 -0400
Received: from smtpcmd0641.aruba.it (smtpcmd0641.aruba.it [62.149.156.41])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2810E7E013
for <linux-kernel@vger.kernel.org>;
Mon, 17 Oct 2022 16:56:07 -0700 (PDT)
Received: from localhost.localdomain ([146.241.87.206])
by Aruba Outgoing Smtp with ESMTPSA
id kZxkoIDsHJpY4kZxloMdtZ; Tue, 18 Oct 2022 01:56:06 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1;
t=1666050966; bh=V+admxQwpLfW/V/+bGSuXav4uFvMNNrftW6txCx6iRw=;
h=From:To:Subject:Date:MIME-Version;
b=CXmSTPNv+sjLLeHTr9MgSboyhUdNZGdxctm70YpIHOJRBp5UsPS8fORljpbDc7Qlf
H32XRZt4bOlaEhQV+7vXA0XiLLUB3/9alxoJ5+ZlicTDfTOieWcdZ6I1mZ4Dn7seQw
fBnwahbGeclMjcJg1IX0D+rPh5QasBzYsZ0ladmh7/YZ6gFMs/fvYIAucwKlGTfh/v
LLzU4bdCRXsPVnyF9WxHpUFDwYr8c8GtuH0DJB4Rf/pS8+XODy2KPIt18VYko00tvZ
Q2atlRNtE99P+PjjsmUAMlBw46Myzus5aBwHYJpMaGEilInsFB9FYNbVSzr5blDfQu
p2wJUP9TbeZ8Q==
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-mmc@vger.kernel.org
Cc: Stephen Boyd <sboyd@kernel.org>, Haibo Chen <haibo.chen@nxp.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Giulio Benetti <giulio.benetti@benettiengineering.com>
Subject: [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency property
Date: Tue, 18 Oct 2022 01:56:01 +0200
Message-Id: <20221017235602.86250-4-giulio.benetti@benettiengineering.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221017235602.86250-1-giulio.benetti@benettiengineering.com>
References: <20221017235602.86250-1-giulio.benetti@benettiengineering.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CMAE-Envelope:
MS4xfJPiiR7i7lCy6Uzn2y/6TcFw3IkBM6IvSZFACENWKfnFdxiEKvsCk201PTya2kR/sMbSF8+kn6SIFMRLEbEa9epVh9dBM9z2XG7rHdStuL9DnZyi1aX3
wE9L05Lj8Gh4iZyg7/b5mN/4XN2WRdc8ZlhMW+dWt79tJUXGk48n1gCgHGnTuyubP3115nj9T8CQbHEWaVd2q22uji6mucyxAHW3divjewOqKB3hsZpDOsVB
dR81CRik/xL4kbu6iHBEfGDHuulBynKZYP31InOz6FPQyDOD/LAzEeBaAvsnuySS4pZJajEgf5qSQkEvb3aDpGBrLM5BYZqhCYuHaVTaJtfUdVdhJFwuc8CJ
DUFxOI6tZPRyjnc5Htn1GWgaOvIDlfiF9lMjOZpxwSj9gsKLP4WyticVFSblu3NyJDBUaVu4RuP27b6qK1kmQpTFeZ6mD3/4kgUTJInwn6tUZeg9QrvXa1HG
Mwn3bFPI4SgKUuX7RkiKi/QdxxI7sb4BVrMl0OrCXI3KIROKT3QRqdpakssp/lxvERehuQ6u1iSe5GGVq5MOROxexWA72LGUsUGv5YVQvXBf1V3M3+cfCu40
BYA=
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1746981223957365706?=
X-GMAIL-MSGID: =?utf-8?q?1746981223957365706?=
|
| Series |
[1/5] clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets
|
|
Commit Message
Giulio Benetti
Oct. 17, 2022, 11:56 p.m. UTC
According to i.MXRT1050 Reference Manual usdhc supports up to 208Mhz clock
so let's remove max-frequency property in the .dtsi base file and
in case add that property in the board specific .dts file for a specific
device connected to it.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
arch/arm/boot/dts/imxrt1050.dtsi | 1 -
1 file changed, 1 deletion(-)
Comments
> -----Original Message----- > From: Giulio Benetti <giulio.benetti@benettiengineering.com> > Sent: 2022年10月18日 7:56 > To: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; > linux-mmc@vger.kernel.org > Cc: Stephen Boyd <sboyd@kernel.org>; Bough Chen <haibo.chen@nxp.com>; > Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson > <ulf.hansson@linaro.org>; Giulio Benetti > <giulio.benetti@benettiengineering.com> > Subject: [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency > property > > According to i.MXRT1050 Reference Manual usdhc supports up to 208Mhz clock Please double check this. As I know, the i.MXRT1050 and i.MX6/7/8/9 series use the same usdhc IP, maybe include some small difference. For the usdhc in i.MX6/7/8/9, I confirmed with IC team, the card clock output from usdhc can't be upper than 200MHz, otherwise maybe meet some stable related issue. So here I think should change to like this: max-frequency = <200000000>; Best Regards Haibo Chen > so let's remove max-frequency property in the .dtsi base file and in case add > that property in the board specific .dts file for a specific device connected to it. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > arch/arm/boot/dts/imxrt1050.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imxrt1050.dtsi > b/arch/arm/boot/dts/imxrt1050.dtsi > index 114465e4dde6..0b44cc4ce6ad 100644 > --- a/arch/arm/boot/dts/imxrt1050.dtsi > +++ b/arch/arm/boot/dts/imxrt1050.dtsi > @@ -93,7 +93,6 @@ usdhc1: mmc@402c0000 { > bus-width = <4>; > fsl,wp-controller; > no-1-8-v; > - max-frequency = <4000000>; > fsl,tuning-start-tap = <20>; > fsl,tuning-step = <2>; > status = "disabled"; > -- > 2.34.1
Hi Haibo, On 18/10/22 05:01, Bough Chen wrote: >> -----Original Message----- >> From: Giulio Benetti <giulio.benetti@benettiengineering.com> >> Sent: 2022年10月18日 7:56 >> To: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; >> linux-mmc@vger.kernel.org >> Cc: Stephen Boyd <sboyd@kernel.org>; Bough Chen <haibo.chen@nxp.com>; >> Adrian Hunter <adrian.hunter@intel.com>; Ulf Hansson >> <ulf.hansson@linaro.org>; Giulio Benetti >> <giulio.benetti@benettiengineering.com> >> Subject: [PATCH 4/5] ARM: dts: imxrt1050: remove mmc max-frequency >> property >> >> According to i.MXRT1050 Reference Manual usdhc supports up to 208Mhz clock > > Please double check this. As I know, the i.MXRT1050 and i.MX6/7/8/9 series use the same usdhc IP, maybe include some small difference. > For the usdhc in i.MX6/7/8/9, I confirmed with IC team, the card clock output from usdhc can't be upper than 200MHz, otherwise maybe meet some stable related issue. Thanks for poiting, I've double checked and you're right. RM states 208Mhz but DS states 200Mhz and it makes sense because of HS200. > So here I think should change to like this: > max-frequency = <200000000>; Ok, I'll send a V2 for this. I wait for other comments on the other patches for a bit before. Best regards
diff --git a/arch/arm/boot/dts/imxrt1050.dtsi b/arch/arm/boot/dts/imxrt1050.dtsi index 114465e4dde6..0b44cc4ce6ad 100644 --- a/arch/arm/boot/dts/imxrt1050.dtsi +++ b/arch/arm/boot/dts/imxrt1050.dtsi @@ -93,7 +93,6 @@ usdhc1: mmc@402c0000 { bus-width = <4>; fsl,wp-controller; no-1-8-v; - max-frequency = <4000000>; fsl,tuning-start-tap = <20>; fsl,tuning-step = <2>; status = "disabled";