Message ID | 20221017121446.4190650-1-yangyingliang@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1412970wrs; Mon, 17 Oct 2022 05:16:42 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Hg8Fq0H3ENtW+jItTMWEjEUxDZYpsDkzoAsvcg/iesZ2x6EQJXdSnsU6AmWq+JEb48n4A X-Received: by 2002:a17:902:aa8b:b0:178:8f1d:6936 with SMTP id d11-20020a170902aa8b00b001788f1d6936mr11873784plr.168.1666009001897; Mon, 17 Oct 2022 05:16:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666009001; cv=none; d=google.com; s=arc-20160816; b=gO7MgyPvDoTBaFv89QOeSbQN2yJu+kxhFIDEUxMFs04PJFaU22ehdT30f3+qK/nTLM SQnOSHpJjsBNGGHKmTALkFi6zcc2dxUNnR870A2exeM7GKeOlC+MJRNtCD7gRu7HEg/A YirlRgMlBkb0Ci9dmWGRlBUultWmUbN1oGRiyLHveDbd96DLwyPq609crXkOMuYL82dG d23B4mgwtxzBXz3pMXpr0ESekMmXW/x1dQyFmou+3fOtQCHCxg62yZmvZFssepxJujvB ghsXFzMWy0YgJ4ZApn/fZnjgOjKESMoSwr1E9wWDLKDnKqmC63NqA+veeNuvxjgj18w6 4Qlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dG799Z+tZ4ZUuxjbfVGrVm+Ne6DkCnHVroZEjbtppwU=; b=Gkacs4izaQfHKLbne1IJB/itvWwtf7ucMkJ9AXJjW2CVuasypDT+Va6407IMnPBL1s a8iSRj0XE2ZVs3JadQkms3DiZ5SDkbaOrSFXy4Lt62RtbpMuOn1Mw4OUBV0vhWD9HvsN delDgKWkLjyi57ytugYzikG6lFrtYQxM+dIQqzLZFTYXa9YXRNLXHLf5nBxbk502HcPR d+sJP+2+lJBnnAyRkZ7+O7CcfJpJjhUHSat96Ox4RPOrXaIpZfD2nNcK4SyPvr5AkXEq Oz9rE8HTpQzij9jPpLvgWz9S/X3ch8nzWhAlhIA7mHNBbPpVUU9arAFphzel/RO7w4qX 8ZpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a056a000ccd00b00536fa6bbb11si12185922pfv.344.2022.10.17.05.16.24; Mon, 17 Oct 2022 05:16:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230351AbiJQMQH (ORCPT <rfc822;ouuuleilei@gmail.com> + 99 others); Mon, 17 Oct 2022 08:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230149AbiJQMQE (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 17 Oct 2022 08:16:04 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FADB1CB03 for <linux-kernel@vger.kernel.org>; Mon, 17 Oct 2022 05:15:33 -0700 (PDT) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MrbVF6JM5zJn2K; Mon, 17 Oct 2022 20:12:53 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 20:15:31 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 20:15:30 +0800 From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org> CC: <gregkh@linuxfoundation.org>, <rafael@kernel.org> Subject: [PATCH v2] kobject: fix possible memory leak in kset_create_and_add() Date: Mon, 17 Oct 2022 20:14:46 +0800 Message-ID: <20221017121446.4190650-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746937055051599255?= X-GMAIL-MSGID: =?utf-8?q?1746937055051599255?= |
Series |
[v2] kobject: fix possible memory leak in kset_create_and_add()
|
|
Commit Message
Yang Yingliang
Oct. 17, 2022, 12:14 p.m. UTC
Inject fault while probing module (e.g. qemu_fw_cfg.ko), kset_register()
may fail in kset_create_and_add(), if it fails, but the refcount of kobject
is not decreased to 0, the name allocated in kset_create() is leaked. To fix
this by calling kset_put(), so that name can be freed in callback function
kobject_cleanup() and kset can be freed in kset_release().
unreferenced object 0xffff888103cc8c08 (size 8):
comm "modprobe", pid 508, jiffies 4294915182 (age 120.020s)
hex dump (first 8 bytes):
62 79 5f 6e 61 6d 65 00 by_name.
backtrace:
[<00000000572f97f9>] __kmalloc_track_caller+0x1ae/0x320
[<00000000a167a5cc>] kstrdup+0x3a/0x70
[<000000001cd0d05e>] kstrdup_const+0x68/0x80
[<00000000b9101e6d>] kvasprintf_const+0x10b/0x190
[<0000000088f2b8df>] kobject_set_name_vargs+0x56/0x150
[<000000003f8aca68>] kobject_set_name+0xab/0xe0
[<00000000249f7816>] kset_create_and_add+0x72/0x200
Fixes: b727c702896f ("kset: add kset_create_and_add function")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v1 -> v2:
Update commit message.
---
lib/kobject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/kobject.c b/lib/kobject.c index a0b2dbfcfa23..f5e943c9027b 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -982,7 +982,7 @@ struct kset *kset_create_and_add(const char *name, return NULL; error = kset_register(kset); if (error) { - kfree(kset); + kset_put(kset); return NULL; } return kset;