From patchwork Sun Oct 16 17:00:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 3103 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1089681wrs; Sun, 16 Oct 2022 10:05:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM55z7DVMEecKjFLuTsTWX+r/uw6wzD1dvSKqa1miptG7P2XPSBo1aGQp7W7GLJ80eaoqiL3 X-Received: by 2002:a17:902:b78c:b0:17a:ec9:51da with SMTP id e12-20020a170902b78c00b0017a0ec951damr7892425pls.159.1665939910417; Sun, 16 Oct 2022 10:05:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665939910; cv=none; d=google.com; s=arc-20160816; b=QkLVlBc/mT6uE8mcXPzkQAtD0eQsMLfU4rzFn9V30mStWF6WJBdK+TGa51QIfOtaSP dRwkKlKfT5p7JmmDmTB7TSaaKasnXe+i5habnp94bOVWH7g7vO0OpiFyjsHbTs8wPJYv khbxRj/1yRySkh87blyCuMAv3KjlpKSSd0mUS83tj+W9pVykIU8X4WtgAoexCZd17TwX 6maNzsOnh+I3e9VA1pvhsPyKQJDbzTzfThB/PCwOipBOELI5Yr8DQZ3ft1Jq/M8ipMd/ 4cArEajIQnmbhJG3mBcLQbhz27YKvmFUnCQ9C1i/TcNzgrbGKo64NT0IhiHo0St+dZKX 2gzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mFK0jWSBGCqHueR6jez0prdbdNbJLNaBR9Qi0IdExSc=; b=lYiL2kns5gZaIDv0Eoe4eBMFmKRFbHRrH/t6kEsfNexB+dU9J/Lrs/NUJvcZS8XslK CfFlKshmDOlPFk3Vn9YJRVCN1wWaQEU12/S3qYBN/HFPOJ5JDaVQde5JYciXGu1igXnU zSEzzcl71XJg6yPUxnO26R0iCO4+qcIHpd4f6wnbXUrpXkIq0mi1Gsd5BuNQ7mtQhy2H J6j5s1usB4iSa5phYttzThEeFXoxkpwdE4vjdXOxQrLvK/2aEja2RS6TAmcPLKPrG9m3 T5x1TBWEI1pXqES9uZLGDwDbaAKeVAsBabXhnfTclEEXQOCvHFN6aVu22f1cXOHboZj+ GDXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zM+iLqfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a655801000000b0044ea0d0de54si9772251pgr.519.2022.10.16.10.04.57; Sun, 16 Oct 2022 10:05:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zM+iLqfM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbiJPREh (ORCPT + 99 others); Sun, 16 Oct 2022 13:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbiJPRDu (ORCPT ); Sun, 16 Oct 2022 13:03:50 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF8E44455C for ; Sun, 16 Oct 2022 10:02:48 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id s17so4251695qkj.12 for ; Sun, 16 Oct 2022 10:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mFK0jWSBGCqHueR6jez0prdbdNbJLNaBR9Qi0IdExSc=; b=zM+iLqfMP+UU5vkPKb2LwCNmEiZ1PnkKbrNOVbBM2k84fnpKFxK4IsXeYL0jdLkYqP pDGpl0cabRXNtidN57wKwwRLrG066yDvuTnpcyZ7bCMjwuG8E8WxnKz3LSMFSKxamrs3 pI5SZ1Ab1iefp8n60rSG+Dbn5HanzJ7xSemWpPhOMJKnSY5HJJ6Sq+J6YB4EpfbuQlxP rusH8zqSQFQKQNW9aH4N4/MCmfMU5tBgwZOBArLKlGMGgv1wDTyMWxfnDWfvw67s5rKQ rd50puphYKyhm6mDorZjC2E62ZyyGqzh9r/D7LRZ25SXmhGgFjWLZAUpGboZbZIe567i Takg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mFK0jWSBGCqHueR6jez0prdbdNbJLNaBR9Qi0IdExSc=; b=Au+IdDecaCD/tsekbhnzph3wSXHgkeA977qk3eB0SdBmQ5X/rdq6SPTKvQFWy8pSKT Pk4S7CDQO3CRHZOQ1BaCIdaz3kVbHzm6uivW9slee7o5yWP+4bR+dWjPE9f/EtEHVZHp /d1mlonXAh/nsM4APq59rC+k/SvgH21Pk5i6Mn3Na2ABvIyIqv5U9i9D+4e7ofnUsxgA wkzH30l63Jq00OO2LYHoRO9XGkkYv11kPyyOTFbSNNFRjY20ZibgEYpf6aP7OlbB8LFQ pKi7CIMeIKVgCO4uKUahs7eNWEPrmKcwkYBCIW9/+jmN7usfw+Kq+hFmfGevF4W9KUaL bTLg== X-Gm-Message-State: ACrzQf2OABaKtosYMnrhxoDxb2p7dBLZ6BAsnkk/EXi0BR+2bEAb8PR2 UCo4p2NXJE22JzsU0T4tWUtT7A== X-Received: by 2002:a05:620a:430d:b0:6d3:9dc9:d83d with SMTP id u13-20020a05620a430d00b006d39dc9d83dmr5142464qko.224.1665939756080; Sun, 16 Oct 2022 10:02:36 -0700 (PDT) Received: from krzk-bin.hsd1.pa.comcast.net ([2601:42:0:3450:9b13:d679:7b5b:6921]) by smtp.gmail.com with ESMTPSA id q6-20020a05620a0d8600b006ce7bb8518bsm7539967qkl.5.2022.10.16.10.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 10:02:33 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Stephan Gerhold , Shawn Guo , Vinod Koul , krishna Lanka , Sivaprakash Murugesan , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Rob Herring Subject: [PATCH v5 28/34] dt-bindings: pinctrl: qcom,sdx55: fix matching pin config Date: Sun, 16 Oct 2022 13:00:29 -0400 Message-Id: <20221016170035.35014-29-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221016170035.35014-1-krzysztof.kozlowski@linaro.org> References: <20221016170035.35014-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746864607253450348?= X-GMAIL-MSGID: =?utf-8?q?1746864607253450348?= The TLMM pin controller follows generic pin-controller bindings, so should have subnodes with '-state' and '-pins'. Otherwise the subnodes (level one and two) are not properly matched. qcom-sdx55-telit-fn980-tlb.dtb: pinctrl@f100000: 'pcie_ep_clkreq_default', 'pcie_ep_perst_default', 'pcie_ep_wake_default' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' This method also unifies the bindings with other Qualcomm TLMM and LPASS pinctrl bindings. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring --- .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml index a38090b14aab..fff57abf4fbc 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdx55-pinctrl.yaml @@ -45,9 +45,17 @@ properties: gpio-reserved-ranges: maxItems: 1 -#PIN CONFIGURATION NODES patternProperties: - '-pins$': + "-state$": + oneOf: + - $ref: "#/$defs/qcom-sdx55-tlmm-state" + - patternProperties: + "-pins$": + $ref: "#/$defs/qcom-sdx55-tlmm-state" + additionalProperties: false + +$defs: + qcom-sdx55-tlmm-state: type: object description: Pinctrl node's client devices use subnodes for desired pin configuration. @@ -146,7 +154,7 @@ examples: #interrupt-cells = <2>; interrupts = ; - serial-pins { + serial-state { pins = "gpio8", "gpio9"; function = "blsp_uart3"; drive-strength = <8>;