From patchwork Sun Oct 16 16:23:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 3062 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1078046wrs; Sun, 16 Oct 2022 09:25:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Twomwixk3jE+9YyTm5akXC6SAZf9TABkWw7w+0odQMX8/r6MuhM2fePS9lZoGPpUFibE4 X-Received: by 2002:a17:902:f60b:b0:178:6a49:d4e3 with SMTP id n11-20020a170902f60b00b001786a49d4e3mr8068007plg.75.1665937525769; Sun, 16 Oct 2022 09:25:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665937525; cv=none; d=google.com; s=arc-20160816; b=jm/r+V2r1HVyhsnQTIQXlGZq2BjnSp+EI1pD5N2XlpW3wX9UEJ4btxMMxyYqDmyQub Bpqp2lfjaLxGkvqoKEu35qo+F940hgqp+vDtZvWNZcOv/LuN1AbYZXgwu4BxGJFXOH8d IsBAWMx8rW1kREE35WMaFlcStvD7j22gVFM91wq0ve5J8vU5zvxKD1j96yAFC1LgZHiu nzuMePg9HvhZfLGVOhyE+9gQneN0WIc1t37SGMVZbKsdTUlVJVx7m2Xk1kygCJ29UgME llcwMRx/Rk7kTylUUHG/tXDFC8TAISywQagF+kj89JTm96aXHlmi8ZP3R1dcyRlBARO4 1ucQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8IMqQmd/XghF0vc5rGTchLEnwifIWdplO8ZK5ZR9Yzk=; b=A4KosX8+No8XX5PJl9IuIQyIK8hX5kSYIuiOkT7Mc2H396C8gIQolad4u7uiFZZDIM 1mcT5dcHsXLJT1SHyViIpFv17V6seysMHSO5XV56P6BBYLPXKSkYfsA0OGxLI6yYt8aW p3otdaVu4cMeiMf2I/jb8daM0507nWNgkerREy0YrTohXC3fDHbmt5hgnxqgudw6NlCt tlN+0Tkag4t1Qsqn/p1h7zsU/F/ZFzjW/PhahfL1usbujoFIcPDEBpHqBwW9QAYejiyW RpXOBhcpzgH8Rud4WpgLtmVZTYck/sdy+mSt+zmzlKlvVunZLULeTZReHRGIm32gKg6Y u2ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=py7m4915; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 132-20020a63008a000000b0043adff6d43dsi9324227pga.583.2022.10.16.09.25.12; Sun, 16 Oct 2022 09:25:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=py7m4915; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbiJPQYd (ORCPT + 99 others); Sun, 16 Oct 2022 12:24:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229764AbiJPQXy (ORCPT ); Sun, 16 Oct 2022 12:23:54 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF9A233E22 for ; Sun, 16 Oct 2022 09:23:43 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id a5so5401159qkl.6 for ; Sun, 16 Oct 2022 09:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8IMqQmd/XghF0vc5rGTchLEnwifIWdplO8ZK5ZR9Yzk=; b=py7m4915l5o5WsLd4bMO+78MLiz5ALzpVVpmzpKDyUl2p5IK12I+DK7uMK1ctklRZc 0ctsYyMCESSdCSlRIci8QFRlMwzZFyL/wDKPbOgLpI9GsDGWmO+UREym0nzKAi3x0z06 1U5rjt6VxS5AmaRVMN/lURrp/Fv3eAx599HvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8IMqQmd/XghF0vc5rGTchLEnwifIWdplO8ZK5ZR9Yzk=; b=Y2vm1rSHed6KB0wRwRi891ImRZFu1IwpSkFqsqViz9qABsNjKGZYnaqRGOrqnCDQ/z MQIrCxNNmJA8wVoH4v6Lk+mMkFg4PpycP45/arPZUwDwR6An1IXNbMAVwiqfq18E1Sxd e8ToBd1piLn0xB97uckva0/EpUb0dWf97/jq0MmFy7fTCM4pokgjGD050L0rehSsfCXs StXWeF53ZQ9BEC1lUB1CSp4JZgah9hb/OBKGyDv44An23ZNTa60fIBUC4M3yh9tPgTw6 n3iWaXjJzLj3xP9XVmgddOG46KfQVQDjszAQQ2t6u8rmWoElEUUYrcDTpoT+FHC3X/n6 wJ9A== X-Gm-Message-State: ACrzQf2kSXBAIfVoiCuPziHEm23hnTWjsVrEowU/Y57JXQpIBHrhJAuX AXAD8GJlFyoW/yfbNP+AeT3o6A== X-Received: by 2002:a05:620a:2045:b0:6ec:bd25:ea67 with SMTP id d5-20020a05620a204500b006ecbd25ea67mr5004470qka.85.1665937421414; Sun, 16 Oct 2022 09:23:41 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (228.221.150.34.bc.googleusercontent.com. [34.150.221.228]) by smtp.gmail.com with ESMTPSA id x19-20020ac87ed3000000b003436103df40sm6001207qtj.8.2022.10.16.09.23.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Oct 2022 09:23:41 -0700 (PDT) From: "Joel Fernandes (Google)" To: rcu@vger.kernel.org Cc: linux-kernel@vger.kernel.org, frederic@kernel.org, paulmck@kernel.org, Uladzislau Rezki , Joel Fernandes Subject: [PATCH v9 11/13] workqueue: Make queue_rcu_work() use call_rcu_flush() Date: Sun, 16 Oct 2022 16:23:03 +0000 Message-Id: <20221016162305.2489629-12-joel@joelfernandes.org> X-Mailer: git-send-email 2.38.0.413.g74048e4d9e-goog In-Reply-To: <20221016162305.2489629-1-joel@joelfernandes.org> References: <20221016162305.2489629-1-joel@joelfernandes.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746862106544840755?= X-GMAIL-MSGID: =?utf-8?q?1746862106544840755?= From: Uladzislau Rezki call_rcu() changes to save power will slow down RCU workqueue items queued via queue_rcu_work(). This may not be an issue, however we cannot assume that workqueue users are OK with long delays. Use call_rcu_flush() API instead which reverts to the old behavior. Signed-off-by: Uladzislau Rezki Signed-off-by: Joel Fernandes (Google) --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index aeea9731ef80..fe1146d97f1a 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1771,7 +1771,7 @@ bool queue_rcu_work(struct workqueue_struct *wq, struct rcu_work *rwork) if (!test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work))) { rwork->wq = wq; - call_rcu(&rwork->rcu, rcu_work_rcufn); + call_rcu_flush(&rwork->rcu, rcu_work_rcufn); return true; }