From patchwork Sat Oct 15 15:11:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 2949 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp679671wrs; Sat, 15 Oct 2022 08:14:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4/hNIz9jeyeFPPAQhaKRa0J/i5CmeqpJP/UK/n16v3O0NQYkoo1OpHKJXGchq3cUk8NvoV X-Received: by 2002:a05:6402:34d5:b0:45d:259:6237 with SMTP id w21-20020a05640234d500b0045d02596237mr2655281edc.164.1665846856540; Sat, 15 Oct 2022 08:14:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665846856; cv=none; d=google.com; s=arc-20160816; b=zUZzEzHeDvs1vxHITfCQ30KxoJzgqIceQIkFj9+dEa2gEr3cTJP5o10yI7JS5nSnX5 rFbtw9hGEMzvNQYPhCRetv76IDGyi+UmuuNyY6Y4LBbhVenMyf2c1hUzKz1N5Al3uquj WyzN4mwcV109ihgafHTUWZ1UO+751TbcMmVuUeuKuZAESQuSAWZer0godv/eRTOUchvR vD1kFuGDGkDJz3M3qD1zoztMng8RnSWr+7Vk8Z4Usd/t28kc4xRJmi4wnUhoSq4BXK6I NDC+CFf+0bypSjmK5Qpt9n6qK3U8/pYKQaf1bu9sc0iY/zB2EuSNhkgLMS5Kylnuh0mS skLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8rCeIVel5RLr7Xb3+AGczJdY6ehqE4+f2eIiuP14fqE=; b=xLlXi3jwpu/hbjks4KAJIsE7H27mVHB47ZfNrLWEpOeTagzH8KATqMLY89fUkwtv/+ WyLkn5r6Qfy8nWET27syjG1Dg4oZDhnx/uOZ2jcq5/lpU218WQkhm2zUbx4Oei6ClCM9 a+wjUnKD5uypQAghWEmR/cu6wP1oilJjk8fPhTeW6SmcYNsd5aNq0D56mWJr+Sv8Ghbk j1wxg//oBzp/IfU797aWc/2K3ggPlBUHTcZaaNWTIVHvLxGsjpUlpm7EhTlH6lgfiLL1 WlwiutiMlLJvuOEoCWgUmdUV8HmWQVzfW32i4FzrAqp5DE0p98d/BgJeE1v5fpJXSGtX qdlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w3-20020a05640234c300b004595a90c510si6460320edc.3.2022.10.15.08.13.50; Sat, 15 Oct 2022 08:14:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229782AbiJOPL5 (ORCPT + 99 others); Sat, 15 Oct 2022 11:11:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiJOPLo (ORCPT ); Sat, 15 Oct 2022 11:11:44 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7F344684D for ; Sat, 15 Oct 2022 08:11:41 -0700 (PDT) Received: from ipservice-092-217-066-135.092.217.pools.vodafone-ip.de ([92.217.66.135] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ojip7-0006sp-4g; Sat, 15 Oct 2022 17:11:37 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 07/10] staging: r8188eu: don't include rtw_led.h from rtw_cmd.h Date: Sat, 15 Oct 2022 17:11:12 +0200 Message-Id: <20221015151115.232095-8-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221015151115.232095-1-martin@kaiser.cx> References: <20221015151115.232095-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746767033321375693?= X-GMAIL-MSGID: =?utf-8?q?1746767033321375693?= The rtw_cmd.h does not need any definitions from the led layer, there's no reason to include rtw_led.h. When I tried to remove this component struct led_priv { struct adapter *padapter; ... I saw compiler errors because of this chain of include files: drv_types.h -> rtw_cmd.h -> rtw_led.h rtw_led.h uses struct adapter before it sees the definiton near the end of drv_types.h. (It seems that a simple struct adapter * prevents this problem.) The best option for fixing this issue is to not include rtw_led.h in rtw_cmd.h. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/include/rtw_cmd.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h index 20a65beed166..2f4595f13e86 100644 --- a/drivers/staging/r8188eu/include/rtw_cmd.h +++ b/drivers/staging/r8188eu/include/rtw_cmd.h @@ -6,7 +6,6 @@ #include "wlan_bssdef.h" #include "rtw_rf.h" -#include "rtw_led.h" #include "osdep_service.h" #include "ieee80211.h" /* */