From patchwork Sat Oct 15 15:11:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 2945 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp679281wrs; Sat, 15 Oct 2022 08:13:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7p3RDeJD6xZYBmqHynjudj1RKKKGc1fYM+izyyf4hduSNeHQCtHE3mmaNjxDNcV9sVK5/v X-Received: by 2002:a17:907:1c14:b0:78e:16cb:31bd with SMTP id nc20-20020a1709071c1400b0078e16cb31bdmr2375742ejc.394.1665846790423; Sat, 15 Oct 2022 08:13:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665846790; cv=none; d=google.com; s=arc-20160816; b=DdsX/srS8NhAUeWinpJMGQJn16pitggKkrTpUiXixAfnFjo1W8DUZ0NEuFm/8GsJoe gmtN0c+0JzCQDto2m3ozhAJbto7sr72l45Dz/BEuGQY3Lci5g+2d1idezAz0W6wX23mC lzroeaGmzyWrG9mBfPnfZUmWuCDDqvgJd4M0XbvLODrWiIe6hYkl2ZMkE4GWXWoH1SNV k9Rppl7bswGaOgfamFK4vhAg8zrMm1IERXbjbkF1vQk2/wdSoBOlKzPPhHAEJoA//JQi PSr3yUZpbpNTmT5dshQmvPUs5XFgY6KaKspVtnnW6AsaBZyNpNpY20Ct7QqodkUQfl8K qlBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Bh7c87ig+0IBkX+75lvtUlrgfjMKPqA3WUoo/6wY1QY=; b=zYbgeiITuVF6X6bl2pG97nXkSwZ+SXbvmc7D6QMybIDImkftPkOogiMMcHlviYsqTp DnB8Mz8li/lMjlQ/AkyzCzOj+nWlQWRgCiawv8AYgDogvSj/CLIal3bzLj6Klp+SF0je Sbfbtwvw736jbzaILdpQLJCTNnvkyFSTc35/bh1j+JiVXSyu+WWLRnwx1Qy6oh0G+6Df rz0B+459ppzvT7AXGSzj9xIJ8j+PvKwTNuSz2XBVps4cE7fvpZJB5tCRtDag7WMFC3VE HGYtfHiJ9jhTrMcMs2WWl9ugHPHTsqHkU3tmqglz6HvGRKbye1QOam8c9Ch1QmO7NG8d RKZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr29-20020a1709073f9d00b00781d984d289si5906447ejc.495.2022.10.15.08.12.45; Sat, 15 Oct 2022 08:13:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiJOPLo (ORCPT + 99 others); Sat, 15 Oct 2022 11:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiJOPLi (ORCPT ); Sat, 15 Oct 2022 11:11:38 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0768422DD for ; Sat, 15 Oct 2022 08:11:37 -0700 (PDT) Received: from ipservice-092-217-066-135.092.217.pools.vodafone-ip.de ([92.217.66.135] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1ojip2-0006sp-Fk; Sat, 15 Oct 2022 17:11:32 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 02/10] staging: r8188eu: handle rtw_write8 errors in SwLedOn Date: Sat, 15 Oct 2022 17:11:07 +0200 Message-Id: <20221015151115.232095-3-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221015151115.232095-1-martin@kaiser.cx> References: <20221015151115.232095-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746766964350003301?= X-GMAIL-MSGID: =?utf-8?q?1746766964350003301?= Check the status returned by rtw_write8. Update bLedOn only if we could update the REG_LEDCFG2 register. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_led.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c index 5b214488571b..4f1cad890cae 100644 --- a/drivers/staging/r8188eu/core/rtw_led.c +++ b/drivers/staging/r8188eu/core/rtw_led.c @@ -34,7 +34,9 @@ static void SwLedOn(struct adapter *padapter, struct led_priv *pLed) if (padapter->bDriverStopped) return; - rtw_write8(padapter, REG_LEDCFG2, BIT(5)); /* SW control led0 on. */ + if (rtw_write8(padapter, REG_LEDCFG2, BIT(5)) != _SUCCESS) + return; + pLed->bLedOn = true; }