From patchwork Sat Oct 15 00:12:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 2892 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp432445wrs; Fri, 14 Oct 2022 17:20:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kiwXkPEcF01ofZE2cyIVd23wIpycOMVLH8YUWmLkx6vkh6MGtrvhlys6/ojoLirlUnNR+ X-Received: by 2002:a17:907:7e9e:b0:78d:f3b0:fc78 with SMTP id qb30-20020a1709077e9e00b0078df3b0fc78mr373660ejc.478.1665793231961; Fri, 14 Oct 2022 17:20:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665793231; cv=none; d=google.com; s=arc-20160816; b=aqnVQ5f334IN2X0nou4SQcfCCJ1t41K1+gaVrFiUTMlhayYy8J+ggjCYPCXCe/feIR Xl0iBJFcselvJ0WQkQnLdv1iytqr9SOugsBDP7vUNVVCCDBmcZy87og4Ks7kfn8ugXks u9Qs7sZCftJ2N+WvpCjbyWt0JZwZewcYGlGaLeFoR6cWvIKHvzwTSVP78Lxz+zlr042G JqrugZYzJeSILP2VCGINxv+A7gl6XYEVdh6PPTHSr5LeB71r8cyvNdvWs6pO/Hq4VT3P pddF6FiTnTMW6ppCIRrN6keuv33Gd5GTVX4CqLTqpVIZVr2m2EWsR63FaVRK8jKQLxME Y3Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KNt+pCSIUZ9+O3L8HoQe1tmbspN8QLuURkdKt3vda7s=; b=cQrID5wCXGVJ3mkMWnavq58kGnS3Yv1APSSD+orfh0T3IcoGuqE0ln3Earw2h2jAhf H2VctpTvGX71y+4EIDdkGAZmA1KmoMyf5R0nednel0I9ix60QKl6UZRxZIjPYXn6tsfc tYeME79kHfqGy6GushfV5ITmM1tvckVgIX0SwNMgzO54VhpeSTIKfqaByU9zKdUF4Bcb Cd4w80uZ7TwinrsJesZLy1DU2ixIspY8Oud2Az6Syd/m6edMyLSJUPH3I9AA7vd22tQw 2PY0uPuVyVcqPsAsoFNw7pDwI8mkIEOS0WsjkMvTHN2XTOaKfUeqpCMBFMfDcWdKqCSM C9qA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="ekN/1fFj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he38-20020a1709073da600b0078d89eabb6esi3637702ejc.732.2022.10.14.17.19.50; Fri, 14 Oct 2022 17:20:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="ekN/1fFj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbiJOAMn (ORCPT + 99 others); Fri, 14 Oct 2022 20:12:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229507AbiJOAMm (ORCPT ); Fri, 14 Oct 2022 20:12:42 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06DEDE083; Fri, 14 Oct 2022 17:12:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=KNt+pCSIUZ9+O3L8HoQe1tmbspN8QLuURkdKt3vda7s=; b=ekN/1fFjDh8HdTdr8OyIHH1VZ3 1B+vgd01iZnf/itUErKgBI6cOUZdEIryUBIi7QTCLZGMstfAxWfeAYPvlo3CFivnE+wQHPSrzYW0O acGL9OA49uWn03sKPDxKg9XgnpIgYs7zv2QE1LejVxnphyYME/cn0Z9O0uxztpw28nhncRyD5EPMw YL6p078s0zH3RMzpqf6tf/Tzbk1fhu2M1tVDsUJ1FQ3ZNU7XYm8ayN/CBGM7fmOHr4k+sCDcKWDiK yuvHZaN6xhThWecIgpyts8ItC2+Qhr8BU1QHxeKVvY8o+yFEHtquMgk/zRwPnCcND2K6HpV6LMg2h +ZTgzp5A==; Received: from [2601:1c2:d80:3110::a2e7] (helo=casper.infradead.org) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojUn8-0081ai-Hl; Sat, 15 Oct 2022 00:12:39 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Srinivas Kandagatla , Banajit Goswami , Mark Brown , Liam Girdwood , Ajit Pandey , Cheng-Yi Chiang , Jaroslav Kysela , Takashi Iwai , stable@vger.kernel.org, alsa-devel@alsa-project.org Subject: [PATCH] ASoC: qcom: SND_SOC_SC7180 optionally depends on SOUNDWIRE Date: Fri, 14 Oct 2022 17:12:28 -0700 Message-Id: <20221015001228.18990-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746710804218656292?= X-GMAIL-MSGID: =?utf-8?q?1746710804218656292?= If SOUNDWIRE is enabled, then SND_SOC_SC7180 should depend on SOUNDWIRE to prevent SOUNDWIRE=m and SND_SOC_SC7180=y, which causes build errors: s390-linux-ld: sound/soc/qcom/common.o: in function `qcom_snd_sdw_prepare': common.c:(.text+0x140): undefined reference to `sdw_disable_stream' s390-linux-ld: common.c:(.text+0x14a): undefined reference to `sdw_deprepare_stream' s390-linux-ld: common.c:(.text+0x158): undefined reference to `sdw_prepare_stream' s390-linux-ld: common.c:(.text+0x16a): undefined reference to `sdw_enable_stream' s390-linux-ld: common.c:(.text+0x17c): undefined reference to `sdw_deprepare_stream' s390-linux-ld: sound/soc/qcom/common.o: in function `qcom_snd_sdw_hw_free': common.c:(.text+0x344): undefined reference to `sdw_disable_stream' s390-linux-ld: common.c:(.text+0x34e): undefined reference to `sdw_deprepare_stream' Fixes: 3bd975f3ae0a ("ASoC: qcom: sm8250: move some code to common") Fixes: 9e3ecb5b1681 ("ASoC: qcom: sc7180: Add machine driver for sound card registration") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Srinivas Kandagatla Cc: Banajit Goswami Cc: Mark Brown Cc: Liam Girdwood Cc: Ajit Pandey Cc: Cheng-Yi Chiang Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: stable@vger.kernel.org Cc: alsa-devel@alsa-project.org --- Sorry, I can't tell which Fixes: hash is appropriate here. sound/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig --- a/sound/soc/qcom/Kconfig +++ b/sound/soc/qcom/Kconfig @@ -187,6 +187,7 @@ config SND_SOC_SC8280XP config SND_SOC_SC7180 tristate "SoC Machine driver for SC7180 boards" depends on I2C && GPIOLIB + depends on SOUNDWIRE || SOUNDWIRE=n select SND_SOC_QCOM_COMMON select SND_SOC_LPASS_SC7180 select SND_SOC_MAX98357A