From patchwork Thu Oct 13 18:38:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vidya Sagar X-Patchwork-Id: 2314 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp429346wrs; Thu, 13 Oct 2022 11:54:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5B1/YJGjVD+Q/OHOaiUIuyZ4690Nk251mEv6TnhkbbVCy8zuEMsmYHNFot3hUnlR4i0TtR X-Received: by 2002:a17:90b:4c42:b0:20d:7820:2e4e with SMTP id np2-20020a17090b4c4200b0020d78202e4emr12849150pjb.40.1665687264486; Thu, 13 Oct 2022 11:54:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1665687264; cv=pass; d=google.com; s=arc-20160816; b=0j7s1hffY0VxG9eUT3EnmdCy+EnIE+YPAEmKoenw1QJf7abVkNP2L59MdUVwZ+NLei 1Y4tze3kSSWlrge9isHQkIC+nnatw3OIBy8qQDFqYv9DiqI1bjIqpxkjj0jWKE8xuDGd NKgucx/M5g35lgXZcYIr4UFKlYHTHGEzSwaJbwjVzUtK4oa2Wrvjg4QhyrXldChUfu4+ innecQO5K7d+ydpg9oylofb4zlr7y4p9bPwcnrfea7m30sj5NFHtC4WrPmXnvkQBrDfc hLkpg8MMblqaw/J+tz5zzZXyWmfsHxL9W9DU0ehyrs465bMvgOSU1StaWOiyd/UW1//c N1Qw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=TBq528JAPZeXu0EMALg3NgzpdfQf6SWx9QDHMwRTqSg=; b=IASEd3cl1x/00nKqy2VSLrbvEC6F80o3FsUsKDviXtbCdT2Fb5SwAZ8wgtxdxi2Hdp 5nltWPkUOJig3tI+wXfE27ShJsrolC4yttGSK2JmbnAt4WM27so4UTmxrKnCoUUAM4Fb bST3hXtW/twU5n5L8d9MlnWJiTbMEiNWckr3oHRVVn746YnqTWAzLfgT0fdGAUIgTAjx aqwLW6Y8otfuQTMAguepVJWpMnaog1/N17t1weVPY6WlAJa33D/YyuFwcvnffHIz9hes AxHNicwhBkEBnO/yzzEZE4akakqCXrDpxAVNfH2ZBulfqOl8J8OxKUTDSu9JZqVRogyN r/hw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=sRl+oBpS; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nvidia.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a056a00174700b005660f2c4b27si122044pfc.274.2022.10.13.11.54.09; Thu, 13 Oct 2022 11:54:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@Nvidia.com header.s=selector2 header.b=sRl+oBpS; arc=pass (i=1 spf=pass spfdomain=nvidia.com dmarc=pass fromdomain=nvidia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232132AbiJMSmg (ORCPT + 99 others); Thu, 13 Oct 2022 14:42:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231964AbiJMSmS (ORCPT ); Thu, 13 Oct 2022 14:42:18 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2062e.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37B33BC616; Thu, 13 Oct 2022 11:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APmQ0KiOP8x5ppcxzOgVWLLsz4xH05zZlMmqmX0o2mZK4CSw+lL5MGcPNBL6TxE+oxM0qHdyxWJDgvAhdqyuRLRb+TquzEv3Y4AbK4SVKL0Z7rM+JQJqFT2YCHxtN09Mh1MG2vF/yI+V8QMeg+/TJpJHinipW+eSDeCRiwk1XkGEJfnRc54GuWgxqwnlScdwNjMF6iknGduJTFzZOx2cc7y4ozZwawfzF490+WRsbcK9Pz79QBudpjWrv71apD3haTb1J4er/nkfMvhjH+tFn70EgTEPu7HQQzei+Gwh2FRnnZPHGGKifQQ1In4zRBvwiHokLuZ/l+CHG4V7YkgCag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TBq528JAPZeXu0EMALg3NgzpdfQf6SWx9QDHMwRTqSg=; b=a+BgRMUzpk8Y40D4qUk3e/CP1nEPhkkC9J69DEGz1qFQZir5y5dbhO16b/KW8w8C/3jPw+gcilp0SU4coKWMdHhW1/M5ptDxRMMbe3o4m6vSrUERWJPEw0AYItEPvUdiaLH/iqgMYH3b2E/NDHIyB6bkw9VntkI1zbxQwusIv1Xp3yjkCZwXnjLq2fUZVlmRIQHUr6YZ5eE5eLOCyIswmYfMJ8OEYU0GV2mscHMcsIL/+SdD0BcbtsJpN/9OUg5IxVY7wUnvbniPV7BOHx7ZyyeJ82l12aAPefTNnZBO/wv66RQNc/uwRn5NJucpH4mqLUKJ6so6DI2+uEJWzGbMCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TBq528JAPZeXu0EMALg3NgzpdfQf6SWx9QDHMwRTqSg=; b=sRl+oBpS59bZFzc0TaSQJVcUxSUJnl0huCtUpA7+hRNfytQi1DHtWcuy96lxKMA+DxapqtZc8XrYdbLu9u6bWrmURg/yJfewLOj2pb3T29IVB0uqM1uyetlX1QZiQCnjfFJ0G94JbdXAm3KzuYBvD8138FFH83kOcKFVM323U9GODgp+hxmdpbEo7AixrYxxI7xG7lOkSvdeZSBwrbgkv4RnOqMdh50IgnOhgcb0iCyjVTzhtlOo99uK3956ZwkyV95e3SRU6vdcPMexz9qGXLneciTz7YnbEOlKI5GPIalcYWjPWWQwzxsU36nrBWdc2QQM63QdNuic+bRf/oO8bA== Received: from DM6PR10CA0028.namprd10.prod.outlook.com (2603:10b6:5:60::41) by PH0PR12MB5605.namprd12.prod.outlook.com (2603:10b6:510:129::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Thu, 13 Oct 2022 18:39:33 +0000 Received: from DM6NAM11FT074.eop-nam11.prod.protection.outlook.com (2603:10b6:5:60:cafe::a1) by DM6PR10CA0028.outlook.office365.com (2603:10b6:5:60::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.22 via Frontend Transport; Thu, 13 Oct 2022 18:39:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by DM6NAM11FT074.mail.protection.outlook.com (10.13.173.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Thu, 13 Oct 2022 18:39:33 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Thu, 13 Oct 2022 11:39:23 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Thu, 13 Oct 2022 11:39:23 -0700 Received: from vidyas-desktop.nvidia.com (10.127.8.9) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.986.29 via Frontend Transport; Thu, 13 Oct 2022 11:39:18 -0700 From: Vidya Sagar To: , , , , , , , , , , CC: , , , , , , , Subject: [PATCH V3 03/21] PCI: tegra194: Fix polling delay for L2 state Date: Fri, 14 Oct 2022 00:08:36 +0530 Message-ID: <20221013183854.21087-4-vidyas@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221013183854.21087-1-vidyas@nvidia.com> References: <20221013183854.21087-1-vidyas@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT074:EE_|PH0PR12MB5605:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f8260e9-1b4f-43d6-cec7-08daad4a45a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9yWnphlIiD96OWLIPbl7IaCpKeRaIWc3Sb1C3eKZuEyMgGi8OCGBjlx0so6Zvxu9WRGU9V/5EudOyief0fC0UBkeJGIMIETt3SF+StwkXB9GZSbS0v1822FIiKcthmDYDBVwtfqrlqqrIJ13J+PDuIXkDpClNJWLog0auwB5AIrLhUHw2VGT6u6vqBre1C1Im7nMc4Sb59g+LWsly2iK7Jo1lNzk5gjb6a7mXETdNDD6DgqXkBiNQdBOE5cTvU/tIZE4GdFWwizMXf5jUt27UjPU0CEHm3emAvEj7/Wp3ouyWMjSpgZNhSnFgYlHKsM0D99giC8u0BXoDQjrDos06K+Oi6BcolYPMOUjwPKSSexM6ZDG2mFPdna0f+rriLOaWtQZqTa2iRSJr17Qa2kctkk4nAUQUj3ldktNJ9rK3pZQWGtDIS3TswDYc4/Abl597VTM9bm/lMwv5qnkjpBJ4pTvug+2PjA55+LVIVByCoQtHI/p4EOCIadHM+rd0KFZkAPtpHkQtJXoJu5eZTnklkWMTSXqgnZOY31psUc1d8KkAEkxweoz1zfSWO0d6qeTCQW/7ExnuNoybKy1uYqe8vkc0anM1iOIGZbVFdP5h00WtCoknE+kqWI7c5/b39I/DwsZzyLuxaSHDr/6vXgzc906L1+4nW5e0scc+IvNiybj/KvWIZ5a/oLSmKHEO7SelWSp2yl4vjIFG6kaD3fBoekiQ+/Iz1fYp/1x8dUXG5BPxqQe71w3XLeTtauqspuaWqd4/r5FwfkOLYCOyElv+A6X5+8nCu0NlzxfoBAVGFY= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199015)(46966006)(36840700001)(40470700004)(36860700001)(83380400001)(426003)(47076005)(110136005)(316002)(8936002)(70586007)(70206006)(4326008)(8676002)(54906003)(86362001)(41300700001)(1076003)(186003)(36756003)(40480700001)(2616005)(336012)(2906002)(82740400003)(26005)(40460700003)(921005)(7636003)(82310400005)(6666004)(356005)(5660300002)(7416002)(7696005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 18:39:33.2554 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f8260e9-1b4f-43d6-cec7-08daad4a45a4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT074.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5605 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO, SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746599688808907865?= X-GMAIL-MSGID: =?utf-8?q?1746599688808907865?= As per PCIe spec r6.0, sec 5.3.3.2.1, after sending PME_Turn_Off message, Root port should wait for 1~10 msec for PME_TO_Ack message. Currently, driver is polling for 10 msec with 1 usec delay which is aggressive. Change it to 10 msec polling with 100 usec delay. Since this function is used in non-atomic context only, use non-atomic poll function. Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support") Signed-off-by: Vidya Sagar --- V3: * Changed atomic call to non-atomic call * Reworded the commit message V2: * None drivers/pci/controller/dwc/pcie-tegra194.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index a33c86e3de9d..685aee378c93 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -207,7 +207,8 @@ #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_MASK GENMASK(11, 8) #define CAP_SPCIE_CAP_OFF_USP_TX_PRESET0_SHIFT 8 -#define PME_ACK_TIMEOUT 10000 +#define PME_ACK_DELAY 100 /* 100 us */ +#define PME_ACK_TIMEOUT 10000 /* 10 ms */ #define LTSSM_TIMEOUT 50000 /* 50ms */ @@ -1611,9 +1612,9 @@ static int tegra_pcie_try_link_l2(struct tegra_pcie_dw *pcie) val |= APPL_PM_XMT_TURNOFF_STATE; appl_writel(pcie, val, APPL_RADM_STATUS); - return readl_poll_timeout_atomic(pcie->appl_base + APPL_DEBUG, val, - val & APPL_DEBUG_PM_LINKST_IN_L2_LAT, - 1, PME_ACK_TIMEOUT); + return readl_poll_timeout(pcie->appl_base + APPL_DEBUG, val, + val & APPL_DEBUG_PM_LINKST_IN_L2_LAT, + PME_ACK_DELAY, PME_ACK_TIMEOUT); } static void tegra_pcie_dw_pme_turnoff(struct tegra_pcie_dw *pcie)