From patchwork Thu Oct 13 17:52:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp405953wrs; Thu, 13 Oct 2022 10:59:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5hgp0y3dCVe9FYqxyNbA9lyD0JmZbO+U6f5ro9UPSY8+CK+RPje8xfa7rCDGctrkByiVSM X-Received: by 2002:aa7:df04:0:b0:45b:cb0d:856a with SMTP id c4-20020aa7df04000000b0045bcb0d856amr877302edy.180.1665683972196; Thu, 13 Oct 2022 10:59:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665683972; cv=none; d=google.com; s=arc-20160816; b=E8CqbSZCeE92s3lBcH9Q5/otZ8jRIW57n+EJniVGhL7HTDk/dcCWeXS0PRetHzuEiD epXF2VWSOY4H+24n3bC2qPD7MglNWKqv/T61QxJaVCfto5gO0nfRoGTV0o/uVcrbi4xb Aj/bfJVsVGOSvjXbXcSWGWyh9q+oZNw9jja+jhIjvRJIRaPmawJ7fQtc1NUFX5QsQaCw 0h1OZygh/D81YTZJ/L1n5WXpjGOJeX9GHb7wsxeq0q8jCKhHe+r49I3yBK06fJHZ7gDZ r1qGIE3+QAb9lEoaLM4nAj0VwxGQ43nsbTL4NhCxio+sFk2CTbANrYBtMckA81buW8Jy dmDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=2WFche8l8LAWJRzDYEj+4+tO2BFm7qSH/egqLC3PzkA=; b=K3XxfyDe0u8KpV5L2toWc3c7vsbbV49REWrgSJZiqQ6vaqMa7mBJmEEUhDZemAdd+R d43gwwp1vw4L06OqjUDyzmKEdcsW5Hu6kV5Z/UDxe/z6sHJ+2wNhXPyF/dWoYgJEo8G2 9MuBnOJsTAa1h2d9frLyVtXB1gbCyTJnFbhMdmfQvpElh7/lX/wZttSqq7VplBMFSlNd ku5RUnafUCp2PDtx4wmL526kgkTec4NpNARVjkso4ignoSWsM5mNgdvTpFC/85WsoW2s W2sQ0tjdoNM2Dfe/Jwqo2ETljYzJQyjpQGz5/ka/kfjKorpK4LdqXTK2zJ9LB2ipeDlr Ci5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i0PUM2dh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa2-20020a1709076d0200b00780a882d337si297327ejc.480.2022.10.13.10.58.56; Thu, 13 Oct 2022 10:59:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=i0PUM2dh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbiJMR63 (ORCPT + 99 others); Thu, 13 Oct 2022 13:58:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbiJMR51 (ORCPT ); Thu, 13 Oct 2022 13:57:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1956C153822; Thu, 13 Oct 2022 10:56:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8B701B82020; Thu, 13 Oct 2022 17:56:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E682FC433D7; Thu, 13 Oct 2022 17:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683772; bh=m70n2N51v/QEnM8AKO7qBTm28P5G0sjeuCrtu2kY804=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i0PUM2dhGE4O0ca/L4epfznUKsQe5X53qzVXclD65PLtVoaIsAya9Xv2V0uysnqUf +Z0FHwrHWMfGi5tHMVjlVUkA/665juR8/tE6D6/Lv+QJNQCKjzOgmv6xuhsXdcwDaU aqElA9LRZgqutavdl34veyLCQ8uGciduLtODY+SY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Swati Agarwal , Radhey Shyam Pandey , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 18/54] dmaengine: xilinx_dma: Report error in case of dma_set_mask_and_coherent API failure Date: Thu, 13 Oct 2022 19:52:12 +0200 Message-Id: <20221013175147.807202567@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175147.337501757@linuxfoundation.org> References: <20221013175147.337501757@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746596237125457444?= X-GMAIL-MSGID: =?utf-8?q?1746596237125457444?= From: Swati Agarwal [ Upstream commit 8f2b6bc79c32f0fa60df000ae387a790ec80eae9 ] The driver does not handle the failure case while calling dma_set_mask_and_coherent API. In case of failure, capture the return value of API and then report an error. Addresses-coverity: Unchecked return value (CHECKED_RETURN) Signed-off-by: Swati Agarwal Reviewed-by: Radhey Shyam Pandey Link: https://lore.kernel.org/r/20220817061125.4720-4-swati.agarwal@xilinx.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/xilinx/xilinx_dma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index b91378fb891c..e76adc31ab66 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -3071,7 +3071,11 @@ static int xilinx_dma_probe(struct platform_device *pdev) xdev->ext_addr = false; /* Set the dma mask bits */ - dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + err = dma_set_mask_and_coherent(xdev->dev, DMA_BIT_MASK(addr_width)); + if (err < 0) { + dev_err(xdev->dev, "DMA mask error %d\n", err); + goto disable_clks; + } /* Initialize the DMA engine */ xdev->common.dev = &pdev->dev;