From patchwork Thu Oct 13 17:52:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2157 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp405632wrs; Thu, 13 Oct 2022 10:58:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4EN2CZg6JaMPohXHIFxn6f7iUPnzRVDmBNXAc8L6CkQ59Y6j7XGRHm7nvxc9OodBxtHCvE X-Received: by 2002:a05:6402:42c3:b0:45c:ec49:aacf with SMTP id i3-20020a05640242c300b0045cec49aacfmr859882edc.40.1665683910166; Thu, 13 Oct 2022 10:58:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665683910; cv=none; d=google.com; s=arc-20160816; b=iHUKTqp/z59MyBvdOsm4SrryBiykxy7JY9kxshUUYAOm+qsiL7EMWUnh7+kz4SUbZm z0n7XIh8QXjjWe54ZkLADH4FdStHtnl5cphdQ61okkZxZvjnGHp9VbJAovgJuZwXm7z2 7jm7JgJzlwF4DJONPHp6EfUKWbWSS21+UmacJQGaLTbmHPKZixmzdSjmygts9Imhijsj 30WYd04hAUccbMIYERmZSVDogkPt0ZszcB+ctAzrKIEgBcH4Zj/cY7selTINVnFjdeoK w9hnTg9In7J/zw6es6AdKboCIy9XuOGq3WQC+MIyhcfA160f/uEhADj9bFojgl2bG/xf hJGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=h60qYeNl5/MUfMplj99vDlSg+k0mVTLUVzNCYWDDgkM=; b=VEuSghCXqWqx6/05hf96BUeHV3p9S9EB6Q2waold3qx1E+1kor+6/RVQYfbgqR087z dY98g4u52fdOHufzUjIuRbS4ppvBinujuV5wCgyO53ZtVuilOhDlL+gUnppNY/w9mpX3 mQxJhPOkRmnlcIsNRiq4a0yLLvSbUCLV+23aQsqyWCeb9z2XRuAbkHomnWaUKDIH7tus AttJGL7pvIOXdYLL3xkc9XtPx13/h1yjiZSfjTY9h5VcwGod5VMX0P4FOza+FJgOD0o/ 1IlRsxnvU6rpnDGEeuSX7BwyylScHBm0xQbvHCEqwfwm1BDzXZBMWZTUtnqimvByoAVS J6KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kwepaxdl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g13-20020a056402090d00b00458cd6f8506si406048edz.173.2022.10.13.10.58.04; Thu, 13 Oct 2022 10:58:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kwepaxdl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230240AbiJMR5m (ORCPT + 99 others); Thu, 13 Oct 2022 13:57:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230040AbiJMR5L (ORCPT ); Thu, 13 Oct 2022 13:57:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A02B15B125; Thu, 13 Oct 2022 10:55:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 44A2361902; Thu, 13 Oct 2022 17:54:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24BD2C433C1; Thu, 13 Oct 2022 17:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683678; bh=QK+ufwlRBWl6ehYKJV4TG8Q8jxr+5/srJj3QzUt1L9s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KwepaxdlZpQvaKlXVxCUWTYXZYVCuY9t+aJ6mLR5Gjz8Bh5syQRTWhzrmytmdDHhJ GTllm7L0dkwiCMGVO5Iw75WKBbELyWDIT7CYr/RfkM9pOVFzQMtoDJO7SJz9SHdXPl MWisDow5IvSqrQPWCI7tjlJWsKGfHxh2NwaP9TV4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Aneesh Kumar K.V" , Yang Shi , David Hildenbrand , Peter Xu , Christophe Leroy , Hugh Dickins , Jason Gunthorpe , John Hubbard , "Kirill A. Shutemov" , Michael Ellerman , Nicholas Piggin , Andrew Morton Subject: [PATCH 5.10 12/54] powerpc/64s/radix: dont need to broadcast IPI for radix pmd collapse flush Date: Thu, 13 Oct 2022 19:52:06 +0200 Message-Id: <20221013175147.666153921@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175147.337501757@linuxfoundation.org> References: <20221013175147.337501757@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746596172186263482?= X-GMAIL-MSGID: =?utf-8?q?1746596172186263482?= From: Yang Shi commit bedf03416913d88c796288f9dca109a53608c745 upstream. The IPI broadcast is used to serialize against fast-GUP, but fast-GUP will move to use RCU instead of disabling local interrupts in fast-GUP. Using an IPI is the old-styled way of serializing against fast-GUP although it still works as expected now. And fast-GUP now fixed the potential race with THP collapse by checking whether PMD is changed or not. So IPI broadcast in radix pmd collapse flush is not necessary anymore. But it is still needed for hash TLB. Link: https://lkml.kernel.org/r/20220907180144.555485-2-shy828301@gmail.com Suggested-by: Aneesh Kumar K.V Signed-off-by: Yang Shi Acked-by: David Hildenbrand Acked-by: Peter Xu Cc: Christophe Leroy Cc: Hugh Dickins Cc: Jason Gunthorpe Cc: John Hubbard Cc: "Kirill A. Shutemov" Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/mm/book3s64/radix_pgtable.c | 9 --------- 1 file changed, 9 deletions(-) --- a/arch/powerpc/mm/book3s64/radix_pgtable.c +++ b/arch/powerpc/mm/book3s64/radix_pgtable.c @@ -997,15 +997,6 @@ pmd_t radix__pmdp_collapse_flush(struct pmd = *pmdp; pmd_clear(pmdp); - /* - * pmdp collapse_flush need to ensure that there are no parallel gup - * walk after this call. This is needed so that we can have stable - * page ref count when collapsing a page. We don't allow a collapse page - * if we have gup taken on the page. We can ensure that by sending IPI - * because gup walk happens with IRQ disabled. - */ - serialize_against_pte_lookup(vma->vm_mm); - radix__flush_tlb_collapsed_pmd(vma->vm_mm, address); return pmd;