From patchwork Thu Oct 13 17:52:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2303 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp428645wrs; Thu, 13 Oct 2022 11:52:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5iQVn8D6ROhGMMIy//Cnk5SlFZhzTox3Aq4aeud+4xvxoPsDP+yXpg5TRyQqy+K2RCJ76B X-Received: by 2002:a17:902:b942:b0:178:be25:203f with SMTP id h2-20020a170902b94200b00178be25203fmr1379720pls.101.1665687152631; Thu, 13 Oct 2022 11:52:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665687152; cv=none; d=google.com; s=arc-20160816; b=b4Vd/qPuOZm17TvJRH9WVViBqnNclXc0ZMUWEWZvZiBm9ZrSucO2guRy5+eFRQloLk nBG1Y+EQFIKxYX00pSUIwMEtNddb824/OiDLlu+GSP9ATr1qgE4twOH8Prb7plW3nneG 2zyBTVn1IDNoBDeGeH3aRGB4b65BpnPt+AkorcAZEgya0BORDgXYe2namzg7f9Jzia4s CD9Pm+vY+wTlAocqtnpR9FSfliO+7FEC3I4jADGLmALHuD1oiBIxopbBIP8/Xd9mhsSg oudxv8WRWCViqB39U5vBIb9oF/xEXWA2SItSdEPcQNgDoyA8sIyjvEiUI7hHrUz7814A 6F/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=KiZccsTHkuUele1UNuG6Ntr4PJ8NIyKDPrGMtz7je7o=; b=bZwA/cGxORlDAFRLm3Bp1bXdy/Z5WAYBjMZTZ15CY6OkSijnVTiseLT81NJMqWabaF D0On3RQJxDVa0ZsCu6kqiAWYpl9bLyhIMJRVVrHsBC9EOy5+QIhn4f5GZUCjwtzvQnw0 gGb1stGzT0PaUvlQL5pKOZ4gI3nYzqp5T8mLQIrVmSo8DbjaFyVIxCWbvMjRKyvK4BG6 d0s/tRvq0gyKMH9IctOOTynPkTX1LArt9pwaUNCa9JIr1N63W2MPCDIthjQkD7kJCAEr E/CPv1OGPm9LDje4tHF7QINzujwZJomF9x9tsenuKaaFTRg+2uZsjcBjc+2x8pxkVCWh Mj1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mF2VeCdM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a170902c95200b0017b977d1b7bsi617260pla.32.2022.10.13.11.52.20; Thu, 13 Oct 2022 11:52:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mF2VeCdM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230465AbiJMSke (ORCPT + 99 others); Thu, 13 Oct 2022 14:40:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbiJMSkB (ORCPT ); Thu, 13 Oct 2022 14:40:01 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C9E41AF2C; Thu, 13 Oct 2022 11:37:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C97F6B82053; Thu, 13 Oct 2022 17:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ED85C433D6; Thu, 13 Oct 2022 17:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683984; bh=YzomB7J4BsTWMhyhV0465aLsGEaRBA/Q+cVNwoCa4xM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mF2VeCdM/PEHI1RkiYJxS0RgrKMuLTz3h4d64QptTuZOL11crC0Jjd6nfESXdEPhR eidS2o9y6D9ikhnlNaaZQyYs1eRpkFf0LTptiBwskl8SIdJ/eyCfKV4P1tc00AY4Ms MnOcmQr7cRcSgqjX/YmS0oS4d0IgxTCs3Ekhp2nQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Hans de Goede Subject: [PATCH 5.19 09/33] ALSA: hda: Fix position reporting on Poulsbo Date: Thu, 13 Oct 2022 19:52:41 +0200 Message-Id: <20221013175145.560683354@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175145.236739253@linuxfoundation.org> References: <20221013175145.236739253@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746599571434320596?= X-GMAIL-MSGID: =?utf-8?q?1746599571434320596?= From: Takashi Iwai commit 56e696c0f0c71b77fff921fc94b58a02f0445b2c upstream. Hans reported that his Sony VAIO VPX11S1E showed the broken sound behavior at the start of the stream for a couple of seconds, and it turned out that the position_fix=1 option fixes the issue. It implies that the position reporting is inaccurate, and very likely hitting on all Poulsbo devices. The patch applies the workaround for Poulsbo generically to switch to LPIB mode instead of the default position buffer. Reported-and-tested-by: Hans de Goede Cc: Link: https://lore.kernel.org/r/3e8697e1-87c6-7a7b-d2e8-b21f1d2f181b@redhat.com Link: https://lore.kernel.org/r/20221001142124.7241-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2554,7 +2554,8 @@ static const struct pci_device_id azx_id .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), - .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE | + AZX_DCAPS_POSFIX_LPIB }, /* Oaktrail */ { PCI_DEVICE(0x8086, 0x080a), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE },