From patchwork Thu Oct 13 17:52:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp425573wrs; Thu, 13 Oct 2022 11:44:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM57n5nCthq/BUk+wCzxiGyXsaB/Mk7SKL3otdQVqp/R0yPjFnVRHTI7RARoZzTylDBfTl+3 X-Received: by 2002:a17:907:3f1c:b0:78d:cedc:7a9e with SMTP id hq28-20020a1709073f1c00b0078dcedc7a9emr819590ejc.600.1665686669949; Thu, 13 Oct 2022 11:44:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665686669; cv=none; d=google.com; s=arc-20160816; b=TAIb1/gcxBYm2oeuSnwSelhtTbtKO2E8YAAfYXpY+o9gIfMmppbujzw3XV1zi/KQ6Q REQgDRJjh3y2qivuUwjPamQZ75MfAresVagub/ECaC5S7aZYQj1g2WnbxLOemM4+aTik R7PNxWPh6w40SsBGumGVK3AGhNRGGnMB6dplHX8TlNgw/x/TsEE/dToYjjM0nZjh3Lwk mmxc1pq4MrjYlzJwsAzavyX8ZEpVMTqOCFlsgtug78sy0eO+BcxDgv/qx9aexjNorSMn Xw9C2EmQ2Cw2IOp/eurPTR70HV5AvSz6s+g+i0g4OG1oFe7jbYIjVyfDFbKxJU/zA2Lp 5bLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=38Oz0Q6zYSHYZT0Wi41XOfOEmD+E2Sf3Tz82skz/j5U=; b=v38yiP51qFigdVlr9oKloF7l0ERXpIHuJDP75A6ZUeiM5Iu17kRdQ/mubrpKo9Uj9Y mVNAqY/ecEEOW2+789CxHC6Pc5ONymL0WI5eOEH5fTRgD0Fxuve8UuYyybWQhzFSfokf O8GnySB1QgGJqQrgu1/An8W4zcbdFG+bT41alPM/8+JCIviuI3wcDJmvXUTt77Tjhhmk IKQTmSnDC+A/iEWfkUcSY2k9Wa+nFbApLoHKv7aKRirnTbiRp6sj4NL7ouBl9DVMPiDs FgxUU6p7HeM3CZP/dx7VHdUryJ+BUjx608oneuIy3UEkjB5Z3ACzCKSH5ReuwYRIDqHf lB4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h7VbJwb9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg5-20020a1709072cc500b00780636a4a58si328518ejc.626.2022.10.13.11.44.04; Thu, 13 Oct 2022 11:44:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h7VbJwb9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232027AbiJMS3W (ORCPT + 99 others); Thu, 13 Oct 2022 14:29:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231712AbiJMS27 (ORCPT ); Thu, 13 Oct 2022 14:28:59 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49599189828; Thu, 13 Oct 2022 11:24:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 60C9AB82054; Thu, 13 Oct 2022 17:59:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAB0DC433D6; Thu, 13 Oct 2022 17:59:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683978; bh=dJedo5s/cX6DAlf+BtxI9nuAynqWpllp7eHF1Gc1I+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h7VbJwb9kn+RXONNJU0+jIjS+Cell5Xh7qOoBVgU8SP8z3uaOfkiRsV+vIZbidvkz KLtvVV++iGEFjpB38f72eUI8BirCR/+qlCcOJ4lEZblOw4RKADINHBAOdxTF+ho2xI /7XntzHy628wH9/bi4Rd559S4Rwh7EzwWXo/PW8E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guozihua , Zhongguohua , Al Viro , Theodore Tso , Andrew Lutomirski , "Jason A. Donenfeld" Subject: [PATCH 5.19 07/33] random: restore O_NONBLOCK support Date: Thu, 13 Oct 2022 19:52:39 +0200 Message-Id: <20221013175145.478477562@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175145.236739253@linuxfoundation.org> References: <20221013175145.236739253@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746599065866637035?= X-GMAIL-MSGID: =?utf-8?q?1746599065866637035?= From: Jason A. Donenfeld commit cd4f24ae9404fd31fc461066e57889be3b68641b upstream. Prior to 5.6, when /dev/random was opened with O_NONBLOCK, it would return -EAGAIN if there was no entropy. When the pools were unified in 5.6, this was lost. The post 5.6 behavior of blocking until the pool is initialized, and ignoring O_NONBLOCK in the process, went unnoticed, with no reports about the regression received for two and a half years. However, eventually this indeed did break somebody's userspace. So we restore the old behavior, by returning -EAGAIN if the pool is not initialized. Unlike the old /dev/random, this can only occur during early boot, after which it never blocks again. In order to make this O_NONBLOCK behavior consistent with other expectations, also respect users reading with preadv2(RWF_NOWAIT) and similar. Fixes: 30c08efec888 ("random: make /dev/random be almost like /dev/urandom") Reported-by: Guozihua Reported-by: Zhongguohua Cc: Al Viro Cc: Theodore Ts'o Cc: Andrew Lutomirski Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld Signed-off-by: Greg Kroah-Hartman --- drivers/char/mem.c | 4 ++-- drivers/char/random.c | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -706,8 +706,8 @@ static const struct memdev { #endif [5] = { "zero", 0666, &zero_fops, FMODE_NOWAIT }, [7] = { "full", 0666, &full_fops, 0 }, - [8] = { "random", 0666, &random_fops, 0 }, - [9] = { "urandom", 0666, &urandom_fops, 0 }, + [8] = { "random", 0666, &random_fops, FMODE_NOWAIT }, + [9] = { "urandom", 0666, &urandom_fops, FMODE_NOWAIT }, #ifdef CONFIG_PRINTK [11] = { "kmsg", 0644, &kmsg_fops, 0 }, #endif --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1330,6 +1330,11 @@ static ssize_t random_read_iter(struct k { int ret; + if (!crng_ready() && + ((kiocb->ki_flags & (IOCB_NOWAIT | IOCB_NOIO)) || + (kiocb->ki_filp->f_flags & O_NONBLOCK))) + return -EAGAIN; + ret = wait_for_random_bytes(); if (ret != 0) return ret;