From patchwork Thu Oct 13 17:52:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2150 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp405423wrs; Thu, 13 Oct 2022 10:57:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4f0/c6ygFXeD4L9VUgoLvpAl1PNJiA/wRglj4f8zMjea358qfqdANLvbckKX+7SR4S4rEz X-Received: by 2002:a17:907:1de1:b0:78d:9919:38cc with SMTP id og33-20020a1709071de100b0078d991938ccmr656027ejc.311.1665683864417; Thu, 13 Oct 2022 10:57:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665683864; cv=none; d=google.com; s=arc-20160816; b=cnKZF7fa3Y8nTENXFiWNfcxrAzG2CpOomlMlMWAQg+EV/Q8nRVDbzY6h5185Zu4/i8 ps9215KWX+SLxkcdWS7IBLET84TlidFKFe5cxrcOlYRFDUTuaEHdYCEm27VTNcoXGcei D8R4d0vuon/l2qDa8S0jN2zn+kwTlcjkjPkQOauYf5UBUmK91aJ7BsbsnPLWpEIUwQ5Y BFfVnXRE/yfDQnyDWRxQbRS+Bu8hOLctk+M9vnEyx6bZjqsmsBU2HWF1Ihm8Iw9wliro kZfq9Xpa60/bhgLQfytpe4843a3UGr0a1t5NR3yIGdAnFL/8xGLsuyGXa1G6EesjpKHQ 9MDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=H/DeqSMwmlHjjLFRfWiWrpd26Srl7lJtmdQBJNtnnP8=; b=hV4XU3gRBmJrE39OEfzDNyx5/UNFq5RUCr6CZDKktUSC1kDmTUtTZOBPXNZiNxOy6V isAYwOsf3/EtvScxFgIAQxTvgh3kx2o86aehT3tIyidwR0kjEdjqGcd6TepAfwp5iGp+ QC/PDSo6Q/0zIvFc+IWjvkK7sSiuw4FAciBtRQyVQw4UWFf8MPHIi9jwGPTQoOROyAu2 7jFZtrO8wgfXRgzBhA505uO0f8FBTM54JjI4nOQk7hrhLGfK/42NwQmjzUB8cSTF9vNL A9fE7MuIsMasiMQhKd3eUaYnCyLstKYA13P20DlI1ejIVIOzdo/arXoU7Qt7nmhTkxkh 3ENw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zYSBJDhe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h16-20020a05640250d000b0045a1e2373dbsi395729edb.44.2022.10.13.10.57.18; Thu, 13 Oct 2022 10:57:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=zYSBJDhe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbiJMR4z (ORCPT + 99 others); Thu, 13 Oct 2022 13:56:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbiJMR4U (ORCPT ); Thu, 13 Oct 2022 13:56:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DECAF17E1F; Thu, 13 Oct 2022 10:54:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 61FEB618D1; Thu, 13 Oct 2022 17:54:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E192C433D6; Thu, 13 Oct 2022 17:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683661; bh=koIdHHm+RAcdg+P8y3HCy0PZ6vMhhsEEGVCvN5v35k4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zYSBJDhem2QnnVy+0pjHqarrKxwC4hcqxS7PCwOZEbKRfzcIjmDBHqHbUXNUdOs3e f+L4qcctJB4V6JLvemzlLwOSD7Yajo5L/RkmjLVxMVvqqgIUNIzLzIY+zjNOpDbXZi Cc6DHqikeesBlB3THOkxCVagW9josRkm38mJnOig= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Takashi Iwai , Hans de Goede Subject: [PATCH 5.4 23/38] ALSA: hda: Fix position reporting on Poulsbo Date: Thu, 13 Oct 2022 19:52:24 +0200 Message-Id: <20221013175145.039231243@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175144.245431424@linuxfoundation.org> References: <20221013175144.245431424@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746596123727386212?= X-GMAIL-MSGID: =?utf-8?q?1746596123727386212?= From: Takashi Iwai commit 56e696c0f0c71b77fff921fc94b58a02f0445b2c upstream. Hans reported that his Sony VAIO VPX11S1E showed the broken sound behavior at the start of the stream for a couple of seconds, and it turned out that the position_fix=1 option fixes the issue. It implies that the position reporting is inaccurate, and very likely hitting on all Poulsbo devices. The patch applies the workaround for Poulsbo generically to switch to LPIB mode instead of the default position buffer. Reported-and-tested-by: Hans de Goede Cc: Link: https://lore.kernel.org/r/3e8697e1-87c6-7a7b-d2e8-b21f1d2f181b@redhat.com Link: https://lore.kernel.org/r/20221001142124.7241-1-tiwai@suse.de Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2532,7 +2532,8 @@ static const struct pci_device_id azx_id .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Poulsbo */ { PCI_DEVICE(0x8086, 0x811b), - .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE }, + .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE | + AZX_DCAPS_POSFIX_LPIB }, /* Oaktrail */ { PCI_DEVICE(0x8086, 0x080a), .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_INTEL_PCH_BASE },