From patchwork Thu Oct 13 17:52:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 2115 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp403910wrs; Thu, 13 Oct 2022 10:53:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5IZ/hPKczweOyvA5S+VEKl9mRVrDxkDE20y0WGvs39SfhiUxcQ54kn8OeDOMRUfd6uIE78 X-Received: by 2002:a63:2a81:0:b0:43c:5fa6:1546 with SMTP id q123-20020a632a81000000b0043c5fa61546mr915424pgq.43.1665683637121; Thu, 13 Oct 2022 10:53:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665683637; cv=none; d=google.com; s=arc-20160816; b=bn1xL7k0nu9a0cHvUQ616Jq3UkRyYy4woH/V/8DhqWOqpQvBYKDtIOoWaLC2GZTQt/ ZqXjMkmmI8MAXakMZPK7WEZnOS/gCRk15y2ipzLYAEVbBK58ZNcJO4yyGq1ShKQhgnjb O4umeKWrvAGBbJxOZEQLf00FG9hkCrF25XdznTVfE3f48Y2ho57KhXV5W+KUflAT/CYg fm13dNOKO/+1D9JRzBBm+rlbDSK5cTpbRXVtXTyTQPnEB/LEyG9dcD8mZUC5FhJDFHtl 3Qhmybq8VW9l/VQVp3xFj/1K/9NoK3YZWvtyixKN5bS2DuUMe14m4tiJ5rXbHcooWTA5 ABgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oMbqpDJ5TYUrpPUex0g3OjD52Jl1ieIyrTfnWVGUbLI=; b=slligiyPujKDAoVRO0SWL1yNY5YE6joHnp7KVHB1aL/167Y2N0vBAW94QsEVXvsJdT wvd007q76Gr2o014mycD/OXKZ7ULIVIPg//GyJdjtP/F2JvhnIOYYRYqpLtK6x8TVP2T Dw0ym4Dme72Yu8CnAI6TQh1tBJqg5fhUSZ41w9cGc0HYvweX87t0bwsDaczEpHpcLeEG 2HoPsO8suJhGCBx8arfsJMPRjiejPq1cSriu4+P3lQ7UwfLkOztlRsHxnwswXhmZaj0P Hn3+4DjFJvcwVb/nPhA1petOIyDeDC0H8uhOJ7ygCoCsyeKBQnC1gi9ZbbKIm5ANYpDz Iqxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rPPMu4GQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk7-20020a17090b33c700b00205d60c9b60si219124pjb.92.2022.10.13.10.53.44; Thu, 13 Oct 2022 10:53:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=rPPMu4GQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229547AbiJMRwv (ORCPT + 99 others); Thu, 13 Oct 2022 13:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiJMRwq (ORCPT ); Thu, 13 Oct 2022 13:52:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701A714FD20; Thu, 13 Oct 2022 10:52:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA8B6618CF; Thu, 13 Oct 2022 17:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0277DC433D6; Thu, 13 Oct 2022 17:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665683564; bh=FMtJbvUlcZMfZJsHs+zcMqbDLnAq+to6DJYsgnmO13c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rPPMu4GQ7M8hKWkMuimnzAN7vmzkLRDGYwd+h/dHQbCPHtn7Mqor5u/BXGFbPFzVk psxkz0q0NfdmP3Hm3GoRPerHoVxYi3R1zFWvJ+8hChP8MQJy34ZfXQEn58QQa+mukZ qQ/1GjVOfIX3RPp5OnBxgdfPWhJRCVXezbHzBYuM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lukas Straub , Richard Weinberger , Sasha Levin , Randy Dunlap Subject: [PATCH 5.4 11/38] um: Cleanup compiler warning in arch/x86/um/tls_32.c Date: Thu, 13 Oct 2022 19:52:12 +0200 Message-Id: <20221013175144.640705949@linuxfoundation.org> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20221013175144.245431424@linuxfoundation.org> References: <20221013175144.245431424@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746595885300769022?= X-GMAIL-MSGID: =?utf-8?q?1746595885300769022?= From: Lukas Straub [ Upstream commit d27fff3499671dc23a08efd01cdb8b3764a391c4 ] arch.tls_array is statically allocated so checking for NULL doesn't make sense. This causes the compiler warning below. Remove the checks to silence these warnings. ../arch/x86/um/tls_32.c: In function 'get_free_idx': ../arch/x86/um/tls_32.c:68:13: warning: the comparison will always evaluate as 'true' for the address of 'tls_array' will never be NULL [-Waddress] 68 | if (!t->arch.tls_array) | ^ In file included from ../arch/x86/um/asm/processor.h:10, from ../include/linux/rcupdate.h:30, from ../include/linux/rculist.h:11, from ../include/linux/pid.h:5, from ../include/linux/sched.h:14, from ../arch/x86/um/tls_32.c:7: ../arch/x86/um/asm/processor_32.h:22:31: note: 'tls_array' declared here 22 | struct uml_tls_struct tls_array[GDT_ENTRY_TLS_ENTRIES]; | ^~~~~~~~~ ../arch/x86/um/tls_32.c: In function 'get_tls_entry': ../arch/x86/um/tls_32.c:243:13: warning: the comparison will always evaluate as 'true' for the address of 'tls_array' will never be NULL [-Waddress] 243 | if (!t->arch.tls_array) | ^ ../arch/x86/um/asm/processor_32.h:22:31: note: 'tls_array' declared here 22 | struct uml_tls_struct tls_array[GDT_ENTRY_TLS_ENTRIES]; | ^~~~~~~~~ Signed-off-by: Lukas Straub Acked-by: Randy Dunlap # build-tested Signed-off-by: Richard Weinberger Signed-off-by: Sasha Levin --- arch/x86/um/tls_32.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/x86/um/tls_32.c b/arch/x86/um/tls_32.c index ac8eee093f9c..66162eafd8e8 100644 --- a/arch/x86/um/tls_32.c +++ b/arch/x86/um/tls_32.c @@ -65,9 +65,6 @@ static int get_free_idx(struct task_struct* task) struct thread_struct *t = &task->thread; int idx; - if (!t->arch.tls_array) - return GDT_ENTRY_TLS_MIN; - for (idx = 0; idx < GDT_ENTRY_TLS_ENTRIES; idx++) if (!t->arch.tls_array[idx].present) return idx + GDT_ENTRY_TLS_MIN; @@ -240,9 +237,6 @@ static int get_tls_entry(struct task_struct *task, struct user_desc *info, { struct thread_struct *t = &task->thread; - if (!t->arch.tls_array) - goto clear; - if (idx < GDT_ENTRY_TLS_MIN || idx > GDT_ENTRY_TLS_MAX) return -EINVAL;