From patchwork Thu Oct 13 17:22:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 2102 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp394531wrs; Thu, 13 Oct 2022 10:30:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4WIGe/rG1/w6rqJMOUjqghlRkBzBNZF9157+puVnFB1g2Ah8mZ9MI0bLvUEk1gEQ37ea9Z X-Received: by 2002:a05:6402:2694:b0:45c:a035:34bc with SMTP id w20-20020a056402269400b0045ca03534bcmr747881edd.158.1665682237534; Thu, 13 Oct 2022 10:30:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665682237; cv=none; d=google.com; s=arc-20160816; b=LzGkb/sSuL6IhnjMm7f5cYpTyciejb1bX96elaKWxpCxY0mbkmZFIuay8m4g64XQ2W WKm13jDvbnTe9xB+NO4bdJNR1mXhwzH5g5+AmBWorHDcxZc6GbbvTsy6/gYrLpmjquA1 y6Yh1EeSThO2Py4jjaS/2weabBvqhdi6aF4XRP2Z3xcKi0zZDm5sU6IQpImYjkeP341j GEVcol6gkPv2pdGGgC3Wy6+AfXL9UHXgBVW/gYtaPsGEtddQtqxOT9pCObEzvmxcRovA ZSdEJVwyHeLW5Zqx3Xv9baDiFcOvZ1+qjYemE0hSXxF3bBKmP6UQWS0NfIiSPZTA5oaD IcMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Vg8MJ6E4cuH+qMf58kZ3kPfx04i1NF/b2a9NXZGjBPM=; b=uGiVPVqm/+RCU2MGhsn8bbc/lCLDIItdkYhFxd6WPdMH/QY3OY+H1yE4yaMhL6tMBL bhdpf0O9dx6iL/Fow3S1mZJIj5oSkXZLpEtvWkiYI4y4NuzsdKYjhAJnoXFN3Z25LOLo VdaMrWzi/UMl4ddfzk1LnqUqxRxu8/imCAKdcIVLH5Y3hZoQfqQ2oHfiV7KWx6ObKIQr VTsbtZcTMCT/Lo002gbXLAyfNgwKsCBo/WVCzlGsAICtceEJBKrRPhxuIi4MiHJtmESJ gU2xsVDOM16pb6rXPVUgu7LKCmIvWfIe2mLUue31XgvnXV2+247yyEB8Y3Bls6QvbHRp Vt3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ytd4iva9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ho19-20020a1709070e9300b00782bb167cb6si299818ejc.80.2022.10.13.10.30.10; Thu, 13 Oct 2022 10:30:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ytd4iva9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229815AbiJMRXC (ORCPT + 99 others); Thu, 13 Oct 2022 13:23:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbiJMRW6 (ORCPT ); Thu, 13 Oct 2022 13:22:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F49DDAC41; Thu, 13 Oct 2022 10:22:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D6196B81E1C; Thu, 13 Oct 2022 17:22:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B71EC433D7; Thu, 13 Oct 2022 17:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665681774; bh=UnJzqfIfoF9Ec/ZKlEcwsNBnPjENbI+mlZF66EUMZjg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ytd4iva9baTjO3x0ofoO0swRHdivI0QUyZZD1i4gNyInUMb3uZKfQWcreRWSIbwJx xXlLW1OQ5CzXXkK7PetJjo/HYxalKeJYiwBNdc6KxG0hO1crAKCE8DStcSRmBV4SZL gJX/s57SyMCzVOBpfwWGSBbEbQscqbdmaWR+RBbH4Bf6lFmj49ZQrmLVPrHV84hk3/ oyVlEoTtvNdEonHt4TmS9y8rjtC5Mp0lqyd+ASaSDKzeEVuAfuouefBr4oenkkhO6N OJU/RBCyjR930TkoOA+bn4NKgvuKBJgdn7XXkFzEvM03Skp9LgsNS9pTjxsaF+LO1p 2Tpi+OBqSvqkg== From: Frederic Weisbecker To: "Paul E . McKenney" Cc: LKML , Frederic Weisbecker , quic_neeraju@quicinc.com, joel@joelfernandes.org, rcu@vger.kernel.org, Lai Jiangshan Subject: [PATCH 2/3] srcu: Explain the reason behind the read side critical section on GP start Date: Thu, 13 Oct 2022 19:22:43 +0200 Message-Id: <20221013172244.1099010-3-frederic@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221013172244.1099010-1-frederic@kernel.org> References: <20221013172244.1099010-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746594418340345873?= X-GMAIL-MSGID: =?utf-8?q?1746594418340345873?= Tell about the need to protect against concurrent updaters who may overflow the GP counter behind the current update. Reported-by: Paul E. McKenney Signed-off-by: Frederic Weisbecker --- kernel/rcu/srcutree.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 8b7ef1031d89..5bf67d997796 100644 --- a/kernel/rcu/srcutree.c +++ b/kernel/rcu/srcutree.c @@ -1154,6 +1154,11 @@ static unsigned long srcu_gp_start_if_needed(struct srcu_struct *ssp, int ss_state; check_init_srcu_struct(ssp); + /* + * While starting the new gp if needed, make sure we are in an SRCU read + * side critical section so that the gp sequence can't wrap around in + * the middle. + */ idx = __srcu_read_lock_nmisafe(ssp, false); ss_state = smp_load_acquire(&ssp->srcu_size_state); if (ss_state < SRCU_SIZE_WAIT_CALL)