From patchwork Thu Oct 13 12:51:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 2044 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp266444wrs; Thu, 13 Oct 2022 06:05:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5Hdnwnj4p5xFP0yI/puhzXKLxSRk7aRlNlCZmdypyPj0GmmoLX0x9TWMsWuqrvwgK0+s58 X-Received: by 2002:a17:902:f689:b0:178:3ede:a12b with SMTP id l9-20020a170902f68900b001783edea12bmr35229348plg.156.1665666316502; Thu, 13 Oct 2022 06:05:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665666316; cv=none; d=google.com; s=arc-20160816; b=KSTxOQHPLfXKk5Os56bTo8A1Z1dM+X4eov8Znj1Wb7YFxO2FWqaupk0atBKIJQx1Bh xkKzbNKNY21ql3C/2DmsFkdG65PsZfzeh/VqJUWs1dujedRMmU0sJuJrSmNLiw1nZZB6 ca/bzfZ5n2shOShdMST4SnSr1UbR+9uCGlykEZw1pteUu+VbIv9K0TAw76hBEUdFH3uU 2PMfwrQIqUvCLkvT9o7y/mwADYniGvPoENQOlKL8eBDa53PPpL21E1oAH3YrKoENS3Um RPeMpp0b8n92wbGg2XgdkUBCGaJAYuf1jp8qfvv4UcbTeeY8irN8StCrdDT+1wbeF+it C+0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=a8xPngQ7Xav1IVqeX2fWSoDFWgcYJEV7TkYDvz0h/Mc=; b=JaHo7JDPFdvxfBLHILDJY0ZBQk1HAocVCKcG2AAfkaYizbwZVIwcBoPi3Ps7iG5e5C vBjkZbMM3lKfRnWdKwUpDdzmdwXTMphQr75oWDGuXV8Xr/HkXr89LGLdW9W0pOlrT4tI VFWAcLQbd0Y9SsY8yb7Zq8bcLWX14VYlTvH+uWdynTiKEfXaTENaUycwETt8RMdKSTpB H9K0g330PQ8uegoLQzaocnfJIC37R5FiFLWCE8v5RpajX15rxW2bXMT5tZGvo63Zjbdg 06MVJzLMkS67wAZ8368RBtEVsN5SfL1mAdG0x/3dh7JnuiKlO5dlCVq7aOaknrLU6g6Z Rkqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rOGynw/R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j7-20020a625507000000b005634d0b379dsi13116208pfb.115.2022.10.13.06.04.55; Thu, 13 Oct 2022 06:05:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="rOGynw/R"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbiJMMv4 (ORCPT + 99 others); Thu, 13 Oct 2022 08:51:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbiJMMvx (ORCPT ); Thu, 13 Oct 2022 08:51:53 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D421D12585A for ; Thu, 13 Oct 2022 05:51:51 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id j7so2697367wrr.3 for ; Thu, 13 Oct 2022 05:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a8xPngQ7Xav1IVqeX2fWSoDFWgcYJEV7TkYDvz0h/Mc=; b=rOGynw/RR8E+IosAIA02jON+pQh39XPXi5XXzgGskDZBNrZGR1TBTnpgImzmo9mhR8 RUCZ4vLUqTUjHiYL3tEw8zi+4pH1IZ2Kmzk8ii2IrLTjYTNmt5e3tEgLXnqWxqEyW20n gDSdAZNVhbtLaW4J1ciGqAiN+dStcXAXJnw2XRO43DSddm58r8WjgtaowhAeFh5lj7s9 yPl5EeG+G6FV8imgYKvzvg4QY52IxSOsC7VR+8tosIt2T4jwDvnTVkrF8gPJltFNFShB 8Eb9HW5Sgzx0atM7gpaATfXJ7lWgn8NVI482LgIh1nGKHDVehBtr2hoXLv+xKaWXiVGi ZrvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a8xPngQ7Xav1IVqeX2fWSoDFWgcYJEV7TkYDvz0h/Mc=; b=fCPw4fUFJgoyhrfVZxCWKolKC5gPNtGuHqNKbPdTkUGdquk/3xf8ogs8jEnmL75IE0 ULyo+yDvmr6wgBHHlhPVflzneYysvGbZGsZrw73RfKiupsYUzDT1+4Kzq/bxielwPivs XQdjzR6j/InqNtNNTmekIGTsx3KtpaZTUBUnvdv5sWPF/y3nsS1J4Ld8xZzZHEXbRhaL 0jUnKdXGrtwWM5oTQOG+x8h7uAbrojAfpMtRdaAoL/XFgU5TNGqalME3navT/NLwCKne zlJv5uMiBj4jFV++m8cFvkfCXJn/XxqA54wFC4n97t9J0XnoTx+MmOsaIZb0PfyJR+iz LeJw== X-Gm-Message-State: ACrzQf21Ne1BCVv0mcKQla+8CPpHbzAPMRx8I65HwoSzzmc7iKqv1540 0h+Lcv0SLwE1eRM/EuC3El9nKQ== X-Received: by 2002:a05:6000:2c5:b0:22f:5242:12fe with SMTP id o5-20020a05600002c500b0022f524212femr16939052wry.401.1665665510100; Thu, 13 Oct 2022 05:51:50 -0700 (PDT) Received: from planet9.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id m3-20020a056000024300b0022e3e7813f0sm1332292wrz.107.2022.10.13.05.51.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Oct 2022 05:51:49 -0700 (PDT) From: Bryan O'Donoghue To: sakari.ailus@iki.fi, dave.stevenson@raspberrypi.com, jacopo@jmondi.org, paul.j.murphy@intel.com, daniele.alessandrelli@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org Cc: bryan.odonoghue@linaro.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/3] media: i2c: imx412: Assign v4l2 device subname based on compat string Date: Thu, 13 Oct 2022 13:51:41 +0100 Message-Id: <20221013125142.3321405-3-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221013125142.3321405-1-bryan.odonoghue@linaro.org> References: <20221013125142.3321405-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746577723672935496?= X-GMAIL-MSGID: =?utf-8?q?1746577723672935496?= imx412 and imx577 return the same chip-id when interrogated via i2c. I've confirmed this myself by Sakari suggested we should add a new compat which should be reflected in the name of the media entity https://patchwork.kernel.org/project/linux-media/patch/20220607134057.2427663-3-bryan.odonoghue@linaro.org/#24894500 Set up the .data parameter of of_device_id to pass a string which we use to set the media entity name. Once done we can add in imx577 as a compatible chips with the media names reflecting the directed compat string. Cc: sakari.ailus@iki.fi Cc: dave.stevenson@raspberrypi.com Cc: jacopo@jmondi.org Cc: "Paul J. Murphy" Cc: Daniele Alessandrelli Cc: Mauro Carvalho Chehab Cc: Rob Herring Cc: Krzysztof Kozlowski Cc: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Bryan O'Donoghue --- drivers/media/i2c/imx412.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c index a1394d6c1432..9f854a1a4c2f 100644 --- a/drivers/media/i2c/imx412.c +++ b/drivers/media/i2c/imx412.c @@ -1172,6 +1172,7 @@ static int imx412_init_controls(struct imx412 *imx412) static int imx412_probe(struct i2c_client *client) { struct imx412 *imx412; + const char *name; int ret; imx412 = devm_kzalloc(&client->dev, sizeof(*imx412), GFP_KERNEL); @@ -1179,6 +1180,9 @@ static int imx412_probe(struct i2c_client *client) return -ENOMEM; imx412->dev = &client->dev; + name = device_get_match_data(&client->dev); + if (!name) + return -ENODEV; /* Initialize subdev */ v4l2_i2c_subdev_init(&imx412->sd, client, &imx412_subdev_ops); @@ -1218,6 +1222,8 @@ static int imx412_probe(struct i2c_client *client) imx412->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE; imx412->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR; + v4l2_i2c_subdev_set_name(&imx412->sd, client, name, NULL); + /* Initialize source pad */ imx412->pad.flags = MEDIA_PAD_FL_SOURCE; ret = media_entity_pads_init(&imx412->sd.entity, 1, &imx412->pad); @@ -1281,7 +1287,7 @@ static const struct dev_pm_ops imx412_pm_ops = { }; static const struct of_device_id imx412_of_match[] = { - { .compatible = "sony,imx412" }, + { .compatible = "sony,imx412", .data = "imx412" }, { } };