Message ID | 20221013-rpi-dpi-improvements-v3-6-eb76e26a772d@cerno.tech |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp152670wrr; Thu, 1 Dec 2022 01:04:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf545LsOW7oAX8zHyVXSJnodWL2n/p1aXNDR28pQT/ht+viH66lfBGgpTHILel6BZtFe6dkE X-Received: by 2002:a17:906:4bcc:b0:7be:6ab8:4ccc with SMTP id x12-20020a1709064bcc00b007be6ab84cccmr19530586ejv.713.1669885481477; Thu, 01 Dec 2022 01:04:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669885481; cv=none; d=google.com; s=arc-20160816; b=XfkJ0L+qtrNGy+Zv33zOuflkFp16U8UOn3O10Q0yB+EIgiBtAb6XlYD6G6rCdVY8BF xN0EUOk8APYtcByfgWvgD+/jji6pTL4ytK0+vsRQSM2yJguh2/11C9kNf0vpVbm7dSGv 8Cvz//cYjgFbVhjNgFtz/jdGXALedvjc81w43k/RGNhHysNbXWbV2aLNjs2bYg+HgYFw rhfD81jJZvXfUzAc8AV6pr55rgN0ah61Dd78PzfZVGh49S14o/2WaI8LznhXPiM28MbM +Yd4psk8iz2SFSAdoh1c6RP1k7CSwPyUjoGBXNQq4e+gmaO928Af52CltwxUCaFvhIB8 Blmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=flZpbgFJI/ilYSwKfteWsmLk+4m/grFK3e1Tp64wexRLaAtZz2oDGtZKuT92GHj1Xq BQaofITWLYm3/azxVSmAeqGxOV2zkN/I+vKDQBOyJIzzzs+PYDduusWkEX/qVF4DPTZ2 lLzlzY2DeWqRcjByCtY/eTUJLWyz2t6QIqVCc7R4iIzvdAGPP/XsQFN59e134l0PYhT4 ztVeE0rF8uUnplBNtFcxL4UGDmFyso0w3P5pkblJQ3jA3zgyH7N/Am2Kx7vUxlCteh6M PKJecK8xD7MciLd+0GSPl7mKY0+jc9VkrfKn8OLKKlt+09aEoCmesSgyrnsx0PWEtpgU zO8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b="AIMDJY/T"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=nttMxKjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g11-20020a056402090b00b00468fdd316e6si3506392edz.542.2022.12.01.01.04.12; Thu, 01 Dec 2022 01:04:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b="AIMDJY/T"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=nttMxKjS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbiLAIpO (ORCPT <rfc822;heyuhang3455@gmail.com> + 99 others); Thu, 1 Dec 2022 03:45:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbiLAIob (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 1 Dec 2022 03:44:31 -0500 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB12E8C69E for <linux-kernel@vger.kernel.org>; Thu, 1 Dec 2022 00:44:15 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4C1645C01AE; Thu, 1 Dec 2022 03:44:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 01 Dec 2022 03:44:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1669884255; x= 1669970655; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=A IMDJY/TOTF3FYZzKSFfSABapNtMgtstVZZwPeU5tKwfQ/u+pFUVhSViIyij4b0wO zbi7B659HN/qnkihiSgKXKhtZ69me94ozqbcO2OiB7a3i9yA60qkLT4TKW1eEVW1 fqwKC34AGKgw7uiTCkwIuUkCRDD27e0W49U0OJ2poV45otO2cZTdutwKYYKgxz6O xprIf2xbVxeuLCqjjh5uEXBCnn51PY12qzbs4GM/1jSkZamnTjBBCLAPLCXVv1xY DJGtTbvq1clXMBYNtYOeYDq64LjMez+oS6L3X4QNWzuR00no+Dpbq06xhZBfouJJ eT+VM+DEY4a4TtrjnmI0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669884255; x= 1669970655; bh=1vlWw3HWcseVhvxGIduvYvORASnSFa/0anA5xMkzYTs=; b=n ttMxKjSzh6M1U2J8XdbUvNH5nZj+9szvM34E4c08/kAKIZBCDAId0EDZ3C9YEK+J TzrafALHEbox1ajJW0Q/1Er88htT2sfmcE1Tl59bs6XdTMwsSb0xLQKTdfYjV/L6 DYCqw8rEM6aE7z/SQmxXURuWwiX2m0vyXcI7HpKg2sMeWSdeoZhJFae4L8xGwwfP Xh6EV25U4a7xvFExDK1w1SAzSHp7Rp51EbEZc5J1wjXnjNLeW211AAqDhzCu7ZVp GzQsVozVLrT+NT5vciZTyquUNC3FOt37D+hHuJa7vcZLz533nHSxGK1guqTS5vKh V11TURURvDZXPcYlFGCsA== X-ME-Sender: <xms:X2mIY54wfdxV3o9PxDQmr9UG1K743PpjO4E53iO3ztZe_MBFP6ae5g> <xme:X2mIY27DmXgPW7lv0-gSB2jdWeWjF7P6y9BIycxoFc1tswkaz3zUt1jWXTV1csMrv npfq25f32dy3_frFJU> X-ME-Received: <xmr:X2mIYwdi1QO95QYcmvrMbBNI9Bk-W5TjqpFzWyXEV46oH3SZOo_C5qjZs5NuANu6mvWGk4iXyYWlcLndBMWVO3rQnliH2GWc6WNadfZD60Spsw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdeggdduvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: <xmx:X2mIYyJzRA1UNeclhNtFR1cUsp8mB12CW_687gRKSJaZI9ERhxhafQ> <xmx:X2mIY9JVMQEsXuj_z-DyNaRkI0vc-y-xnG8DbE5awwAn4gm6FnP4lg> <xmx:X2mIY7zSmo-JnXQU4F5m9ov7ay6lakmwVBkujNCLVdaFqC4pX0G6kA> <xmx:X2mIY4cKai1rzk0RvxeAySlrDRz3aLcVzRo0EB1iMhXGLH7ztIxM_A> Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 1 Dec 2022 03:44:14 -0500 (EST) From: Maxime Ripard <maxime@cerno.tech> Date: Thu, 01 Dec 2022 09:42:51 +0100 Subject: [PATCH v3 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24. MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20221013-rpi-dpi-improvements-v3-6-eb76e26a772d@cerno.tech> References: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v3-0-eb76e26a772d@cerno.tech> To: Maxime Ripard <mripard@kernel.org>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh@kernel.org>, David Airlie <airlied@linux.ie>, Emma Anholt <emma@anholt.net>, Eric Anholt <eric@anholt.net> Cc: Dave Stevenson <dave.stevenson@raspberrypi.com>, Maxime Ripard <maxime@cerno.tech>, dri-devel@lists.freedesktop.org, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Chris Morgan <macromorgan@hotmail.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Joerg Quinten <aBUGSworstnightmare@gmail.com>, linux-kernel@vger.kernel.org X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1321; i=maxime@cerno.tech; h=from:subject:message-id; bh=Cj2SqCiv0e+hjTKV6Xz2WDeMWOb4ZCwlvcwXbXBSakE=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMkdmeziL3SX7zTrdP5+OHjOkrnCmxbrdmXuj3bKLXVqEgs8 c6ejo5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABOJm8DIcGpr/V/O79tuXdWqbfmh6n W57GFLhYNumMCrp72Xi9e/j2ZkmJZQ/Ovcls2bZx8IEhXgTPszQeDy78sbk56V/r5y2eyvPysA X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1751001838182836665?= X-GMAIL-MSGID: =?utf-8?q?1751001838182836665?= |
Series |
drm/vc4: dpi: Various improvements
|
|
Commit Message
Maxime Ripard
Dec. 1, 2022, 8:42 a.m. UTC
From: Dave Stevenson <dave.stevenson@raspberrypi.com> DPI hasn't really been used up until now, so the default has been meaningless. In theory we should be able to pass the desired format for the adjacent bridge chip through, but framework seems to be missing for that. As the main device to use DPI is the VGA666 or Adafruit Kippah, both of which use RGB666, change the default to being RGB666 instead of RGB888. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index ecbe4cd87036..fdae02760b6d 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -150,8 +150,8 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) } drm_connector_list_iter_end(&conn_iter); - /* Default to 24bit if no connector or format found. */ - dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT); + /* Default to 18bit if no connector or format found. */ + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1, DPI_FORMAT); if (connector) { if (connector->display_info.num_bus_formats) {