From patchwork Thu Oct 13 09:56:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 2004 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp182384wrs; Thu, 13 Oct 2022 02:59:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7x8LBprzJvxMNN5Hf6MjtIYeO8LvoVtPVEf1b7bwE52GRjLFpc3hi7RGIzLMOq2gxCyX26 X-Received: by 2002:a65:6e8c:0:b0:435:144e:445e with SMTP id bm12-20020a656e8c000000b00435144e445emr30837778pgb.96.1665655159030; Thu, 13 Oct 2022 02:59:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1665655159; cv=none; d=google.com; s=arc-20160816; b=cPMrOvjYZcqfXijgNJi42xjthPvkijSkzfEqua0YxSFS/rEyjwOb9R+t+mRONFcXrQ crYVthObEwmESOrB3N++4eQpMfGMpRQkDpCHG96I6+LFjqB+lF7OaQRVYMEHEdza1+yC 0SvservYaxXY9ytTqaeJ7MaVJJ2Xe+ISp3JoSEyVwspJ/GfVwOLktoXky2DrpgwnD03i LVD6JR96z6KIdQ4n9RSq5kUU5VoucMx10xTrC48PifN5Zj6mPkOFnTEQPutrLrq1oGNW mb+2Rf63z4lyTLd7UOQkABhv+GUeNxG5g3tZjP4IjNs99+Fmny1GOvgOD7ua2mkfgrBW e2TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :feedback-id:dkim-signature:dkim-signature; bh=u1MKeK43KUVSNr+zlGBU1hNNtkwDdXrF2GqPW2EMI4Y=; b=EIWVLK4m/rkA/7uPmQlhEti47bgIGwPC49anEN6mvp/0xsWhfqrW8XDpDwNvH3HVXW PtrxMcNo+pK3PKfEXf5po0S281yTo3CFdG2lqYUAvkrZR+Gk9btqz74Fh/SRJuVk6sI7 VnqX7X7tay88tcBFE74JDD7No7fz8vJtkjT1Z8EPCw+sPQo2UpczbuhMZagIvhC2164R kD0BeAZQ8+KN05l8jG5Fj4pVwRqMSj7WFo+YZy3pQyKWK2sHOxGBn2c7Skh2K1gBu510 09NAuEiYKUg0MGheCGiTfakNjnYP8RT1LRwv6nlKbEfCk2H3PVtW+h8BJBgZEtznzlDv r1WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=D+zZ1Fc4; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=EMKMv+y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l69-20020a638848000000b00462b85376ecsi11637703pgd.668.2022.10.13.02.59.06; Thu, 13 Oct 2022 02:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm3 header.b=D+zZ1Fc4; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=EMKMv+y1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbiJMJ51 (ORCPT + 99 others); Thu, 13 Oct 2022 05:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbiJMJ5O (ORCPT ); Thu, 13 Oct 2022 05:57:14 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD74F11879C for ; Thu, 13 Oct 2022 02:57:12 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B4F525C00A6; Thu, 13 Oct 2022 05:57:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Thu, 13 Oct 2022 05:57:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1665655031; x= 1665741431; bh=u1MKeK43KUVSNr+zlGBU1hNNtkwDdXrF2GqPW2EMI4Y=; b=D +zZ1Fc4ZBFSXef7tM+bIuF1Seiv0mr6zF4Vqwd243kEn5i/QHGrMLmko0N/1O81a qKpyywvkMls4P2sbY3XEIss+fpgk7mFrpR4lQ+aiwjQA5nzcHODog5S9HXQvTzdb WYFQjxeNT0/YKGYz2rqr8ap5zhDVHdW85IQHYzDt69ZBjbDDHRNI3jSIPTS+VkQq GuhQyd0Ux0pqUFUqHZ6e2+OJZdZ/XefBKs14IJ58l/UpsSnZKueftjyV02r/Qha1 WtR3dz/EJCqFFDQVf5QFYJPchxG8fGsg85r2Xf5jGEq4hMGy8KT5lVls9LU96pph 90titF7qZeGD+4Ki1SFtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1665655031; x= 1665741431; bh=u1MKeK43KUVSNr+zlGBU1hNNtkwDdXrF2GqPW2EMI4Y=; b=E MKMv+y19UkgmjQjJnz0/C0PQbdYCK3C+HlPyaVhiDPs08xmsw5waorM1KwnWd/LR e9jYpEyWlv/bPFixoX1woa/C4kTr0b4ju8HnqvFY50sNCdHodmquph8rS5afI1Tv 9o6QpFY+05eoGJLzG5C7y+zJXIN4ZvdEmaOB1bkC1TV1PbI8dF5WIR/5U7nCBK3i rh53bQmXgw87eWFGPoOqgTKVXMSmLcyzAQ70HZt+Hcof45JBv+nVD9Pe3KIrZh0s mlLJuPGFERFpe8w4d5JRDoyEyTxnKCO/yePo1A6HOalLJw+vGe6S56vMk6StwdlF 681aMbZ5r2C3h4hbQA7gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeektddgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffufggtgfgkfhfjgfvvefosehtkeertdertdejnecuhfhrohhmpeforgig ihhmvgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrf grthhtvghrnhepudduudfhveejteefgedvffdvvedvjedugedukeejhedtlefhffevtefh jeeltdevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomh epmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Oct 2022 05:57:11 -0400 (EDT) From: Maxime Ripard Date: Thu, 13 Oct 2022 11:56:48 +0200 Subject: [PATCH 4/7] drm/vc4: dpi: Support RGB565 format MIME-Version: 1.0 Message-Id: <20221013-rpi-dpi-improvements-v1-4-8a7a96949cb0@cerno.tech> References: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> In-Reply-To: <20221013-rpi-dpi-improvements-v1-0-8a7a96949cb0@cerno.tech> To: Maxime Ripard , Eric Anholt , Daniel Vetter , David Airlie , Rob Herring , Emma Anholt Cc: dri-devel@lists.freedesktop.org, Joerg Quinten , Chris Morgan , Maxime Ripard , Dave Stevenson , linux-kernel@vger.kernel.org, Laurent Pinchart X-Mailer: b4 0.11.0-dev-7da52 X-Developer-Signature: v=1; a=openpgp-sha256; l=1126; i=maxime@cerno.tech; h=from:subject:message-id; bh=ZQPHjwQYtyeJjJI91c4T4N+E7FyRjwcxYJLQyKTsOPQ=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDMnuD976HfHdkCzeup1vaZ7V8SR1Sy/mDWblL7pW/ftcJBnx 09+0o5SFQYyLQVZMkSVG2HxJ3KlZrzvZ+ObBzGFlAhnCwMUpABMJTmH4H1lpb6z/XEcsaYrTxLrqPT t2bv3ys2/HlK5JBTJBqmz51gz/g/YYvBDJ2W93qfqS8dKFkyI7Z9eFGQc/qmJ3CuS78YORFQA= X-Developer-Key: i=maxime@cerno.tech; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1746566024293288860?= X-GMAIL-MSGID: =?utf-8?q?1746566024293288860?= From: Chris Morgan The RGB565 format with padding over 24 bits (MEDIA_BUS_FMT_RGB565_1X24_CPADHI) is supported by the vc4 DPI controller as "mode 3". This is what the Geekworm MZP280 DPI display uses, so let's add support for it in the DPI controller driver. Reviewed-by: Dave Stevenson Signed-off-by: Chris Morgan Signed-off-by: Maxime Ripard Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c index 1f8f44b7b5a5..7da3dd1db50e 100644 --- a/drivers/gpu/drm/vc4/vc4_dpi.c +++ b/drivers/gpu/drm/vc4/vc4_dpi.c @@ -182,6 +182,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder) dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3, DPI_FORMAT); break; + case MEDIA_BUS_FMT_RGB565_1X24_CPADHI: + dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2, + DPI_FORMAT); + break; default: DRM_ERROR("Unknown media bus format %d\n", bus_format);