From patchwork Tue Feb 14 07:05:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 56707 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2811012wrn; Mon, 13 Feb 2023 23:09:37 -0800 (PST) X-Google-Smtp-Source: AK7set8Q2yQNh1Y+5mSswyXVMDwHHNZGkzWtiJZijw+6vG4yXDXkjGC+RHGd0q8eUvER/8pm0Rzu X-Received: by 2002:a17:906:ad93:b0:88e:e498:109b with SMTP id la19-20020a170906ad9300b0088ee498109bmr1646548ejb.5.1676358576891; Mon, 13 Feb 2023 23:09:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676358576; cv=none; d=google.com; s=arc-20160816; b=KbnrIlRzHF1zOqWWTGx1qvoaObRNwGuXZxTgFBUIRRIp04bCrkyDafMMIRO4YWHP1s 7q+469hhGnMNXYGeWYyefQkWAcNHRBtobFCZRZTlgR1BRjYulFHSAoDkVYwbf2AJezXT OPxmFXEME3U1z/ANpoL2b1BiY9nsl+PjY1H7Z2Z1M//M0zWkDuqxdimap+yBjNowJNQq G9qGr1VT1VNIsrDj47lizFDw/OpUiN3aA4Ao1rdL2M0o25s5KMUPY1bEz0L7gaC+4O0F g6XviLza7ZBVDIMiyn2GL8v+r8uVxgG3pJcvXrCsxt2OnNepg28oLKef7QiOHFxw9Q8e i6Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8is6PSgPCwwH7m89tiltsLnJUDD22YJKL1meWifP5sM=; b=OmbvZMI6WwYg7TrmGYYGsUOlaRCZ8Ma/QWehrGh8oFuFpB/i2bqrVTXfysSlsqaflP ACiVzOBp+4keJV0W0JuIaGO9jfsh4vQqTOFToypEytlPu6pCEv1xUybZWR9/hnqBRY3S 7ThGHI1H0FS3RuQKSz/8RG8N5PenSUH22Cxgf4kkNYe9PdCGztxANKTWKsl00R0teJhq wMMO0SXlBHkYMWeww76GT3A9ZHZFff+ylHVaLw/QTl0eFeRVfLVXPk946UIY3kmMYx2z xfhBIA5Yw1qof+xECEqIoNRaahJWnudDs/xjc7EcVjy4Xmc74cAXga6qRJCA++LUdRiV Hbxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WIt7PESU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fp20-20020a1709069e1400b0088cb4c54005si16801149ejc.847.2023.02.13.23.09.11; Mon, 13 Feb 2023 23:09:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WIt7PESU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbjBNHHr (ORCPT + 99 others); Tue, 14 Feb 2023 02:07:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231785AbjBNHH0 (ORCPT ); Tue, 14 Feb 2023 02:07:26 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93F171F5F0; Mon, 13 Feb 2023 23:07:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1B835B81C05; Tue, 14 Feb 2023 07:06:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EC7AC433D2; Tue, 14 Feb 2023 07:06:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676358417; bh=1IRtpjryrFlaH3zPaQpRgLkIHqmynE5Y+t83e8Katow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WIt7PESUlL7eAgHG5yZuO/+Pzi2Iam84D6QDgX/lNFfE8E0LXUA7q2LZkTiM5E8Fr ltBF7m+A7cmNRWpEhtz56mVsB+LFjKR/8ja/VIadHjfLNx6yoIichWpu3qYfGaq9zV JUaO6KsixyAIrqpbjns4PoYgTh+jmEq6E6/qod0ooIa5PLN2YlJkG0c45baK9kSFk7 rEpSQ/SUSV1Cm1007AMLqK1a8R4bFLtedrlHoNLHVcT+P7vYH3dJ2lb1AoYpaKKEfb G5zQb6o7kDZcoEXZ/kyJnO9GlC/GcWjY5p12geGmAv8g+mjBO16dd/Nnx7oWVJM63e qIsMMhe6b0uBA== From: Josh Poimboeuf To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org Subject: [PATCH v2 05/24] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return Date: Mon, 13 Feb 2023 23:05:39 -0800 Message-Id: <1e9ecc3d248e82973e80bc336fc9f97e3ba2708d.1676358308.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789371142145902?= X-GMAIL-MSGID: =?utf-8?q?1757789371142145902?= arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Acked-by: Guo Ren Signed-off-by: Josh Poimboeuf --- arch/csky/kernel/smp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/csky/kernel/smp.c b/arch/csky/kernel/smp.c index b45d1073307f..0ec20efaf5fd 100644 --- a/arch/csky/kernel/smp.c +++ b/arch/csky/kernel/smp.c @@ -317,5 +317,7 @@ void arch_cpu_idle_dead(void) "jmpi csky_start_secondary" : : "r" (secondary_stack)); + + BUG(); } #endif