Message ID | 1b46712e93a2f4153909514a36016959dcc4021c.1707217097.git.bristot@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1465682dyb; Tue, 6 Feb 2024 03:13:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHlTenFUIk8yp5pC9qAk65NweX4pTwQD0onOnUlEz2cDBL41yLzFjxi1XGnVXcm7N8MAVzA X-Received: by 2002:a05:6a00:b33:b0:6e0:3329:1044 with SMTP id f51-20020a056a000b3300b006e033291044mr1791568pfu.29.1707218034936; Tue, 06 Feb 2024 03:13:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707218034; cv=pass; d=google.com; s=arc-20160816; b=lfxH2pPU5CJxK+GhU393h7rm3G2wzZ2GFEV1qSnL8UiBo1Eed7LYm+MSZg2OcElDo4 KKOvSAjYa4Yoqxaly5OELgrKFpTIHWn3UIqpyUOVKeK86Tw2IcsJ99n33/GbIUhacxVw Hf97bwiAgiIOymjUaSzWCqiiRyWSBx9IP1+MVEYvq0Ym8MdXhqIxaQNFVG6r7BlN2MZ6 HBOouadRvUkwovxvBovmRTuEuW2i612KEPg5SNkhdPJKVbOy+hP3RUIfYqN+Zr00I+59 KO7WjOBspzb3Md/hyd885GExXycSajHZ3hQ7I0nDhj7bkqtwpGTe88QE9ZANro9NjXHt Lanw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=a3sWO3ucWspFzjxbk0W6e1miXmwGUIIvGytm8MaRiE8=; fh=NsOVKdqP4s9RWwyfUIeevPYJ4w0YSA6K50tjufmEsTY=; b=rzvyghFBnQdFMdnVilPfUHknCWVC1UZ5rBp8SIr5O8VAsrsba0KWYc/+JO8r/UsMdQ udlwEmpgT3Dby7Q1qHbkDOgrDF7gXZhLz5AYMZ8nUF9Wnr9XPSA/J6+pmfEzjSEZTvtw rXnVuHSeZ21psNJAck+3meTsCm5oQDLw6TKMCOlr0efRLOa8Ze6SURmvBtAHYtatcJXa WNzY8uR2yfscpCuB0hNyxOFMydVw1g/ME0haeqd4JBr1PbwAPjU/aM9aLNUFAroBBlN1 rr1dPd5AkUxj1Zisl7sMH4/Dbq5IJOT+/R5izIf0SMzWyHQAuzrFs+AEnHqL6p/aiBni nMiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWvy0TH6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWBNTJwb6u5lZ7MQE0MWRg4+wctsK7gAjiS/Nq4az6/4F4lWBs86HifaYQbwvf6qi0YW1PQbKvX8sHko2uztnbMDZQYlg== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id gu8-20020a056a004e4800b006dde04e1839si1475927pfb.63.2024.02.06.03.13.54 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 03:13:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MWvy0TH6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54739-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7DB6E28AE7C for <ouuuleilei@gmail.com>; Tue, 6 Feb 2024 11:07:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B53E5130AD2; Tue, 6 Feb 2024 11:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MWvy0TH6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED22112FF76; Tue, 6 Feb 2024 11:05:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707217552; cv=none; b=EPYKXp91RrvGyMwZY0DjL4rsaTh7X+FpZVveQz51rXe+93DWREGEmYTVsMJ1MmKqbd6c0kWOc9EXV02jCJzGlhEaB00YjgwCcLEM6RRRAsYM9KBR7R6opvn4C1aVN8zz4tM+xj9T2MbZWphYsOEKLChqh6aWIxoaO9FeNwW10wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707217552; c=relaxed/simple; bh=HBpkihUOz+42qTZ8E70fvuC94UrnuMtLk3YD9XXg8zY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MO7a6/9IFYc0qHhdKGvORfTX0NK1WESqqTYPa9iiZnHGNHIboaO2hlQGjRhv6vWa76mu7S7wvi6oExTEIIdhZ/FwRHGxrK3d8RXRcUGvEyjE9/5wgcV85e3G4BoSr9muufk7G7v48bKNm6ehS73yhE5qSe5+XGW+zxId2UNqneo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MWvy0TH6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5F89C433C7; Tue, 6 Feb 2024 11:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707217551; bh=HBpkihUOz+42qTZ8E70fvuC94UrnuMtLk3YD9XXg8zY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MWvy0TH6y70WyLpUralBEy1uvKuZYhREElojJQhvCasstwIFVA6ZDTE3y2ZhvVnf3 Uvg/RBvyK7RRGTSI3dU1S5Mu9YS5yTRt7zy7P/kScj0CeSKOaduC4l+lQ2zqzzKBt7 EW5b10Br+lMZJ+yp9TDtxhlq64u+0ePeOWOxFfJq3k/LhKhvTaevgTzUKjdRb7nqCw fN7JdlbEDUcQm89rxay+oxj7kyKk9IB4z5MdrVmyWu91xVk33aEnPKTbQKCwi1gVKc mgyEPNSFKKjUJZg+AHkXW73VMoL9iuRGe+VOWkogskl4IOOLKKpLOp1RiEdwzccEZg ToL6obNvwEUXg== From: Daniel Bristot de Oliveira <bristot@kernel.org> To: Steven Rostedt <rostedt@goodmis.org> Cc: Daniel Bristot de Oliveira <bristot@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Nathan Chancellor <nathan@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>, Bill Wendling <morbo@google.com>, Justin Stitt <justinstitt@google.com>, Donald Zickus <dzickus@redhat.com>, stable@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 3/6] tools/rtla: Fix clang warning about mount_point var size Date: Tue, 6 Feb 2024 12:05:31 +0100 Message-ID: <1b46712e93a2f4153909514a36016959dcc4021c.1707217097.git.bristot@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <cover.1707217097.git.bristot@kernel.org> References: <cover.1707217097.git.bristot@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790147857977672890 X-GMAIL-MSGID: 1790147857977672890 |
Series |
tools: Fix rtla and rv problems (found) with clang
|
|
Commit Message
Daniel Bristot de Oliveira
Feb. 6, 2024, 11:05 a.m. UTC
clang is reporting this warning:
$ make HOSTCC=clang CC=clang LLVM_IAS=1
[...]
clang -O -g -DVERSION=\"6.8.0-rc3\" -flto=auto -fexceptions
-fstack-protector-strong -fasynchronous-unwind-tables
-fstack-clash-protection -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
$(pkg-config --cflags libtracefs) -c -o src/utils.o src/utils.c
src/utils.c:548:66: warning: 'fscanf' may overflow; destination buffer in argument 3 has size 1024, but the corresponding specifier may require size 1025 [-Wfortify-source]
548 | while (fscanf(fp, "%*s %" STR(MAX_PATH) "s %99s %*s %*d %*d\n", mount_point, type) == 2) {
| ^
Increase mount_point variable size to MAX_PATH+1 to avoid the overflow.
Cc: stable@vger.kernel.org
Fixes: a957cbc02531 ("rtla: Add -C cgroup support")
Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>
---
tools/tracing/rtla/src/utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/tracing/rtla/src/utils.c b/tools/tracing/rtla/src/utils.c index c769d7b3842c..b998b24edf1e 100644 --- a/tools/tracing/rtla/src/utils.c +++ b/tools/tracing/rtla/src/utils.c @@ -536,7 +536,7 @@ int set_cpu_dma_latency(int32_t latency) */ static const int find_mount(const char *fs, char *mp, int sizeof_mp) { - char mount_point[MAX_PATH]; + char mount_point[MAX_PATH+1]; char type[100]; int found = 0; FILE *fp;