From patchwork Fri Dec 22 22:50:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 182792 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1371193dyi; Fri, 22 Dec 2023 14:52:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IErA9J72alH7kEz6kjdBcnnJPLsqGp6ZyrR3tIlo9JDOZAFpJXH8/LiLjzxhVdlCDrIp/QB X-Received: by 2002:a17:906:947:b0:a23:5939:759e with SMTP id j7-20020a170906094700b00a235939759emr2168285ejd.26.1703285537711; Fri, 22 Dec 2023 14:52:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703285537; cv=none; d=google.com; s=arc-20160816; b=bHWMZGtV2IxMMd/ujdb+g3O2hUU01ZvBLzYZEJW2TBxXiaKNMPoAnLRsyoqB8JvGJN zwaCcLcrsCE0Zo60HQZ/G+d1HQt1kEeCKaG6LXJvBumvisMi7rU0CGhbvF4vbzrltOzg nvBSdfCT6zBHE8VYdHjtIfQy2dIFtButnALgDoaGLPMHIkMrDlAzVQbgqooybz2/jZx9 spyHtPVtmJhZVEoCTEa2TWGAfj/sjiZR5thP54cWtUxIr4BpLKEtoaK+7/cGK61lMS7J FAJzRoP+n38Ic/aAkG2HmozPx01dx8iK8EomA54TBzh9iS4H/78JxOr0LwfcFy/EnQPO KmXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=xaNDJCK/96IM1ugzA9hVlWmVNepZn31ENu7oqwX8UrY=; fh=pRhPfQLlVYfHlKr8jnvugZHZivgJvP42cwXk4G+Q8Nc=; b=gZFGGJ4zJrA7Toz6XMheBk/gSuQ698MdGNetmSZKX4tAy34Y/SCwC07VI6R34ZXRum FGtY14a98UTLaO8C7qTqUJJn0q0iY616cwGrYfJJjZwT99CGxjbfXcdQwkmasRq9cqhu ejHG72NZaLEwgm8j6/ZvKMb5HY5X6nYqjFfUCSRiX4V12S80kNtxyb3YmEH9GuA4PDXa /tUl2qxnFQ3J5p7bMUKsQH/pfUN11K02HTXZfEn0tS+DwUGrXygGeh4hpuIopt2XW+RY kyXaX8LpXOTnD8n0A+JKbCauKnUNui7hie103p7RTN5o3eW4j4YDThpyNBAHfHpFtOWQ DAgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10094-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10094-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l10-20020a1709065a8a00b00a26ae4379dbsi1555221ejq.207.2023.12.22.14.52.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 14:52:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-10094-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-10094-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-10094-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 57E941F23346 for ; Fri, 22 Dec 2023 22:52:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39BE63219D; Fri, 22 Dec 2023 22:51:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E17A2F841 for ; Fri, 22 Dec 2023 22:51:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGoMN-0005gq-0I; Fri, 22 Dec 2023 23:51:15 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGoML-000qvX-D7; Fri, 22 Dec 2023 23:51:14 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rGoMM-000Ffi-1M; Fri, 22 Dec 2023 23:51:14 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/13] irqchip/renesas-rza1: Convert to platform remove callback returning void Date: Fri, 22 Dec 2023 23:50:42 +0100 Message-ID: <1a80e31525d0b02063d2ff1baaaa5e87418f54b6.1703284359.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1796; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Bsz1h5QGxzBut3kdIXUNVPDmYjq+hBPugF7vd2mkQfE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlhhLDGfDRrLiK/KeH7o6vmgeojd4haTpeIWkVf dHLHVF6VfmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYYSwwAKCRCPgPtYfRL+ Ti/6B/0Uc7C0uWLP+JiDX8poWb9fqLqVJkboTbGDuw8QKClnZ8GXnZ1kWfqxq+sEAxAzJ5kqVaw 1Z6yi6Fg8XYidEuyCh9wwlEqGPU/sojxhURWyGaLh2ZLUnW4yZzqZ5XbsPgGNUecuNJx0Ge1b1W mZu4V5EHMq0GFrq56K40kZbmluI1LIBr48WiXF5xYuRyLSzgn9EfNy7h4Qk1xEWj7bausZD73+P NqiU2OkIiT1Zltu0xSb/5zxZafiCctFRj4Xvygbl1LZPexPts3IfCyJ8NqU/N09G2u0GDAnB9HC rWPzyNQy9GGObqdVm6PVyA21KDXDAzvE6nuAmNXtX1faAqgP X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786024335721079534 X-GMAIL-MSGID: 1786024335721079534 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/irqchip/irq-renesas-rza1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rza1.c b/drivers/irqchip/irq-renesas-rza1.c index e4c99c2e0373..f293ad13809f 100644 --- a/drivers/irqchip/irq-renesas-rza1.c +++ b/drivers/irqchip/irq-renesas-rza1.c @@ -244,12 +244,11 @@ static int rza1_irqc_probe(struct platform_device *pdev) return ret; } -static int rza1_irqc_remove(struct platform_device *pdev) +static void rza1_irqc_remove(struct platform_device *pdev) { struct rza1_irqc_priv *priv = platform_get_drvdata(pdev); irq_domain_remove(priv->irq_domain); - return 0; } static const struct of_device_id rza1_irqc_dt_ids[] = { @@ -260,7 +259,7 @@ MODULE_DEVICE_TABLE(of, rza1_irqc_dt_ids); static struct platform_driver rza1_irqc_device_driver = { .probe = rza1_irqc_probe, - .remove = rza1_irqc_remove, + .remove_new = rza1_irqc_remove, .driver = { .name = "renesas_rza1_irqc", .of_match_table = rza1_irqc_dt_ids,