From patchwork Tue Feb 14 07:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Poimboeuf X-Patchwork-Id: 56709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2811049wrn; Mon, 13 Feb 2023 23:09:42 -0800 (PST) X-Google-Smtp-Source: AK7set+j1ROugxjT5lmAjD1QY4H0sFelqZeyypnZJP4FZRYcsKXUwkwjevpEiduzrinUVnZNJIr5 X-Received: by 2002:a17:906:4dcf:b0:8b1:3135:a63b with SMTP id f15-20020a1709064dcf00b008b13135a63bmr970836ejw.9.1676358582263; Mon, 13 Feb 2023 23:09:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676358582; cv=none; d=google.com; s=arc-20160816; b=EHuZ0ylDH2f1MKoK3mI2pn7lfw8cAY/IPzjjJr3+yM7+x33U7/epYSyjz6+fWM1daC REYBFx6hV7G5fNig/koiw2Qu+tW+ADilge0bACrKtJPnjhMAzetIMYFd4G35qdqIIV0q BVOFBTc7bBn9mX1Wt4PVRgwLHQPOuppSPiwPD+0iFZYVlJYzpGp0RRbD3lVbco6F8jBE Gga38HOr84uhtOf5sh9uXa+oxE+KUsP/WC/qLusj2P7OMVY8qFDdV6jn82LVuyfeJs4d Bt1hEdjDbeVFR/wnvy3hpwQOI+FgUqfxCXVlVejr3Y5C9v/0j7iPhdzZVj7n04G0hDst sgiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=nVPgPuccGH1HhHA1lKh94l2fOA7KNB2An3ucO/PyLHY=; b=Fcu6/RkP0QOAntHHe3MpWuaXTrJgH6Pxx4tJpIjeI8zXnDAJiCa4MPi8yJ1zsJBqec yTAk+v6Z+L3rer+IO2Aiq+H1d8aU7x7Lv69EEYiUInsqlizm+TbdRzzLb65/4CdyBXEN 1AuX05Lu5pd5nvWB84yoS/lvuQrDTIQh4BF4/fAhS6/vr4JdCdzwdW4WYlXRcuBcVeRh xBKjDmDTUgOGxxc4PP/hA7FlWdOWMd5D+EjbjUXjTElLEUIJA5ggOF+oHfro2hV/q3BF 1RONDt6tODwQ5O8zbhy+XNiCmNc/bU56SRMOd9VhvucxJEeGC58xvUIYlOQsNidgHNuU hA2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o1g46Mnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y20-20020a170906519400b008885f4666d2si18969155ejk.963.2023.02.13.23.09.16; Mon, 13 Feb 2023 23:09:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=o1g46Mnm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231856AbjBNHHc (ORCPT + 99 others); Tue, 14 Feb 2023 02:07:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231802AbjBNHHW (ORCPT ); Tue, 14 Feb 2023 02:07:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78D6E1E2A3; Mon, 13 Feb 2023 23:06:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE36C61465; Tue, 14 Feb 2023 07:06:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7744CC433AE; Tue, 14 Feb 2023 07:06:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676358412; bh=Ya58HiCcymNeXiDsDrSrB3MVa42ANSTnVDrYM/I8DGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o1g46MnmwcBx8T5+mpqxpWg9RNiPGwxWh7u50+UbvVV/HCNE/CzztVflEM53qxglv YYK/YrY0Q9V6xIHds9bSBH9HN0lqUKa6Z1xe3cfCjxpSNsspagp2pNbL0WMNKEQ0Rx pzr+HaAh9N3K2/cV0XtAVxzNNCB75oEBpHNITqIRR27J3mfkFgz/r562+bVXahSIST IY0Pnmrhw/r9K8+6kstkVaj4pLQJnS5iSYM8p9up4WRV2EcZ3VkSKGVUgn+3GYoIew SCyrNFtXGmtYxVMosYI0z60anWodjY2gKyCCb0H5AEcAnHnT5mlvQpZIVvTrKYjllD UOkJrRuEY33Fg== From: Josh Poimboeuf To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, linux-alpha@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, jiaxun.yang@flygoat.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, ysato@users.sourceforge.jp, dalias@libc.org, linux-sh@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, linux-xtensa@linux-xtensa.org, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, paulmck@kernel.org Subject: [PATCH v2 02/24] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return Date: Mon, 13 Feb 2023 23:05:36 -0800 Message-Id: <19ffef09a175fecb783abcd44d6bcfeade2857eb.1676358308.git.jpoimboe@kernel.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757789376401315654?= X-GMAIL-MSGID: =?utf-8?q?1757789376401315654?= arch_cpu_idle_dead() doesn't return. Make that more explicit with a BUG(). BUG() is preferable to unreachable() because BUG() is a more explicit failure mode and avoids undefined behavior like falling off the edge of the function into whatever code happens to be next. Signed-off-by: Josh Poimboeuf --- arch/alpha/kernel/process.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/alpha/kernel/process.c b/arch/alpha/kernel/process.c index d1f2e8b6b107..d0ff06eda8fa 100644 --- a/arch/alpha/kernel/process.c +++ b/arch/alpha/kernel/process.c @@ -63,6 +63,7 @@ void arch_cpu_idle(void) void arch_cpu_idle_dead(void) { wtint(INT_MAX); + BUG(); } #endif /* ALPHA_WTINT */