diff mbox series

exfat: redefine DIR_DELETED as the bad cluster number

Message ID 1891546521.01672360201726.JavaMail.epsvc@epcpadp3
State New
Headers
Series exfat: redefine DIR_DELETED as the bad cluster number |

Commit Message

Sungjong Seo Dec. 29, 2022, 11:52 a.m. UTC 
  When a file or a directory is deleted, the hint for the cluster of
its parent directory in its in-memory inode is set as DIR_DELETED.
Therefore, DIR_DELETED must be one of invalid cluster numbers. According
to the exFAT specification, a volume can have at most 2^32-11 clusters.
However, DIR_DELETED is wrongly defined as 0xFFFF0321, which could be
a valid cluster number. To fix it, let's redefine DIR_DELETED as
0xFFFFFFF7, the bad cluster number.

Fixes: 1acf1a564b60 ("exfat: add in-memory and on-disk structures and headers")

Reported-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
---
 fs/exfat/exfat_fs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Namjae Jeon Jan. 8, 2023, 1:06 a.m. UTC | #1 
2022-12-29 20:52 GMT+09:00, Sungjong Seo <sj1557.seo@samsung.com>:
> When a file or a directory is deleted, the hint for the cluster of
> its parent directory in its in-memory inode is set as DIR_DELETED.
> Therefore, DIR_DELETED must be one of invalid cluster numbers. According
> to the exFAT specification, a volume can have at most 2^32-11 clusters.
> However, DIR_DELETED is wrongly defined as 0xFFFF0321, which could be
> a valid cluster number. To fix it, let's redefine DIR_DELETED as
> 0xFFFFFFF7, the bad cluster number.
>
> Fixes: 1acf1a564b60 ("exfat: add in-memory and on-disk structures and
> headers")
>
> Reported-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
Applied, Thanks!
diff mbox series

Patch

diff --git a/fs/exfat/exfat_fs.h b/fs/exfat/exfat_fs.h
index bc6d21d7c5ad..25a5df0fdfe0 100644
--- a/fs/exfat/exfat_fs.h
+++ b/fs/exfat/exfat_fs.h
@@ -50,7 +50,7 @@  enum {
 #define ES_IDX_LAST_FILENAME(name_len)	\
 	(ES_IDX_FIRST_FILENAME + EXFAT_FILENAME_ENTRY_NUM(name_len) - 1)
 
-#define DIR_DELETED		0xFFFF0321
+#define DIR_DELETED		0xFFFFFFF7
 
 /* type values */
 #define TYPE_UNUSED		0x0000