From patchwork Tue May 23 15:13:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 98068 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2240736vqo; Tue, 23 May 2023 08:49:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4TYFAn2xNsuVIh5i8k3quLLlZvS5bNEpX1IL5zS8FsLQOL1CKeUXhM/XPdtp1OdjcSWmMJ X-Received: by 2002:a17:902:c94e:b0:1ae:8595:153 with SMTP id i14-20020a170902c94e00b001ae85950153mr16095912pla.20.1684856950570; Tue, 23 May 2023 08:49:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684856950; cv=none; d=google.com; s=arc-20160816; b=sFBVYBmzkOlYuY9a3twdPdfO+AKR2iukxSe8oLWlY9kFp/1EAKyP2e36jI5vm0tEBN zfK61fbTSSJB78pL13ZTLhXYV9LQW3kdVPbUrqoZXVpLqBw3hLnsVnw9JU8DG9GEHmzC O3LWT1yJzJt4tvRtaFk4d9e1YL4OV8wTGNtvpfckSqLDRm1d+Qki00pXtAgOWQu5aMY4 HpNz2cDdXWGoe7W62ukeHMDS/aVoEuSAhB0N8Laty+Q8d7TZCSmyVKjh035LrJ3vXeKT DS6l/zZ/k00+nhcHYoV4GRpzuSRBbK1fjdiCIlgb24q5lXFmG/3PkHYTfkDyAMbkYwId R+Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VsRHVPc79SpCoDU52Bk07RMmUs92G1TJzm3tYWSGAak=; b=YAWo+W5rKy7VlH3ztQ+gPK7lkgE+qnzpAOVKKsQFlAOBkMu+/Hp/zXq7iETV8ukO5M JVC3V7LJSPDbuwoS3GgA9FtoNbFIOGNZLRRiNSWIMLE+VAUA5VhxXewpiybs4xi6yOfj syqQhll0P11JqtpJJITG30wdHP1yg88TGlk38jFTIeliBJCfXStFKho2lSjszxA8aReL 4GIgXi/z4S+fHDw0TWAcJ/M9HQhxuzsDiH+7341+8Bex7+5QHLxHSfi9g9kATHi7IZP5 rqdNMRbKbIPGDM20eQgQcfKZxYavfcpJzwoCQpnJn7ksPPjcmakRXiD1XZ8ch08ys7e/ qzlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j6-20020a170903024600b001a94b91f402si7045531plh.218.2023.05.23.08.48.58; Tue, 23 May 2023 08:49:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237511AbjEWPV3 (ORCPT + 99 others); Tue, 23 May 2023 11:21:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237489AbjEWPV2 (ORCPT ); Tue, 23 May 2023 11:21:28 -0400 X-Greylist: delayed 343 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 23 May 2023 08:21:24 PDT Received: from cantor.telenet-ops.be (cantor.telenet-ops.be [195.130.132.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C20121 for ; Tue, 23 May 2023 08:21:24 -0700 (PDT) Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by cantor.telenet-ops.be (Postfix) with ESMTPS id 4QQdCk00m4z4x0bW for ; Tue, 23 May 2023 17:14:58 +0200 (CEST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:b0ac:7afd:272:4cff]) by andre.telenet-ops.be with bizsmtp id 0FDx2A0020Jkz7G01FDxrP; Tue, 23 May 2023 17:13:57 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from ) id 1q1Thm-002swf-JF; Tue, 23 May 2023 17:13:57 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from ) id 1q1Ti1-00CkQr-0X; Tue, 23 May 2023 17:13:57 +0200 From: Geert Uytterhoeven To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] [resend] Input: gpio-keys - Use input_report_key() Date: Tue, 23 May 2023 17:13:55 +0200 Message-Id: <185f3320e39000159d4bd843fd3119b94c30d607.1684854795.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766700561897621527?= X-GMAIL-MSGID: =?utf-8?q?1766700561897621527?= Use the input_report_key() helper instead of open-coding the same operation. Signed-off-by: Geert Uytterhoeven --- drivers/input/keyboard/gpio_keys.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 5e18ef01b0340f1b..7e8342ef7a79b17f 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c @@ -456,7 +456,7 @@ static enum hrtimer_restart gpio_keys_irq_timer(struct hrtimer *t) struct input_dev *input = bdata->input; if (bdata->key_pressed) { - input_event(input, EV_KEY, *bdata->code, 0); + input_report_key(input, *bdata->code, 0); input_sync(input); bdata->key_pressed = false; } @@ -478,11 +478,11 @@ static irqreturn_t gpio_keys_irq_isr(int irq, void *dev_id) if (bdata->button->wakeup) pm_wakeup_event(bdata->input->dev.parent, 0); - input_event(input, EV_KEY, *bdata->code, 1); + input_report_key(input, *bdata->code, 1); input_sync(input); if (!bdata->release_delay) { - input_event(input, EV_KEY, *bdata->code, 0); + input_report_key(input, *bdata->code, 0); input_sync(input); goto out; }