| Message ID | 17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp1770489wrt;
Tue, 21 Mar 2023 06:18:12 -0700 (PDT)
X-Google-Smtp-Source:
AK7set/mZFpOYr5Mbuu3g7a+0S8DGqW4ZlJfeEPR8d/PzPseZdyZy8ZtLEVVUGvDvDFtcbm9ITi0
X-Received: by 2002:a17:902:d4c3:b0:1a1:c6a7:44f5 with SMTP id
o3-20020a170902d4c300b001a1c6a744f5mr2731210plg.52.1679404692458;
Tue, 21 Mar 2023 06:18:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679404692; cv=none;
d=google.com; s=arc-20160816;
b=l70/3iPRndApL3S6pK5Pz37K3FbHqU9VetWNUQiI37d2KJh8AYETqTCD3u75TnBUdd
3/j/Iat5IzAJWdsgMA6UmKYFYgts1TkHtvzZXxeaZMgNI9qGYLRItaRgy6sBGApXjhDF
/nPmL4XenZiCeQzo4YHDJ09H2rhtV5Rf6A/xgVnC5hxlbpx+dnGIoxQMgSDqSvbyctPf
Tbhr6Vul8E522zM46aWwkIir0Zfd2MvWzDyCSovWoIanRwtqfgl66AcyZA3+erpVds+E
3+wcNY5X60zRBlam9bg+r1OjOO7+S3Bbrc8d4of7urKql5Oe1/GRz+2Esc+uM6SPRJXp
kypQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:subject:from:cc:to
:content-language:user-agent:mime-version:date:message-id
:dkim-signature:dkim-signature;
bh=O1v/e/xhzyt2yooni4/QVWba2SIHElR4YZzaBgdzUus=;
b=dZo+tb3wmEON99UKPjpXyQ5ewDj6L9DXnfcuGIeH+tRi0YXWyz8SNWpFIiFR1uGIzZ
JAzKsH4QQcD5Bce9faZQhLC/Kxi8k+A16c1/76Zpv/xzvzBgx8jS8ceyfZ75N3Y5wXyP
ddYgn+J0NTxweYZ/cecy0rfomwIyE8HkaMSJhMeNO06peVMIOqW+8KbHrSSKAp+XxIVK
B8kgdWihWv5LpxGsnCOQRPqGCvVXMPJXoGecy6m1Uq/IZTEDvxG1lEIZFxcav2jJ1RS+
JdWaZ7LfdQIuld5BnXXn9j3LBR7QoiGqP7hCENDNwSoWb0lYROBcBs6qDZkRH2q4q2bt
cZvQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=RMk3tUC3;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=UHqB5tdn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alu.unizg.hr
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
jd20-20020a170903261400b0019f24b937ffsi12958841plb.521.2023.03.21.06.17.59;
Tue, 21 Mar 2023 06:18:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=RMk3tUC3;
dkim=fail header.i=@alu.unizg.hr header.s=mail header.b=UHqB5tdn;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alu.unizg.hr
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230247AbjCUNEZ (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 99 others); Tue, 21 Mar 2023 09:04:25 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41966 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229675AbjCUNEW (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 21 Mar 2023 09:04:22 -0400
Received: from domac.alu.hr (domac.alu.unizg.hr [IPv6:2001:b68:2:2800::3])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EBFF1448B;
Tue, 21 Mar 2023 06:04:21 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1])
by domac.alu.hr (Postfix) with ESMTP id 9AD47604FA;
Tue, 21 Mar 2023 14:04:18 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail;
t=1679403858; bh=H9dW8BLdpWjGQBRVTnsMabnfla3sgknX41PsonFtjmY=;
h=Date:To:Cc:From:Subject:From;
b=RMk3tUC3k3IoIq3gpXDOrMo0E3xMyrR6SHEuXoW7PJOCxXYoZ+FrtbacNuXna+YHz
kbOBSXo+Lty3p+k30gJujtEHV0fLFa75AljBrq2dvHvVJykLTUqtDfHJG0aaF9XvY2
vdwYd1HQukLE9FFlym8ZgI0hAQUYc2QDMROWbTi8MKPlp4U0abA8XOHm6VXnQfJ2gr
bPISyHaUYU2V8+oPqXnuGonXfUry2XGnUkeshr/yxASJAMpbxovSBHpNH3tFywYo1l
SiEyWSLMBohIecK0M0hGLVTuUfXNsilHkO9tuRXQs8uWUBR4UTqDZ8eaLd3jIMWYg2
kZapuRaNURN8Q==
X-Virus-Scanned: Debian amavisd-new at domac.alu.hr
Received: from domac.alu.hr ([127.0.0.1])
by localhost (domac.alu.hr [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id dssJpjvpWZxK; Tue, 21 Mar 2023 14:04:16 +0100 (CET)
Received: from [10.0.1.103] (grf-nat.grf.hr [161.53.83.23])
by domac.alu.hr (Postfix) with ESMTPSA id 573FF604F0;
Tue, 21 Mar 2023 14:04:16 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=alu.unizg.hr; s=mail;
t=1679403856; bh=H9dW8BLdpWjGQBRVTnsMabnfla3sgknX41PsonFtjmY=;
h=Date:To:Cc:From:Subject:From;
b=UHqB5tdnDzvLOSWFpwduXZBPQV6RHKjSAEeVUbiXl9TLJA5XDlI1HpftsHTORHlxZ
Gff6QJ3UVLCRqE+/ISt5WCeL+eXk775rUb5t+ckhyOzf9BzdvrPl6vUICgmGMijig7
hWNST8bfHfE75UlCZgKBA8dDe0hrgo+qKLhfcAqkIQAcrly9LrbI5/EIescv2dtEo0
MRv3qdImzxsONVuHqDYKZ6WtqovcLlyPu4p2jgwxzlQbazAczSbi6pDdioQ1q0hWMC
3QRC6vxYI2BhXjcaTNIGqjjM50KcMT8PQhbQRso3S4zs00Y55+h6ro4OtT0ZxuD/qF
8J7J1xRI/4HRw==
Message-ID: <17ab5a21-5512-5388-f9fa-c462b2ebd351@alu.unizg.hr>
Date: Tue, 21 Mar 2023 14:04:16 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
Thunderbird/102.9.0
Content-Language: en-US
To: linux-kbuild@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kernel@vger.kernel.org
From: Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: BUG: scripts/kconfig/merge_config.sh: typo in variable name
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1760983454506520052?=
X-GMAIL-MSGID: =?utf-8?q?1760983454506520052?=
|
| Series |
BUG: scripts/kconfig/merge_config.sh: typo in variable name
|
|
Commit Message
Mirsad Todorovac
March 21, 2023, 1:04 p.m. UTC
Hi all, There is a typo in variable name in scripts/kconfig/merge_config.sh, with the script returning: $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found Problem is probably best explained by this diff: --- Hope this helps. Best regards, Mirsad
Comments
On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote: > Hi all, > > There is a typo in variable name in scripts/kconfig/merge_config.sh, with the > script returning: > > $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config > ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found > > Problem is probably best explained by this diff: > > --- > diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh > index 32620de473ad..902eb429b9db 100755 > --- a/scripts/kconfig/merge_config.sh > +++ b/scripts/kconfig/merge_config.sh > @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do > NEW_VAL=$(grep -w $CFG $MERGE_FILE) > BUILTIN_FLAG=false > if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then > - ${WARNOVVERIDE} Previous value: $PREV_VAL > + ${WARNOVERRIDE} Previous value: $PREV_VAL > ${WARNOVERRIDE} New value: $NEW_VAL > ${WARNOVERRIDE} -y passed, will not demote y to m > ${WARNOVERRIDE} > > Hope this helps. P.S. Later I thought of searching the committer of the patch that introduced the change, so I Cc:ed Mark. Best regards, Mirsad
On Wed, Mar 22, 2023 at 5:14 AM Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr> wrote: > > On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote: > > Hi all, > > > > There is a typo in variable name in scripts/kconfig/merge_config.sh, with the > > script returning: > > > > $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config > > ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found > > > > Problem is probably best explained by this diff: > > > > --- > > diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh > > index 32620de473ad..902eb429b9db 100755 > > --- a/scripts/kconfig/merge_config.sh > > +++ b/scripts/kconfig/merge_config.sh > > @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do > > NEW_VAL=$(grep -w $CFG $MERGE_FILE) > > BUILTIN_FLAG=false > > if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then > > - ${WARNOVVERIDE} Previous value: $PREV_VAL > > + ${WARNOVERRIDE} Previous value: $PREV_VAL > > ${WARNOVERRIDE} New value: $NEW_VAL > > ${WARNOVERRIDE} -y passed, will not demote y to m > > ${WARNOVERRIDE} > > > > Hope this helps. > > P.S. > > Later I thought of searching the committer of the patch that introduced the change, > so I Cc:ed Mark. > > Best regards, > Mirsad Good catch. Will you please send a patch with your signed-off? > -- > Mirsad Todorovac > Sistem inženjer > Grafički fakultet | Akademija likovnih umjetnosti > Sveučilište u Zagrebu > > System engineer > Faculty of Graphic Arts | Academy of Fine Arts > University of Zagreb, Republic of Croatia > tel. +385 (0)1 3711 451 > mob. +385 91 57 88 355
On 3/22/23 04:40, Masahiro Yamada wrote: > On Wed, Mar 22, 2023 at 5:14 AM Mirsad Goran Todorovac > <mirsad.todorovac@alu.unizg.hr> wrote: >> >> On 3/21/2023 2:04 PM, Mirsad Goran Todorovac wrote: >>> Hi all, >>> >>> There is a typo in variable name in scripts/kconfig/merge_config.sh, with the >>> script returning: >>> >>> $ ./scripts/kconfig/merge_config.sh -y -m ../.config tools/testing/selftests/net/config >>> ./scripts/kconfig/merge_config.sh: 148: ./scripts/kconfig/merge_config.sh: Previous: not found >>> >>> Problem is probably best explained by this diff: >>> >>> --- >>> diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh >>> index 32620de473ad..902eb429b9db 100755 >>> --- a/scripts/kconfig/merge_config.sh >>> +++ b/scripts/kconfig/merge_config.sh >>> @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do >>> NEW_VAL=$(grep -w $CFG $MERGE_FILE) >>> BUILTIN_FLAG=false >>> if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then >>> - ${WARNOVVERIDE} Previous value: $PREV_VAL >>> + ${WARNOVERRIDE} Previous value: $PREV_VAL >>> ${WARNOVERRIDE} New value: $NEW_VAL >>> ${WARNOVERRIDE} -y passed, will not demote y to m >>> ${WARNOVERRIDE} >>> >>> Hope this helps. >> >> P.S. >> >> Later I thought of searching the committer of the patch that introduced the change, >> so I Cc:ed Mark. >> >> Best regards, >> Mirsad > > Good catch. Thanks. > Will you please send a patch with your signed-off? Submitted. I hope I did it right this time. Best regards, Mirsad
diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh index 32620de473ad..902eb429b9db 100755 --- a/scripts/kconfig/merge_config.sh +++ b/scripts/kconfig/merge_config.sh @@ -145,7 +145,7 @@ for ORIG_MERGE_FILE in $MERGE_LIST ; do NEW_VAL=$(grep -w $CFG $MERGE_FILE) BUILTIN_FLAG=false if [ "$BUILTIN" = "true" ] && [ "${NEW_VAL#CONFIG_*=}" = "m" ] && [ "${PREV_VAL#CONFIG_*=}" = "y" ]; then - ${WARNOVVERIDE} Previous value: $PREV_VAL + ${WARNOVERRIDE} Previous value: $PREV_VAL ${WARNOVERRIDE} New value: $NEW_VAL ${WARNOVERRIDE} -y passed, will not demote y to m ${WARNOVERRIDE}