From patchwork Tue Feb 27 17:21:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 207331 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2845469dyb; Tue, 27 Feb 2024 09:23:54 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWz7bBKQmUB7iUxHeQMgQ/sDyM0828em6MS/4TWDbBT/3RJXrS8Wp7+yrrr0NftF8oOd+83VmhuzA/MZhd4o1ex7l4AZA== X-Google-Smtp-Source: AGHT+IFjTGYxNWfySI2aXes0ol924jSMoYhoUouHxTcA9n01BZDiJxRZOP0qH0CuTwAQy1Z058Xa X-Received: by 2002:a05:622a:305:b0:42e:7ea3:46ce with SMTP id q5-20020a05622a030500b0042e7ea346cemr7692543qtw.43.1709054633989; Tue, 27 Feb 2024 09:23:53 -0800 (PST) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b20-20020a05622a021400b0042e753cfeeasi8110078qtx.164.2024.02.27.09.23.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:23:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83697-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linutronix.de header.s=2020 header.b=ugUttNfp; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-83697-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83697-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B71581C22CB6 for ; Tue, 27 Feb 2024 17:23:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C10014A0A2; Tue, 27 Feb 2024 17:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ugUttNfp"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="MYcDdY4P" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1096C4F88E; Tue, 27 Feb 2024 17:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054515; cv=none; b=OLqLMJmTJ/fn4XT14rf4I1h49qRdEv132A3bw0d341voDv8QMeHNtqTurATxjIt56QggsHNyLLjPz5ZFMBFJBqim2QvB+C4qXhiJ04+0JhiutQx9m4abq78nsJwsyrHH9N/2+1OrkMi1ZD3Pitc0TI/Ypc0ox4IuSqYxgpPtM8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054515; c=relaxed/simple; bh=auIPyEBnf9ErcAdx4eZFBluozZQSAGoztMKtzTNkaUo=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=UeVuWdCv3saEQhK6+YGYHjZlMHAxXi/KsDZYHkEvbVeMetzkORgzqRP3LH7tqQHqG1q83MQaaLPZl8EWKRJgCbjW4Bb9oPd5fxxkfCoepLM9+nnllScqNwTtDy3PvbM0g4A2/W4wlZ5Igp/IzBvdpHlnEZ2QbOj3/jEOYCBcGNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ugUttNfp; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=MYcDdY4P; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Tue, 27 Feb 2024 17:21:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1709054512; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYdll+dqDDCneWK2zxJs1G/do0WBLWyVZ49tIn5GQMI=; b=ugUttNfpJMUQSNE+WZZfLwIlRds+HXxykmfwvHaRMxfYU0yNzXAy7AGRBJQAlJMMXRQbb3 PxY01KvWHHNWA1Xbg8jVoTZkpwxSSukgh3clqs7WbctgFv0qWClWZx7QteSs8VE/apoUxU M+7IDc9m9cQT4Ft05Upm7/1Aq+im7U/r0RWDCK+V0zQJDCKLJDIUS1AmqiMlDhg4Gtb4Bd Fse+U5YlyiKqRuq3wQexNl/VkygaCyRl2Wzf6ouNU2dX2dPx9/viBwjsuzNvMsHEFCiWRG RCiPY5vfb+FTe6UXkALvVuuldaKcxWeDnBZmTe1567Qc+5Me4GUiCG4oFtFB0Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1709054512; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XYdll+dqDDCneWK2zxJs1G/do0WBLWyVZ49tIn5GQMI=; b=MYcDdY4PrjoAiibG1Wf/vl0RuuOCR6ECCYmgV52wJtp8Ut0ZfBzWYjH9LhQt3ZkwtaLqfG 4UomCPsjTVE4wmBg== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] irqchip/mvebu-pic: Convert to platform_driver::remove_new() callback Cc: u.kleine-koenig@pengutronix.de, Thomas Gleixner , Gregory CLEMENT , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: =?utf-8?q?=3Cdf977ad4c02ff913b01cdd6c348e7fae3e08e651=2E1703284?= =?utf-8?q?359=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= References: =?utf-8?q?=3Cdf977ad4c02ff913b01cdd6c348e7fae3e08e651=2E17032843?= =?utf-8?q?59=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170905451163.398.10638506921918938694.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792073671481948584 X-GMAIL-MSGID: 1792073671481948584 The following commit has been merged into the irq/core branch of tip: Commit-ID: b7b58085a5b57bbe83194e12c31977f345c87cce Gitweb: https://git.kernel.org/tip/b7b58085a5b57bbe83194e12c31977f345c87cce Author: Uwe Kleine-König AuthorDate: Fri, 22 Dec 2023 23:50:38 +01:00 Committer: Thomas Gleixner CommitterDate: Tue, 27 Feb 2024 18:12:10 +01:00 irqchip/mvebu-pic: Convert to platform_driver::remove_new() callback The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Thomas Gleixner Acked-by: Gregory CLEMENT Link: https://lore.kernel.org/r/df977ad4c02ff913b01cdd6c348e7fae3e08e651.1703284359.git.u.kleine-koenig@pengutronix.de --- drivers/irqchip/irq-mvebu-pic.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c index ef3d364..d17d9c0 100644 --- a/drivers/irqchip/irq-mvebu-pic.c +++ b/drivers/irqchip/irq-mvebu-pic.c @@ -167,14 +167,12 @@ static int mvebu_pic_probe(struct platform_device *pdev) return 0; } -static int mvebu_pic_remove(struct platform_device *pdev) +static void mvebu_pic_remove(struct platform_device *pdev) { struct mvebu_pic *pic = platform_get_drvdata(pdev); on_each_cpu(mvebu_pic_disable_percpu_irq, pic, 1); irq_domain_remove(pic->domain); - - return 0; } static const struct of_device_id mvebu_pic_of_match[] = { @@ -184,11 +182,11 @@ static const struct of_device_id mvebu_pic_of_match[] = { MODULE_DEVICE_TABLE(of, mvebu_pic_of_match); static struct platform_driver mvebu_pic_driver = { - .probe = mvebu_pic_probe, - .remove = mvebu_pic_remove, + .probe = mvebu_pic_probe, + .remove_new = mvebu_pic_remove, .driver = { - .name = "mvebu-pic", - .of_match_table = mvebu_pic_of_match, + .name = "mvebu-pic", + .of_match_table = mvebu_pic_of_match, }, }; module_platform_driver(mvebu_pic_driver);