From patchwork Tue Feb 27 17:21:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 207334 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2845723dyb; Tue, 27 Feb 2024 09:24:22 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCV7Q/CKhW1nRAubaAteJJUTW+LmsLwhhKuoF1qNetXA9k9aXq8LYUoFLFVTfhQVX+VEayzYbRduscMgOqONlbe3OjA3jA== X-Google-Smtp-Source: AGHT+IExkGtnKnp4q/GAgPkkRqdAOYZzwvBQAeJt5fOFLTrFlXZVtJXJisjI+eZNpSuir7ual8fk X-Received: by 2002:a17:902:db09:b0:1dc:ad9a:7602 with SMTP id m9-20020a170902db0900b001dcad9a7602mr6519772plx.34.1709054662758; Tue, 27 Feb 2024 09:24:22 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p13-20020a170902ebcd00b001db420e7552si1698911plg.65.2024.02.27.09.24.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:24:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83696-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linutronix.de header.s=2020 header.b="uoWXSU/H"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-83696-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83696-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id CC6AE2824B2 for ; Tue, 27 Feb 2024 17:23:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA0F2149E0E; Tue, 27 Feb 2024 17:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="uoWXSU/H"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="xsgN2KUO" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C3B4EB4E; Tue, 27 Feb 2024 17:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054514; cv=none; b=J8Aza+SHLM4wiPhVlNRk8PKO0rgDIxvegHsWaLHKjm3inaY6LIESWhyo8sjQLJVmLcslQOvEkFUhU4AuFsjY3zgOVEW+JBAnhdkg/K9BNsOwLYAnwEwIKiReDtZewm7aP1NKyzkPDtHlGcZruITxLv76/3AgOX1x0rqHrthpnts= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054514; c=relaxed/simple; bh=wXSRP+BHN+/pMFrsM7zD5sI1Tvll7OsuB4BxkszN2ac=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=mp17Uiad8ohWci9s5j2t4BvMW/y2RBns3vHW9TUAIZz1xFpFGXTAH82e549OA+f9naAdv0KSWJdZ20ScS2MqKjl/RR6ULcxWjtZqf4incGOxBP/vs2az5/TzyI0O7Q28eyKK/1awN11ayuBNmEPToXgkux64JfKm3owrCFYw0g0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=uoWXSU/H; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=xsgN2KUO; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Tue, 27 Feb 2024 17:21:50 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1709054511; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3UEpTiWN8p/eebA1mr6/y9VP7tc5URW8/HJyewEG8QE=; b=uoWXSU/H1ll/fOtv8dkVYbfS4wbW3NcBo5kc3P6GfFI2X8dvIWUEnYCKlS26mLiC03Wfmh s5kjw8AY3pJ49q8ThsuSFuW6mfWJOMw1MWWW1KaX71kNR6jHrsmEGNAkN7sebxYkO+yYBK nrjp5qQOy+B7IimYQxy5YQrcrUIEMHUI/cz0LPYTiraF03HqAyGYiG0JclCmeIBOm6wBh3 gqXwetL9u4PKlwhP1hoC91Q2eq2eAO220eIjYvV0uQLQDoPCMOXlusdXoztX2g7RQv+lT+ F7dM0PG5TN3MLPKqGmLRrzSIijJuFzQloKNsOlMevGewS5qnkd7Bb1p1l5EpDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1709054511; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3UEpTiWN8p/eebA1mr6/y9VP7tc5URW8/HJyewEG8QE=; b=xsgN2KUO7uINdeTy42cfvtoD1fjKDSWnnj0PQMS1Ut9MwtiazRClwT/XnB/GlPCcK+LTad WQ+boRo257NMXBAw== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] irqchip/pruss-intc: Convert to platform_driver::remove_new() callback Cc: u.kleine-koenig@pengutronix.de, Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: =?utf-8?q?=3C071057cfdc0bc52c574f74156b410c0337adb69c=2E1703284?= =?utf-8?q?359=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= References: =?utf-8?q?=3C071057cfdc0bc52c574f74156b410c0337adb69c=2E17032843?= =?utf-8?q?59=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170905451071.398.9047545733346141596.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792073702038905604 X-GMAIL-MSGID: 1792073702038905604 The following commit has been merged into the irq/core branch of tip: Commit-ID: abe9da4056bc6f13ab96c1511d23bd4635bb0bf0 Gitweb: https://git.kernel.org/tip/abe9da4056bc6f13ab96c1511d23bd4635bb0bf0 Author: Uwe Kleine-König AuthorDate: Fri, 22 Dec 2023 23:50:39 +01:00 Committer: Thomas Gleixner CommitterDate: Tue, 27 Feb 2024 18:12:10 +01:00 irqchip/pruss-intc: Convert to platform_driver::remove_new() callback The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/071057cfdc0bc52c574f74156b410c0337adb69c.1703284359.git.u.kleine-koenig@pengutronix.de --- drivers/irqchip/irq-pruss-intc.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/irq-pruss-intc.c b/drivers/irqchip/irq-pruss-intc.c index 0f64ecb..060eb00 100644 --- a/drivers/irqchip/irq-pruss-intc.c +++ b/drivers/irqchip/irq-pruss-intc.c @@ -599,7 +599,7 @@ fail_irq: return ret; } -static int pruss_intc_remove(struct platform_device *pdev) +static void pruss_intc_remove(struct platform_device *pdev) { struct pruss_intc *intc = platform_get_drvdata(pdev); u8 max_system_events = intc->soc_config->num_system_events; @@ -616,8 +616,6 @@ static int pruss_intc_remove(struct platform_device *pdev) irq_dispose_mapping(irq_find_mapping(intc->domain, hwirq)); irq_domain_remove(intc->domain); - - return 0; } static const struct pruss_intc_match_data pruss_intc_data = { @@ -645,12 +643,12 @@ MODULE_DEVICE_TABLE(of, pruss_intc_of_match); static struct platform_driver pruss_intc_driver = { .driver = { - .name = "pruss-intc", - .of_match_table = pruss_intc_of_match, - .suppress_bind_attrs = true, + .name = "pruss-intc", + .of_match_table = pruss_intc_of_match, + .suppress_bind_attrs = true, }, - .probe = pruss_intc_probe, - .remove = pruss_intc_remove, + .probe = pruss_intc_probe, + .remove_new = pruss_intc_remove, }; module_platform_driver(pruss_intc_driver);