From patchwork Mon Feb 26 22:24:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 206960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2366134dyb; Mon, 26 Feb 2024 14:26:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUkyVmXxMgt9P5SfYAxuSkOcOrz45ChU0wET8G/NipfTxvG0SvKe3IZadgiBUh/HW6Xq/HTQxirVzxLpu6ULYrKsvTipQ== X-Google-Smtp-Source: AGHT+IH9yl991sWTzfSboigWLMqe2bIYxjLYZBG5M0IeqGjbkhn5RKIagLHzoClR+ZhxGIf5L9Ko X-Received: by 2002:a17:90a:b306:b0:299:3f5d:b5e0 with SMTP id d6-20020a17090ab30600b002993f5db5e0mr5223933pjr.49.1708986418609; Mon, 26 Feb 2024 14:26:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708986418; cv=pass; d=google.com; s=arc-20160816; b=BOfQ+CKiC4ppNBsNbIYMuq+z+voYnsq4jLOf9NzU4zmBHD8DXK0BAoZkev6hoDxPat O863x6mUpHrM3vM+DdJQAr/SKsfL4jROm0YDBxJMcbLrufW9J+ijVCRupm24z8C7CvZk HOEeRGzQnVqHe4gANqK9nttPqKEbkgr4pbB0+vbjTiLC7eNWVxu1dbNPA3ZkIWldgL4k 8tKlZ3mdyJmPIKCWFIPz++JxR9yNQA9jwTSZfCG60fMsaVlQW6ymz2bX/XFdl61oeSvQ M9PGWZhsHq4EatYjY687rSjDcpRX4jHNvCmKvVPNJwDMqbYtbyu/Sm1s4hM9dbyQ2EN5 nXmQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:precedence:robot-unsubscribe:robot-id :message-id:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:references:in-reply-to:cc:subject:to:reply-to:sender :from:dkim-signature:dkim-signature:date; bh=7gmvywgK7hzuqrOlHez702NlidrZOsbLEYuY6O8im8k=; fh=9Ax9dUTktkw7GUAcxhp/hScrn1H6VeDItxi6qdujZxg=; b=imkVT0+nZ9WScBy11SVMP5TvHIMc1CyLVxfqdz9Vb2kblaoYs+NRX50c8gKOPhId0L e3BSjODOrKIHopvJ+XBcorZ5hIxsVFXadlMeVddV2FVM6llE4yTG8ojiKgVHzi5Rufph QKvkB3iGvzYDKq34rbDZMKJ6O7OEWwpEw8/0jbUX7eXf/hA6ahW6CU2d80TbkjPfCnL5 RMm3zjxOM2pp7mZB087Q4CyvNj3AdwUjYoPXyIUz3P3PhQJU64wyhHHoXLOgHth5JCxv RQi26OiiHzmiv+D+uyZYPyjS0C+GHhezt+hLoL57wMdBFqEmnxqS08ewF2+QsxMDnQxZ nPWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=1uvQ93FD; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-82396-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82396-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lr16-20020a17090b4b9000b0029ad97ca5fdsi869645pjb.80.2024.02.26.14.26.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 14:26:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82396-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=1uvQ93FD; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-82396-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82396-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EC361286B15 for ; Mon, 26 Feb 2024 22:26:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 79DB9135A68; Mon, 26 Feb 2024 22:24:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="1uvQ93FD"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="R6oms6eU" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17BEB134753; Mon, 26 Feb 2024 22:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708986280; cv=none; b=QL6QFkW9EJU4xLmeRnNAbsgDxmnZMjsP1XpO1I1ZQg2cVd83wmkp5QPBmnoOg68qp7GBWlKAv8DDHFpjUsrb9j1sWcATZq/85c/Sl2y15Np0iepCvfu7GNgdCjYez9Xt77KIaKJV4I6p5JQ747zHxJjgC89IvXPyR6ZKJmK65HY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708986280; c=relaxed/simple; bh=Gb9/Sg1e4bTsSFnIai8laRQcHRpbPHLpDfe/CXQ1we4=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=TNp7o8XrkuTQg5yThWQw1XKCOyZiqR24r6uxIwomwyPv9z+Mb74QQ0NFR2W+M+uhZpLw/zrjno1tAKoOkTrATYgsGIPL+MzelMFcpqunVVbXRtJBItsGLHqeBgHfV5e58dlh2AVh4+UbJjS2B0eMeODSznF3+bjHeX25Fjm1dO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=1uvQ93FD; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=R6oms6eU; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Mon, 26 Feb 2024 22:24:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1708986277; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7gmvywgK7hzuqrOlHez702NlidrZOsbLEYuY6O8im8k=; b=1uvQ93FDva03tSM/5Oror5hfRWuxnGZaMSL3Qpze/1LxWJURHh8bWL8ojMc0/84QSGyuOm rHZJfeUADbAy2hR0orlgLvgugSzC52ecAe5I4fXwtCTFKuxOLLQY8kdshWcCDbVOV8SU59 1QuxLKYMDGksgDJOaxAr6h+EqSgbKlgQ7Bfrohr2HdfnMtRbYBKlgX4gQj5xFxR1j4f37R dgm5bMcTy3+FbIHpCkcf2FEbH60IDYeABUWqYyp8n2ajCvmtKIZTo/BNuV2BB7+mxQm1Z7 nXtS+F3JXDw693TKDbX0P/dRwxenPGtF9CmYQi5TKYDuYONKUPVZK1tCv0nKJQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1708986277; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7gmvywgK7hzuqrOlHez702NlidrZOsbLEYuY6O8im8k=; b=R6oms6eUqBL26ZXBR185mddfDihsVne5aYn7kt6x9aY1608QunymgQUshVOho76oQi9a65 Bx8Bktauz/SbWDAQ== From: "tip-bot2 for Frederic Weisbecker" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] tick/sched: Don't clear ts::next_tick again in can_stop_idle_tick() Cc: Frederic Weisbecker , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240225225508.11587-7-frederic@kernel.org> References: <20240225225508.11587-7-frederic@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170898627665.398.805229144856178404.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792002142595006813 X-GMAIL-MSGID: 1792002142595006813 The following commit has been merged into the timers/core branch of tip: Commit-ID: 60313c21c33abc08108bdd60390fa89563977e64 Gitweb: https://git.kernel.org/tip/60313c21c33abc08108bdd60390fa89563977e64 Author: Frederic Weisbecker AuthorDate: Sun, 25 Feb 2024 23:54:58 +01:00 Committer: Thomas Gleixner CommitterDate: Mon, 26 Feb 2024 11:37:31 +01:00 tick/sched: Don't clear ts::next_tick again in can_stop_idle_tick() The tick sched structure is already cleared from tick_cancel_sched_timer(), so there is no need to clear that field again. Signed-off-by: Frederic Weisbecker Signed-off-by: Thomas Gleixner Reviewed-by: Thomas Gleixner Link: https://lore.kernel.org/r/20240225225508.11587-7-frederic@kernel.org --- kernel/time/tick-sched.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 9f75f56..b17895d 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1143,11 +1143,6 @@ static bool can_stop_idle_tick(int cpu, struct tick_sched *ts) if (unlikely(!cpu_online(cpu))) { if (cpu == tick_do_timer_cpu) tick_do_timer_cpu = TICK_DO_TIMER_NONE; - /* - * Make sure the CPU doesn't get fooled by obsolete tick - * deadline if it comes back online later. - */ - ts->next_tick = 0; return false; }