[v2,1/7] tracing/fprobe-event: cleanup: Fix a wrong comment in fprobe event

Message ID 170891988369.609861.16668663308029384207.stgit@devnote2
State New
Headers
Series tracing/probes: Support function parameter access from return probe |

Commit Message

Masami Hiramatsu (Google) Feb. 26, 2024, 3:58 a.m. UTC
  From: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Despite the fprobe event,  "Kretprobe" was commented. So fix it.

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
 kernel/trace/trace_fprobe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Steven Rostedt March 1, 2024, 3:34 a.m. UTC | #1
On Mon, 26 Feb 2024 12:58:03 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> 
> Despite the fprobe event,  "Kretprobe" was commented. So fix it.
> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/trace/trace_fprobe.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c
> index 7d2ddbcfa377..3ccef4d82235 100644
> --- a/kernel/trace/trace_fprobe.c
> +++ b/kernel/trace/trace_fprobe.c
> @@ -210,7 +210,7 @@ fentry_trace_func(struct trace_fprobe *tf, unsigned long entry_ip,
>  }
>  NOKPROBE_SYMBOL(fentry_trace_func);
>  
> -/* Kretprobe handler */
> +/* function exit handler */
>  static nokprobe_inline void
>  __fexit_trace_func(struct trace_fprobe *tf, unsigned long entry_ip,
>  		   unsigned long ret_ip, struct pt_regs *regs,
  

Patch

diff --git a/kernel/trace/trace_fprobe.c b/kernel/trace/trace_fprobe.c
index 7d2ddbcfa377..3ccef4d82235 100644
--- a/kernel/trace/trace_fprobe.c
+++ b/kernel/trace/trace_fprobe.c
@@ -210,7 +210,7 @@  fentry_trace_func(struct trace_fprobe *tf, unsigned long entry_ip,
 }
 NOKPROBE_SYMBOL(fentry_trace_func);
 
-/* Kretprobe handler */
+/* function exit handler */
 static nokprobe_inline void
 __fexit_trace_func(struct trace_fprobe *tf, unsigned long entry_ip,
 		   unsigned long ret_ip, struct pt_regs *regs,