[tip:,timers/core] timers: Restructure get_next_timer_interrupt()

Message ID 170862193726.398.15267422855712611141.tip-bot2@tip-bot2
State New
Headers
Series [tip:,timers/core] timers: Restructure get_next_timer_interrupt() |

Commit Message

tip-bot2 for Thomas Gleixner Feb. 22, 2024, 5:12 p.m. UTC
  The following commit has been merged into the timers/core branch of tip:

Commit-ID:     bebed6649e85fe55275bd20104ec8e0bdff1bf54
Gitweb:        https://git.kernel.org/tip/bebed6649e85fe55275bd20104ec8e0bdff1bf54
Author:        Anna-Maria Behnsen <anna-maria@linutronix.de>
AuthorDate:    Wed, 21 Feb 2024 10:05:29 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 22 Feb 2024 17:52:30 +01:00

timers: Restructure get_next_timer_interrupt()

get_next_timer_interrupt() contains two parts for the next timer interrupt
calculation. Those two parts are separated by forwarding the base
clock. But the second part does not depend on the forwarded base
clock.

Therefore restructure get_next_timer_interrupt() to keep things together
which belong together.

No functional change.

Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20240221090548.36600-2-anna-maria@linutronix.de

---
 kernel/time/timer.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
  

Patch

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index d44dba1..316ded6 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1982,12 +1982,6 @@  u64 get_next_timer_interrupt(unsigned long basej, u64 basem)
 	if (base->next_expiry_recalc)
 		next_expiry_recalc(base);
 
-	/*
-	 * We have a fresh next event. Check whether we can forward the
-	 * base.
-	 */
-	__forward_timer_base(base, basej);
-
 	if (base->timers_pending) {
 		nextevt = base->next_expiry;
 
@@ -2006,6 +2000,12 @@  u64 get_next_timer_interrupt(unsigned long basej, u64 basem)
 	}
 
 	/*
+	 * We have a fresh next event. Check whether we can forward the
+	 * base.
+	 */
+	__forward_timer_base(base, basej);
+
+	/*
 	 * Base is idle if the next event is more than a tick away.
 	 *
 	 * If the base is marked idle then any timer add operation must forward