From patchwork Sat Dec 2 12:36:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Can Guo X-Patchwork-Id: 172820 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1735831vqy; Sat, 2 Dec 2023 04:37:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEreP/C28mIawnr2oZbpdQh+VSMTOyHlnq9uprs79bWO0alOIOOKL/z8FYJNDHSmOhAbsKh X-Received: by 2002:a17:902:a707:b0:1d0:3fb3:920a with SMTP id w7-20020a170902a70700b001d03fb3920amr298825plq.19.1701520667396; Sat, 02 Dec 2023 04:37:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701520667; cv=none; d=google.com; s=arc-20160816; b=R7lJPotHzvKe8mpJcd6wLYGDAePHBvZtY4elLezO38+m1A8QPLFYenXCRWVS8SjGoz THfq8NUnD+eT7xMKUatHKPjuRXcrsBUZuIavLGZ6lB9ClcEdUD6kpR9u6ZzRmpEamOhB qD2I9XI4NyZ4sPF/ITlZDjOpYGO4rLh5KrKX8eTYiEpij8yfpifdwMZVYF95c1JrZP17 wJQOGc0DCs7rAq5FtgdsXBB/ZngjDpVC19mzjAGaSRlWKEr4A9yfq29qXWehplIBpeh7 Saff81gv5WfITlJ3WSLDsyg2Qo+xYCtTbgduoeC0D+o4jTTo/GlmeKbbwGjuQCwFzcod TXXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=hI4B+En5B8Tnj5LoYIYk/lWCpU5mfeoE4ccGSVr3iU4=; fh=qjyuAZtnBDAP5VV5yupeXWqG7dBA1spPLDpGIgUrZDc=; b=jfh/oWvsrDVabZWnq4mwLi/JKBcdMczC1Ceio00O9oKoOa5t/HkYhVKlRgUZJbAyQ4 FWPrn3rD09xyEIt0ckhBedBMFgV7boFvWBqLRFygZoH8u2kNCZn7y7Qpt5bd20UFIi26 BXDFcskufZKWt91ibMPPizsfNOclOGRq1XtgK6avL5a+UPYMNkvD9hHSXsK+THyYmqwE UOu03cKX86OnYGVOU4tzVb+TSsFvjoIx5ooaI+Qg97QVxDahu+pwHjB3xycrIt1V7jSE O7oIhedtl2D6NCt/2sQbIMK1kAy0u2WIgb6a/eNZ1s8vcT98TiDqoQeRXDbjvlVgkb8F +OTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="Gy/MbLlo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id j7-20020a170903024700b001cfaa9ba6basi4858573plh.240.2023.12.02.04.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 04:37:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="Gy/MbLlo"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id EEA9A805ECEE; Sat, 2 Dec 2023 04:37:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232696AbjLBMg6 (ORCPT + 99 others); Sat, 2 Dec 2023 07:36:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229949AbjLBMgy (ORCPT ); Sat, 2 Dec 2023 07:36:54 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84D0112E; Sat, 2 Dec 2023 04:37:01 -0800 (PST) Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B2CaeTN027872; Sat, 2 Dec 2023 12:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=hI4B+En5B8Tnj5LoYIYk/lWCpU5mfeoE4ccGSVr3iU4=; b=Gy/MbLlopk638E+m7O4Yn07hS5x0Q7WZF9CpHTCujkNbji7g1Lm/3nx+Ay6UAg7Z6dPO nHtFFE+cmSBMIrLPsNpvOw50Z/QHZ3oMNof8q2lcAD5uP1sM60FrMctCVMfBLKZxWe3/ 39p0enGp9DfJ7uT9T9BrnXCd85dRoH2ScjSJ2hVKEZDL4LAk9RuW7rm8ulzo+ENUDhjx +CzML75Bqh0U7WZcqAzGZ5HX6Un+OkYip2TLu26cPr8y+cpxlbo3KfmFjjPSAoA4IoeG WeVRefjwkHCiC09qi8AU16JdfMnrcdD6B14N2vQFH7qvQLZHv5qu8VDRm98aGpu6i96k /A== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3uqwbqggnd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 02 Dec 2023 12:36:40 +0000 Received: from pps.filterd (NASANPPMTA03.qualcomm.com [127.0.0.1]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3B2Ca9qC017639; Sat, 2 Dec 2023 12:36:39 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTP id 3uqwnkb9qk-1; Sat, 02 Dec 2023 12:36:39 +0000 Received: from NASANPPMTA03.qualcomm.com (NASANPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B2CadXr018426; Sat, 2 Dec 2023 12:36:39 GMT Received: from stor-dylan.qualcomm.com (stor-dylan.qualcomm.com [192.168.140.207]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTP id 3B2Cad4v018423; Sat, 02 Dec 2023 12:36:39 +0000 Received: by stor-dylan.qualcomm.com (Postfix, from userid 359480) id 661D120A90; Sat, 2 Dec 2023 04:36:38 -0800 (PST) From: Can Guo To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, adrian.hunter@intel.com, vkoul@kernel.org, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , "James E.J. Bottomley" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v8 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Date: Sat, 2 Dec 2023 04:36:08 -0800 Message-Id: <1701520577-31163-3-git-send-email-quic_cang@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1701520577-31163-1-git-send-email-quic_cang@quicinc.com> References: <1701520577-31163-1-git-send-email-quic_cang@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: 3hsTozTYeMJKWV95K81hzMYBlPgR3CEf X-Proofpoint-GUID: 3hsTozTYeMJKWV95K81hzMYBlPgR3CEf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-02_10,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312020094 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 02 Dec 2023 04:37:46 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784173735443295872 X-GMAIL-MSGID: 1784173735443295872 In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Reviewed-by: Nitin Rawat Reviewed-by: Manivannan Sadhasivam Reviewed-by: Andrew Halaney Signed-off-by: Can Guo --- drivers/ufs/host/ufs-qcom.c | 1 - drivers/ufs/host/ufs-qcom.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 197c5a5..c21ff2c 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, switch (status) { case PRE_CHANGE: ufshcd_init_host_params(&host_params); - host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE; /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */ host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba); diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 9950a00..82cd143 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -27,8 +27,6 @@ #define SLOW 1 #define FAST 2 -#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B - /* QCOM UFS host controller vendor specific registers */ enum { REG_UFS_SYS1CLK_1US = 0xC0,