| Message ID | 1701407001-471-8-git-send-email-quic_cang@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp887792vqy;
Thu, 30 Nov 2023 21:05:38 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IGCOfPGZhf+vQv3ozFpO10cwIt6rCH922eomcXl9as9c3RR82JYYGDDjPPfaFKfJCVhCNyM
X-Received: by 2002:a05:6808:17a5:b0:3b6:d371:d4d4 with SMTP id
bg37-20020a05680817a500b003b6d371d4d4mr2416836oib.37.1701407138150;
Thu, 30 Nov 2023 21:05:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1701407138; cv=none;
d=google.com; s=arc-20160816;
b=CQIdyFhlLR3As5ErB+Npqu7cmM5TEmJf6UVkQM3MILJDGQUxWFvkpk3ArzlPHf5fEU
nMj2k3IC8xj1u8MdGEAe+1zl7sYAj1t8+uTuynUVhO/41Qk0zfapRda0RCbV2d2Fs6Gk
Byj2qK9LrBm9bE1ybPM1Irf5oPAc0w9L2wuBGooduudD7fE3MnvejmJB80Ho1rJvGZNS
f63wxi6A88WPZyaf2NzthwAO1AQLR0YhFhhDBfEc0x2oN0lhOico8L9Yl2xHdEjukKer
ZZ2TKEQNpUrVj8C8sxTj3X3rvrnvriQSmxodSxPJVjXz3AIQQEwGhjqdFkW2Tz+K5ah0
vMTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:references:in-reply-to:message-id:date:subject
:cc:to:from:dkim-signature;
bh=ZC/earWkqWNkcUV0oq+iV9LAfKxTP8mapb8MzlHxtCk=;
fh=qjyuAZtnBDAP5VV5yupeXWqG7dBA1spPLDpGIgUrZDc=;
b=UfofutCjp2KRBMMJBv31DgEs3IF8FfIdSimKT9uvycNyF97KxJQZSXJ3gtesptSvHH
lxqjPjhtHxYGNdZvgTd2oMteV2zW0mLr3osoSK2sCumafosUvGtXJExK7pm2Fyh9lY/S
+MIRhPE8bUis+BJENw0InlMISgauuhqJwxwNuJi1NEXF1ereMaGgQe/AAd59tfTF25SO
rZl9XvSHQAkQNb72PV0az8whLT96LVtCGLxOUvG9Ygui74B1AaP1XqCRAEeNAmRxmhSn
s+mqfP3n7ApJUMOPAtLfHPs6XAWgfvT+CdQMSQdfzGoIGXokkgoJ6xrbjPfqwIjyQ5NB
K9pg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EmTDw1yg;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4])
by mx.google.com with ESMTPS id
q197-20020a632ace000000b005c625b9f61esi2529645pgq.779.2023.11.30.21.05.37
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 30 Nov 2023 21:05:38 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
client-ip=2620:137:e000::3:4;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=EmTDw1yg;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 979438705EB0;
Thu, 30 Nov 2023 21:05:34 -0800 (PST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1377386AbjLAFFB (ORCPT <rfc822;ruipengqi7@gmail.com>
+ 99 others); Fri, 1 Dec 2023 00:05:01 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57378 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1377393AbjLAFEk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 1 Dec 2023 00:04:40 -0500
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35EAB1726;
Thu, 30 Nov 2023 21:04:46 -0800 (PST)
Received: from pps.filterd (m0279873.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
3B14xB1o000982;
Fri, 1 Dec 2023 05:04:07 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references; s=qcppdkim1;
bh=ZC/earWkqWNkcUV0oq+iV9LAfKxTP8mapb8MzlHxtCk=;
b=EmTDw1ygQIk422hZtfbXhiRelECZr5rg6eLv0WVy/cJ2TKBeNLv8FqA4NTNnocHw/SCd
6o3cNGJF+nCpHa2kyZw0JHGEIDxcWRrBOr0FuYF56tnb2PS5GB4WpaiXeICCIYN7yTR+
m/dd46LI55oGrwLWuocXZYIvJuvs2pl98RMi6GR3/mfQomRAU3GNGZQ6HJrJIpKBSX9f
X+NBYVi9m22lBqUjmSqS114QW0QK7B+onWUXWZtLbFORwNA+ejb5wsMwRfhcOfWmzqOt
Zpdpo+hkkLepKyeCdEJq600SjaeEzfSYMdqHGiWuPcrF9AVD5/KWiuXu2HYuIxFFK6pG cg==
Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com
[199.106.103.254])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3upvm1su3f-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Fri, 01 Dec 2023 05:04:06 +0000
Received: from pps.filterd (NASANPPMTA04.qualcomm.com [127.0.0.1])
by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id
3B14icuq010891;
Fri, 1 Dec 2023 05:04:05 GMT
Received: from pps.reinject (localhost [127.0.0.1])
by NASANPPMTA04.qualcomm.com (PPS) with ESMTP id 3unmewu5hx-1;
Fri, 01 Dec 2023 05:04:05 +0000
Received: from NASANPPMTA04.qualcomm.com (NASANPPMTA04.qualcomm.com
[127.0.0.1])
by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B1545Ze004609;
Fri, 1 Dec 2023 05:04:05 GMT
Received: from stor-dylan.qualcomm.com (stor-dylan.qualcomm.com
[192.168.140.207])
by NASANPPMTA04.qualcomm.com (PPS) with ESMTP id 3B1545VI004597;
Fri, 01 Dec 2023 05:04:05 +0000
Received: by stor-dylan.qualcomm.com (Postfix, from userid 359480)
id A6C7B20A73; Thu, 30 Nov 2023 21:04:04 -0800 (PST)
From: Can Guo <quic_cang@quicinc.com>
To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org,
adrian.hunter@intel.com, vkoul@kernel.org, beanhuo@micron.com,
avri.altman@wdc.com, junwoo80.lee@samsung.com,
martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v7 07/10] scsi: ufs: ufs-qcom: Check return value of
phy_set_mode_ext()
Date: Thu, 30 Nov 2023 21:03:17 -0800
Message-Id: <1701407001-471-8-git-send-email-quic_cang@quicinc.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1701407001-471-1-git-send-email-quic_cang@quicinc.com>
References: <1701407001-471-1-git-send-email-quic_cang@quicinc.com>
X-QCInternal: smtphost
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-ORIG-GUID: 4N4QdOsZjC-UO2zg5nPsQFPK7VfPq8fs
X-Proofpoint-GUID: 4N4QdOsZjC-UO2zg5nPsQFPK7VfPq8fs
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2023-12-01_02,2023-11-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
suspectscore=0
priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 malwarescore=0
bulkscore=0 adultscore=0 clxscore=1015 mlxscore=0 mlxlogscore=999
lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2311060000 definitions=main-2312010028
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Thu, 30 Nov 2023 21:05:34 -0800 (PST)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1784054691097834771
X-GMAIL-MSGID: 1784054691097834771
|
| Series |
Enable HS-G5 support on SM8550
|
|
Commit Message
Can Guo
Dec. 1, 2023, 5:03 a.m. UTC
In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext() and stop proceeding if phy_set_mode_ext() fails. Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com> Signed-off-by: Can Guo <quic_cang@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On Thu, Nov 30, 2023 at 09:03:17PM -0800, Can Guo wrote: > In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext() > and stop proceeding if phy_set_mode_ext() fails. > > Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com> > Signed-off-by: Can Guo <quic_cang@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/ufs/host/ufs-qcom.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 543939c..ee3f07a 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -475,7 +475,9 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) > return ret; > } > > - phy_set_mode_ext(phy, mode, host->phy_gear); > + ret = phy_set_mode_ext(phy, mode, host->phy_gear); > + if (ret) > + goto out_disable_phy; > > /* power on phy - start serdes and phy's power and clocks */ > ret = phy_power_on(phy); > -- > 2.7.4 >
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 543939c..ee3f07a 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -475,7 +475,9 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba) return ret; } - phy_set_mode_ext(phy, mode, host->phy_gear); + ret = phy_set_mode_ext(phy, mode, host->phy_gear); + if (ret) + goto out_disable_phy; /* power on phy - start serdes and phy's power and clocks */ ret = phy_power_on(phy);