[v7,02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param()
Message ID | 1701407001-471-3-git-send-email-quic_cang@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp887552vqy; Thu, 30 Nov 2023 21:05:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IERQx1LpIAqPk2VLfkwJf42G4Ol7p7h8qZLP4N6E+RGkjcqkbD9c6XKCx4y3R6QyGbBbRLy X-Received: by 2002:a05:6a20:6a20:b0:18a:d791:6629 with SMTP id p32-20020a056a206a2000b0018ad7916629mr31458191pzk.11.1701407102138; Thu, 30 Nov 2023 21:05:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701407102; cv=none; d=google.com; s=arc-20160816; b=EsoFq9/E3k6NdQLLBANYmrSLefdneDVhK5gKpIvTeIDWUHIOj/tUSMkXwGiQz0279X A77mcDfrXUJ7QxwTx/Wx88AsJUyRDsuM2bOFtor/lDu7G0mf5QykKAU+6N9RQig98nDL 8lb9obIu72ERBb2S4TK4LOpvfPHf4fNgj0nTC9js7SihCiJcT1XtxwEoE48l9YgtS1nT sygwPOjnKkLYNlc2FZCMNI4svupQEHzjSQPPFxLJml0wi2BoOfNwprrPkbdyTYGrd3OW CDi5lNyLEIaPZhckP9fqa/VNfHIBRFmSm/8ceSUHVFghSvq/+t+INljkbA5ehxZOAZz4 jaFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=hI4B+En5B8Tnj5LoYIYk/lWCpU5mfeoE4ccGSVr3iU4=; fh=qjyuAZtnBDAP5VV5yupeXWqG7dBA1spPLDpGIgUrZDc=; b=prKvCZM9PHWLRjs0LBKse/GpCFa1VkuLWQb6quVgn8DNjlAv/BLEzJzT+q7XFRgTAj BHjG1FnrvITKuyfKzfb03QjoYicuQug9JhlchbQwkk1vojX4hFMOes5M/1TZrgr2dwRg 4XLCua6ClMsUIxmZNi0ufzbVnLndoQ4bjBQE6EHLyLxtpYR57oXFdZivQn5NRMzEu/1o eayd1q7BNhROAb1oQIxaD3gr9xZz5TtaPBj/AYQkImYbopngrhflcLbI8OmbDREYQrum OL3D4NypkvAvSKs+Jvc3TwLEcojc0uQh6zuZcvrbHB/X2/7FnOuaamyTJ3GAGLIK3Wjk VtaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nJHbf0Ea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id d4-20020a056a0010c400b006cdeb7e9f6dsi2460306pfu.234.2023.11.30.21.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 21:05:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=nJHbf0Ea; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 8C8AE801CE91; Thu, 30 Nov 2023 21:04:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377386AbjLAFEj (ORCPT <rfc822;ruipengqi7@gmail.com> + 99 others); Fri, 1 Dec 2023 00:04:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377365AbjLAFEh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 1 Dec 2023 00:04:37 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E4021725; Thu, 30 Nov 2023 21:04:42 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3B149v0h019900; Fri, 1 Dec 2023 05:04:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=hI4B+En5B8Tnj5LoYIYk/lWCpU5mfeoE4ccGSVr3iU4=; b=nJHbf0EaeQqcKChBhcjViN68LkK99YO6f+oDYGG3/EC0+1azzeypL5xRcQxlYd487XCt Dclyz1DtiADUw32imWnu7t1qR992mbEZcV8a6h7FCVtCm+cS2F51hD4cP4xMvdH9rqBS Pqkuo/QiD23wOruWDu19aYOEDLNWCEFdaNNwTPB8w6Q/gYaFb6qfuqkX5mh+Mv5u+mcS R300u2frrS8nY5WAVyAxzBuuGUN/dRM+jUj2DyNotCqd0BWPvQORABGhDRX7xexdEx40 +Ua24zfmp8ty1RDt1TBIsJ0m09GAw05eAbdkHRZ4qCzdJ19LsQHNX0KncsiQKslHOMB0 Ug== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3upv481we6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Dec 2023 05:04:01 +0000 Received: from pps.filterd (NASANPPMTA05.qualcomm.com [127.0.0.1]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 3B14uWJZ024440; Fri, 1 Dec 2023 05:04:00 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTP id 3unmevmcac-1; Fri, 01 Dec 2023 05:04:00 +0000 Received: from NASANPPMTA05.qualcomm.com (NASANPPMTA05.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3B153xcZ003911; Fri, 1 Dec 2023 05:04:00 GMT Received: from stor-dylan.qualcomm.com (stor-dylan.qualcomm.com [192.168.140.207]) by NASANPPMTA05.qualcomm.com (PPS) with ESMTP id 3B153xYq003910; Fri, 01 Dec 2023 05:03:59 +0000 Received: by stor-dylan.qualcomm.com (Postfix, from userid 359480) id 9D61F20A69; Thu, 30 Nov 2023 21:03:59 -0800 (PST) From: Can Guo <quic_cang@quicinc.com> To: quic_cang@quicinc.com, bvanassche@acm.org, mani@kernel.org, adrian.hunter@intel.com, vkoul@kernel.org, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH v7 02/10] scsi: ufs: ufs-qcom: No need to set hs_rate after ufshcd_init_host_param() Date: Thu, 30 Nov 2023 21:03:12 -0800 Message-Id: <1701407001-471-3-git-send-email-quic_cang@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1701407001-471-1-git-send-email-quic_cang@quicinc.com> References: <1701407001-471-1-git-send-email-quic_cang@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: QB8rppHDrRT2TJxB6gzKsyhcL0_SL3xb X-Proofpoint-ORIG-GUID: QB8rppHDrRT2TJxB6gzKsyhcL0_SL3xb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-01_02,2023-11-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2312010028 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 30 Nov 2023 21:04:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784054653692900503 X-GMAIL-MSGID: 1784054653692900503 |
Series |
Enable HS-G5 support on SM8550
|
|
Commit Message
Can Guo
Dec. 1, 2023, 5:03 a.m. UTC
In ufs_qcom_pwr_change_notify(), host_params.hs_rate has been set to PA_HS_MODE_B by ufshcd_init_host_param(), hence remove the duplicated line of work. Meanwhile, removed the macro UFS_QCOM_LIMIT_HS_RATE as it is only used here. Reviewed-by: Nitin Rawat <quic_nitirawa@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Can Guo <quic_cang@quicinc.com> --- drivers/ufs/host/ufs-qcom.c | 1 - drivers/ufs/host/ufs-qcom.h | 2 -- 2 files changed, 3 deletions(-)
diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 197c5a5..c21ff2c 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -909,7 +909,6 @@ static int ufs_qcom_pwr_change_notify(struct ufs_hba *hba, switch (status) { case PRE_CHANGE: ufshcd_init_host_params(&host_params); - host_params.hs_rate = UFS_QCOM_LIMIT_HS_RATE; /* This driver only supports symmetic gear setting i.e., hs_tx_gear == hs_rx_gear */ host_params.hs_tx_gear = host_params.hs_rx_gear = ufs_qcom_get_hs_gear(hba); diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 9950a00..82cd143 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -27,8 +27,6 @@ #define SLOW 1 #define FAST 2 -#define UFS_QCOM_LIMIT_HS_RATE PA_HS_MODE_B - /* QCOM UFS host controller vendor specific registers */ enum { REG_UFS_SYS1CLK_1US = 0xC0,