From patchwork Thu Nov 24 18:38:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matija Glavinic Pecotic X-Patchwork-Id: 25675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp3556974wrr; Thu, 24 Nov 2022 10:44:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Nu8ybSEflASsRyqmW+4Z2qF4LpfQdS55RHCkHDBlX3tMBX25Drx0BsIzdLA8ng0SfqKGd X-Received: by 2002:a05:6a00:1a14:b0:572:5be2:505b with SMTP id g20-20020a056a001a1400b005725be2505bmr15275149pfv.52.1669315459194; Thu, 24 Nov 2022 10:44:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1669315459; cv=pass; d=google.com; s=arc-20160816; b=ODXDSDoNFFleigKx6bGE+9cyAepDmVJiTMLLlaO0fas4R02+cfS7GJ3k9h46SDjLM4 K1oNghv+v+mcOoeMaGCpKOQqMqP+Mh3iWlzp29/2Ba302e3dpaAAnIBOt1CKxQFJ/b5+ NxWj69n+HTIv6lnqMvhu6FdMeVl6ozHB9IaVkDJrYsaVDQjBOVzzQESJaB/911vHJoHu 1iIYbDx0RN1ntq+hSSQK/SI4Fu/2YmGRvBg9NPJ/YhGyOrIjV3VNe0w16GGkNghmaE73 +GrbZl0zAIbvMx7ZQBIcOmWUvUndm7qXvphELu/graUktwrTeF+zmqKCHuIUE10ejL0/ CclA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding:subject :from:to:content-language:user-agent:date:message-id:dkim-signature; bh=jTDvPQv97PHO6VtHikMfGw8uQLOY1XJ1MSSeLgEjz6Q=; b=JkmwVUbQ9Q4ezbG94H12XFOlS3ICtqdzdi3I+P4nhvSSWwmEi1kGbxaEBEJ/yvTeC7 LBghnV5TJ/J6VFZUUkbSECPImkYooEH53fqbRJQElhqYxdOJTtj+K00GG3bfCtDeRGSq ACt40GpbQax44o2b0rCrhBW4QcaViBQlQzIphlcRv9nBjcjhTAzyFAEMZ0QZc0mRpdWD UO1sGfSuWMBKpltNbVeLL06bOFkFSVwI6BzA9uLyPqPEMJEvjcguVndlKvS4ArixFVy9 9kC3CE7DQByG++bmMoZM+1Ht8vI6m9zuwa8JcbeCmHzGR5UuONlcGpK4qkfrVeboyrcR rqcA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-onmicrosoft-com header.b=iPZdV1CE; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a170902cccf00b00186658e50desi1713766ple.465.2022.11.24.10.44.06; Thu, 24 Nov 2022 10:44:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@nokia.onmicrosoft.com header.s=selector1-nokia-onmicrosoft-com header.b=iPZdV1CE; arc=pass (i=1 spf=pass spfdomain=nokia.com dkim=pass dkdomain=nokia.com dmarc=pass fromdomain=nokia.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nokia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229639AbiKXSjE (ORCPT + 99 others); Thu, 24 Nov 2022 13:39:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbiKXSjC (ORCPT ); Thu, 24 Nov 2022 13:39:02 -0500 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2124.outbound.protection.outlook.com [40.107.105.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA2E71255F7 for ; Thu, 24 Nov 2022 10:38:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtVdTeYA+qH40YzERQ1Y5HLDigxUWXvY/ugg9CLD3vAnKrQa4urNzG+6Y7c5ye+6vLmYlLAqEqgu5pLrm5AnpOPEKCME+BT2dzhGkNypLXRRI4KmsxowtLeyDN9eLEyCFu0Ga8jfFTqh3HKxrJq2bdR9OpibfHeuO6lsiX+4Bhfr8Eu5WFUxd1RbtEXCMzpLeIDxhWlBPT/+mbwRd6Ci0MNSvPdk0ofIbZt1PLY/ft7qaKx9rthuQBOPbhxz3USWmHcgXvO9p2C/qlinof6kNbT0FbpWSfg3+53c1ewihGxE6FdnxmGJ3vJHrAA5g+S4xISYanOZhVc+9CTX8w4Dqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jTDvPQv97PHO6VtHikMfGw8uQLOY1XJ1MSSeLgEjz6Q=; b=ePvVMdY5C4STAX0aiGqgkmTq6l+W7DD18rTlcW6+yLKYANsxKq6Hrg9czvi7t+4dHIkoHAgSLt9J4l9pQjN8Z1hlFj5howcM1KKkTGJWl85juaxcxwMJ81Wa5bzx4XJasWj4AuVJEDPqkPB/v4/xLbPNLdS07wJOXsR4Iy8zV0OjxGwvxggSbNiDtmr3/Xe7tHmiJPK3/baG0n4EHw0LjG3uAheSpaDs6Ca14qmfPLOLf7SZ5yCqt4pBr+pIJzd4iXA9uiHI2hYeH2GJtIMPqhT2XX+j19t4ikK5V4FMi7GeY0EfgJ1o9asMFB4OR13vwowTvhtNRN6WO9Q079fpsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jTDvPQv97PHO6VtHikMfGw8uQLOY1XJ1MSSeLgEjz6Q=; b=iPZdV1CE1x37XE2uph1rpNJ/vvyTz13zbSTJRRNM7zrmldjEfudW/5o1eJ1ZVDk7Tm8p50JC33G06pnhAz+l/ZXYBdnB/2yJn1r11Tmsq9kkGbn36HGUacdfoVJxqo4EqmSskMuiiIBU7lmHh8m/g+fUCAOkzFRQNqWZqc9GUdE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com; Received: from VI1PR0701MB3005.eurprd07.prod.outlook.com (2603:10a6:800:87::19) by VI1PR07MB6607.eurprd07.prod.outlook.com (2603:10a6:800:181::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.11; Thu, 24 Nov 2022 18:38:57 +0000 Received: from VI1PR0701MB3005.eurprd07.prod.outlook.com ([fe80::bacd:11a2:15e2:7339]) by VI1PR0701MB3005.eurprd07.prod.outlook.com ([fe80::bacd:11a2:15e2:7339%11]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 18:38:57 +0000 Message-ID: <16a20fd7-1449-70d0-a7e6-38502531434e@nokia.com> Date: Thu, 24 Nov 2022 19:38:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, hpa@zytor.com From: Matija Glavinic Pecotic Subject: [PATCH v4] x86/rtc: Remove __init for runtime functions X-ClientProxiedBy: HE1PR0701CA0066.eurprd07.prod.outlook.com (2603:10a6:3:9e::34) To VI1PR0701MB3005.eurprd07.prod.outlook.com (2603:10a6:800:87::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR0701MB3005:EE_|VI1PR07MB6607:EE_ X-MS-Office365-Filtering-Correlation-Id: efd72343-81db-4439-fcea-08dace4b2586 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TTlTuDsxegFw8Kn1mazMqnhouFOnKAp6QAgDjugiaPH4W37Ah/wVc46eCHzi1ui84I12MuV0Z4PRiiE+b2uBOj68bQN/2E4QgVb8nojPR0fHPEp1/QUGFSWdrqehNqrQe9BF+AlbydDGvJv/j4Edry4clSnSp9Z/it3nmbEG2j4wbsaLUb6AKFvgPDDhzdqmutEpU2N8gfEE7NV/OAIZCuXC/HeQalAoWk8/5pK8FPih1fVmmQBSOa1Zie49CAqRct7cHSCMsTtBCTMUQAD2hehia5NHfnkCzWJB9z3No905tfoRlKPYWhTTIa5vscrg53U4K2vO/8uK0kjEKbUhcxSu8GKrRl77bKdDeQHprN+q9/rPn+0QJ5+XkkL0h3clMS+NnYXaRFuLJLRqsLTWbCRV7XoZdPJd2vasRhr9ynUl+2HibLeENlxMw+6L+q55KUux6bn/Us1ACMorfBjqo3yI9KpHnvXj+/rY+3dkmm61AI0R7s86IH9H3nIXaaFBC7AWnlNWCiAaFUNfKqlPg6AtV/qA7uuZ13n9ws1u1ou1LMtmkJeWwd/eXQ2j0YQgK1e9XG8XWmRCagor+D2PaJqAQzXLZFEuVdPbgK4UZGoUYswvfSr0L8In0hmF5BRyhLrqCYk4o3eZsz501+e3ZYWxHxGAbrrMUUV8dxVP2Vzj2TCpqs2FnjPcNVplGSDgEDKaJT5N8WOkAsEPKAWOXW2ApH0WZdBGk09sXmaBVLs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0701MB3005.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(451199015)(6512007)(26005)(83380400001)(82960400001)(186003)(38100700002)(31696002)(2616005)(2906002)(41300700001)(8676002)(5660300002)(8936002)(66476007)(6506007)(55236004)(316002)(66556008)(478600001)(66946007)(6486002)(6666004)(86362001)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vB9cinzs8YVJuixgR3OXJgvnOOud?= =?utf-8?q?+aALoP9Sj3rpGpqp3Vvp87MUfzkfEJHaeSHWEccI/z/8CFsjbf+nWr8ZMGPg1j9Eb?= =?utf-8?q?CTBvhT2HCPGjDDcb0trLBk1NlcQgKAu7OzDZY5iynhPkrXiLC57deqbp+jK/dseFF?= =?utf-8?q?HbB9OtcLJjcNV8+8Cye58oThv4+6Y8tCzmySx5IISSCGymVg0ArcyCZRd9rhDQ/0b?= =?utf-8?q?lbaF+lpyo/r3bZ/JCpLjgnStr29JinywViEAxQ+rWwzOL75dfbVPTRpQSV3ZrOj5e?= =?utf-8?q?9T+fldCf4jnzvoIx1o/VPZhxOTmlLlMI7zJi84vWE9uZgboUg7Ew84jdrgXykGiom?= =?utf-8?q?YN3cAzl9tlqhCffuPkL7iG3vqRiq1Avh8iJX9TiwAQgrKu/cWwEjHWlSmGhWB1e7M?= =?utf-8?q?wG6fLydWjjkdpNHedNtHDrT+1FoIkMBkF85mDrkSluwhInplTpPPk/lEBUYQL5X7y?= =?utf-8?q?0+AyKUy8v5LARdvYjZgfP1ov8zyD1SRqpr3rXzWjf156Df/EXyfW0Y7m97AdKgyEt?= =?utf-8?q?9OmKmn8wR0cj+GDfHqmAz16DAUcGmHApinBneoIuGo2ZZk4tBXJjot1LfSQQMmf4s?= =?utf-8?q?yR/YMdoBXS0YeqZIJREPiEOIr6zuuL26jqC6BYnGlacdgo7oS0ObmnWMrgp7erRR0?= =?utf-8?q?uQANllfr0tTzzcIm5Tt4yWRITQ1IaE+gEb6/6dTrJbMQ7xs7b3pMvMLAuqOTRkOlY?= =?utf-8?q?sSW8CICFmSwsfYomPLZn0PlQ1lam7Hm4wPKF4o1889ecoDvnnss41aOQMn94EEj/U?= =?utf-8?q?K5hUYzfT48a1/rhOo5nrX64INN/NsCIK2XrwEYHjeGVutoiwQs7cwLy3wSIziPIMp?= =?utf-8?q?F4PwlQHIUh/BQqAILnLpDw97MXrVRMw+FyqfqNSp+T5kzr6GFk5ODSzL5BqeKWo12?= =?utf-8?q?5h7dAgcaYeE6+amTsi5VyTzHTa4JNE8KrqSDN9WEuITCKsOldAmTf/r4NSqtACJos?= =?utf-8?q?i+2/VNAxj79yMpOoHoAaNGFBM80tJ7JyU8hPh1dgCB+cTsXr+CDa2yMl4Xzs1mROF?= =?utf-8?q?rRkH5yScwuCW5DqW3NP0csF4DAuqTcTIM+b5U775OAWVSMDIxV3eHAKjuFL25oLgR?= =?utf-8?q?n4vCOzl0MK+bwUS1mQK+hQuyYcgQUlJVH/vW4uhNH7nlPWP405+rv06uYEy5kUsiu?= =?utf-8?q?GVCu9sVcHCyvVXgIHdBMtscUz/ZdLYj9t94HTRlL1zk0dJRliegU8X9KqG9VuPbqF?= =?utf-8?q?4n2EPTcs9i/EWiIlP71wtHvfbWDw65kp4XeiuTs9pTbg9hqm9KfsSK7M2wW9JbBPs?= =?utf-8?q?FtgoNHrSiE/8XkLlIOFeF8MRLetleaYLC9RJu8t1ZNbMXbqDZ+3GRqKfwKFqAKw86?= =?utf-8?q?7n9vDXrl/YYcv9FlDUb01/6VTFHyf471xHyQqkruPSxW/v1A598YzDM9RExXNRZ9S?= =?utf-8?q?PCoiVTawLeQB9C7aFLROynxS9NU/Qs8N6/wjmcvN77BJ9oKsFr+j8YmQB/tuL3VCj?= =?utf-8?q?4w5ng0cXYd939TkPWH8dskMrV5H0cl60+oeZbwe+2ocwgDH6Xw2fiBoecvpym8upL?= =?utf-8?q?A1FjH3rDpsCSZrG0bHb8zdLD+xHHO7uNkhyGe2ckex8mPQRQBsBMPU8=3D?= X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: efd72343-81db-4439-fcea-08dace4b2586 X-MS-Exchange-CrossTenant-AuthSource: VI1PR0701MB3005.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 18:38:57.5381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DJYSgODxf3F1FLpY9BC4LPihLk9rRni59Y/eYB6VRH+46LFPf/4TX7ij09GfStkdnLvqxfP7Wu5YSSrzJRI1OphyXDFGAXVYjYx8vBdt500KEF4UhAW+oQpkpXEgq3y+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6607 X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750404127209877022?= X-GMAIL-MSGID: =?utf-8?q?1750404127209877022?= set_rtc_noop, get_rtc_noop are used runtime, therefore need init removed. Crash was observed on x86 platform where cmos rtc is unused and disabled via device tree. Function was triggered from ntp: sync_hw_clock, although CONFIG_RTC_SYSTOHC=n, however sync_cmos_clock doesn't honour that. Workqueue: events_power_efficient sync_hw_clock RIP: 0010:set_rtc_noop Call Trace: update_persistent_clock64 sync_hw_clock Fix by dropping __init and making set/get_rtc_noop available runtime. Fixes: c311ed6183f4 ("x86/init: Allow DT configured systems to disable RTC at boot time") Reviewed-by: Andy Shevchenko Signed-off-by: Matija Glavinic Pecotic --- v4: Update commit subject and message based on Andy's comments, resend to proper addresses v3: Update commit message based on Andy's comments (further trim to backtrace, proper tag) v2: Update commit message based on Andy's comments arch/x86/kernel/x86_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c index 57353519bc11..0ab707bbefe2 100644 --- a/arch/x86/kernel/x86_init.c +++ b/arch/x86/kernel/x86_init.c @@ -32,8 +32,8 @@ static int __init iommu_init_noop(void) { return 0; } static void iommu_shutdown_noop(void) { } bool __init bool_x86_init_noop(void) { return false; } void x86_op_int_noop(int cpu) { } -static __init int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } -static __init void get_rtc_noop(struct timespec64 *now) { } +static int set_rtc_noop(const struct timespec64 *now) { return -EINVAL; } +static void get_rtc_noop(struct timespec64 *now) { } static __initconst const struct of_device_id of_cmos_match[] = { { .compatible = "motorola,mc146818" },