From patchwork Sat Oct 28 01:31:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Masami Hiramatsu (Google)" X-Patchwork-Id: 159213 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp984903vqb; Fri, 27 Oct 2023 18:32:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFf0nnRNQiDk1mE8wmMvzgwxLZwSDADKHrnwuRfzMjTJvJilwIBoqcCMXBI9TbRJVJjL7gB X-Received: by 2002:a05:6a21:78a5:b0:159:e4ab:15ce with SMTP id bf37-20020a056a2178a500b00159e4ab15cemr5612937pzc.15.1698456769927; Fri, 27 Oct 2023 18:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698456769; cv=none; d=google.com; s=arc-20160816; b=EQKj7P1j64W7uAiMcjs6pIPNQb3jpogBsXzUanXRuzAj8/Y1Ejfq59IT02oBIO1tQE GwN+wOVpgA8MKHa/krbvv4MK5v6XfJ1bgxFAgNxiUfnpL9qAuU6VeBTizJA56Q/x7ft/ HmYCDhu5GSQnuJ9NAIUp6OyG1G2PYQEIhLgbKS0S+XI27rdHdWwC/BXgdbm1je+LCGxZ oitaSZTLFW970CmoMOqAQzgfmo84QJD78qWjp60zvAUkCMAk9qLeeVLtv0OUOMip0I3E jPjPoexXJbIR/UD7FQqz5oRsp8gBrn1xJPJPYpyZXwuuM5SuaMIz1CnjuKFgmGho+NJM EWWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:subject:cc:to:from:dkim-signature; bh=rp90k/HelkTW6KcBHoSxqpDvwaBmW3MyF4O/Lp+1ZSo=; fh=vosOEIJD+PFkocQxJzkb0pF69x0x09bgqchiV1K24k0=; b=lP9oddTrtuqFlxO11wjt6PSbODs1JawwZChjOqAVH7INA3ub066osqtsyMpPvKcqWl AxUorJBa3gh3zPJSAfQIuyCr6z8+iAOx4vc50Kg+ggUESVojuqbav92dJmCl6BUHFiOo uIKfmXftSEZM7sj8GC9mkydlncqJ9daogu+DaZ9LMTFmTGEnsXGb0Yf1CIYS/qpqVK0s vpNob+v0sPEFpgS4qrsr6Rq/n9uNBNc9ibIvcKivsmJ3x+xHKfZxrnmPjrktEOp19dLi LMmwT/IGFPNrqTX1ENu0ROm470RaCfgy7D0OaPXhEtRrwvvi2HyBwKCwLYg7dDkWGvZl BmqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KrNP+nJj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id q207-20020a632ad8000000b005ac154f0feesi1778720pgq.279.2023.10.27.18.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 18:32:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KrNP+nJj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 3E159808494E; Fri, 27 Oct 2023 18:31:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232951AbjJ1Bbe (ORCPT + 27 others); Fri, 27 Oct 2023 21:31:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ1Bbc (ORCPT ); Fri, 27 Oct 2023 21:31:32 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94E1AF0; Fri, 27 Oct 2023 18:31:30 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C174BC433C7; Sat, 28 Oct 2023 01:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698456690; bh=jECE/egUu/Yw0oA6/yd/NwJCk8+qMfbbDsviyOVsKN4=; h=From:To:Cc:Subject:Date:From; b=KrNP+nJjO+I8ev1FvcacHpfxJFl1V5z7OXu8JoxNjBrrRe9o70VGdK+Y/fQVESROa vZl0S0CWccrULB3I/rEtz89qFVI7c411nwv6pWNnhLHz0sovsXwKYXeUvLt7Oie1cL 13Tky8tJPFcblA63mjYpVSUOvMTelnPDSsaXGFxhvrWcAl/s3ugrP6RLpkW5w4Kqra lm8RUEI7EfVjW+WHSw2aVMih86PdWRWUXVQjuBqjWFZ5ALbzo+AK0kx2raODdaqSdi mPbXifLU+PReVY++k5fd26a2/5L3faxac9iomA/5QLhxT6F6OrWNura68XlLXvBu/c G+58TRPdl8RbA== From: "Masami Hiramatsu (Google)" To: "Rafael J . Wysocki" , Pavel Machek , Len Brown Cc: suleiman@google.com, briannorris@google.com, Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2] PM: sleep: Expose last succeeded resumed timestamp in sysfs Date: Sat, 28 Oct 2023 10:31:26 +0900 Message-ID: <169845668624.1319505.1097714089024984847.stgit@mhiramat.roam.corp.google.com> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog User-Agent: StGit/0.19 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 27 Oct 2023 18:31:59 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780961005653286537 X-GMAIL-MSGID: 1780961005653286537 From: Masami Hiramatsu Expose last succeeded resumed timestamp as last_success_resume_time attribute of suspend_stats in sysfs. This timestamp is recorded in CLOCK_MONOTONIC. So user can find the actual resumed time and measure the elapsed time from the time when the kernel finished the resume to the user-space action (e.g. display the UI). Signed-off-by: Masami Hiramatsu (Google) --- Changes in v2: - Use %llu instead of %lu for printing u64 value. - Remove unneeded indent spaces from the last_success_resume_time line in the debugfs suspend_stat file. --- Documentation/ABI/testing/sysfs-power | 10 ++++++++++ include/linux/suspend.h | 2 ++ kernel/power/main.c | 14 ++++++++++++++ kernel/power/suspend.c | 1 + 4 files changed, 27 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-power b/Documentation/ABI/testing/sysfs-power index a3942b1036e2..63659765dee1 100644 --- a/Documentation/ABI/testing/sysfs-power +++ b/Documentation/ABI/testing/sysfs-power @@ -442,6 +442,16 @@ Description: 'total_hw_sleep' and 'last_hw_sleep' may not be accurate. This number is measured in microseconds. +What: /sys/power/suspend_stats/last_success_resume_time +Date: Oct 2023 +Contact: Masami Hiramatsu +Description: + The /sys/power/suspend_stats/last_success_resume_time file + contains the timestamp of when the kernel successfully + resumed from suspend/hibernate. + This floating number is measured in seconds by monotonic + clock. + What: /sys/power/sync_on_suspend Date: October 2019 Contact: Jonas Meurer diff --git a/include/linux/suspend.h b/include/linux/suspend.h index ef503088942d..ddd789044960 100644 --- a/include/linux/suspend.h +++ b/include/linux/suspend.h @@ -8,6 +8,7 @@ #include #include #include +#include #include #ifdef CONFIG_VT @@ -71,6 +72,7 @@ struct suspend_stats { u64 last_hw_sleep; u64 total_hw_sleep; u64 max_hw_sleep; + struct timespec64 last_success_resume_time; enum suspend_stat_step failed_steps[REC_FAILED_NUM]; }; diff --git a/kernel/power/main.c b/kernel/power/main.c index f6425ae3e8b0..5803f6f2a2c2 100644 --- a/kernel/power/main.c +++ b/kernel/power/main.c @@ -421,6 +421,16 @@ static ssize_t last_failed_step_show(struct kobject *kobj, } static struct kobj_attribute last_failed_step = __ATTR_RO(last_failed_step); +static ssize_t last_success_resume_time_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + return sprintf(buf, "%llu.%llu\n", + suspend_stats.last_success_resume_time.tv_sec, + suspend_stats.last_success_resume_time.tv_nsec); +} +static struct kobj_attribute last_success_resume_time = + __ATTR_RO(last_success_resume_time); + static struct attribute *suspend_attrs[] = { &success.attr, &fail.attr, @@ -438,6 +448,7 @@ static struct attribute *suspend_attrs[] = { &last_hw_sleep.attr, &total_hw_sleep.attr, &max_hw_sleep.attr, + &last_success_resume_time.attr, NULL, }; @@ -514,6 +525,9 @@ static int suspend_stats_show(struct seq_file *s, void *unused) suspend_step_name( suspend_stats.failed_steps[index])); } + seq_printf(s, "last_success_resume_time:\t%-llu.%llu\n", + suspend_stats.last_success_resume_time.tv_sec, + suspend_stats.last_success_resume_time.tv_nsec); return 0; } diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index fa3bf161d13f..33334565d5a6 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -622,6 +622,7 @@ int pm_suspend(suspend_state_t state) dpm_save_failed_errno(error); } else { suspend_stats.success++; + ktime_get_ts64(&suspend_stats.last_success_resume_time); } pr_info("suspend exit\n"); return error;