dt-bindings: firmware: versal: add versal-net compatible string

Message ID 1698349328-2321184-1-git-send-email-radhey.shyam.pandey@amd.com
State New
Headers
Series dt-bindings: firmware: versal: add versal-net compatible string |

Commit Message

Pandey, Radhey Shyam Oct. 26, 2023, 7:42 p.m. UTC
  From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>

Add dt-binding documentation for Versal NET platforms.
Versal Net is a new AMD/Xilinx SoC.

The SoC and its architecture is based on the Versal ACAP device.
The Versal Net device includes more security features in the
platform management controller (PMC) and increases the number of
CPUs in the application processing unit (APU) and the real-time
processing unit (RPU).

Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
This usecase also looks similar to versal-net clock upstream compatible
discussion[1], so inline with mainline suggestion i have modified
firmware binding. Also firmware driver can be modified later
on when there is a real SoC specific compatible string need.

[1]: https://lore.kernel.org/all/20230620110137.5701-1-shubhrajyoti.datta@amd.com
---
 .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Krzysztof Kozlowski Oct. 27, 2023, 7:22 a.m. UTC | #1
On 26/10/2023 21:42, Radhey Shyam Pandey wrote:
> From: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> 
> Add dt-binding documentation for Versal NET platforms.
> Versal Net is a new AMD/Xilinx SoC.
> 
> The SoC and its architecture is based on the Versal ACAP device.
> The Versal Net device includes more security features in the
> platform management controller (PMC) and increases the number of
> CPUs in the application processing unit (APU) and the real-time
> processing unit (RPU).
> 
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xilinx.com>
> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
> ---
> This usecase also looks similar to versal-net clock upstream compatible
> discussion[1], so inline with mainline suggestion i have modified
> firmware binding. Also firmware driver can be modified later
> on when there is a real SoC specific compatible string need.
> 
> [1]: https://lore.kernel.org/all/20230620110137.5701-1-shubhrajyoti.datta@amd.com
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
index 822864488dcb..c5483d80ce3c 100644
--- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
+++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
@@ -26,6 +26,12 @@  properties:
       - description: For implementations complying for Versal.
         const: xlnx,versal-firmware
 
+      - description: For implementations complying for Versal NET.
+        items:
+          - enum:
+              - xlnx,versal-net-firmware
+          - const: xlnx,versal-firmware
+
   method:
     description: |
                  The method of calling the PM-API firmware layer.