From patchwork Tue Oct 24 13:20:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 157457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1938082vqx; Tue, 24 Oct 2023 06:23:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnm+y+5yLqiyIMjSRWs8pGQitDb1FGIKa46J0qhx0JBCerrA/nCS00A8WIDOeB98Tp8sYO X-Received: by 2002:a05:6a21:300a:b0:15e:e0fd:98e7 with SMTP id yd10-20020a056a21300a00b0015ee0fd98e7mr2059520pzb.20.1698153785590; Tue, 24 Oct 2023 06:23:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698153785; cv=none; d=google.com; s=arc-20160816; b=gwQmbEniKpUYkm2YUR8/oI3p5RNn+KRKl0RVEXUQfX5F3jZWZOmsNj9psHHjcKf01B tgVz/kCrpo7sOgTLxLlNPMbAIpc3+ajr0c6Y234224P8OjfVQQSzDpUuDqmP428HeTXX UdXd0LF4Txly+ndb4WlznqqKFUWt6k9wyYtVHuTaBljMAzno0T1XzQli4P/uYCj5Gdbt QHwdkoThCx/7Gd7gYoK5fnY8l19YfncK28OSwl+PyLOdAUcyJ91vgFN1Dao8dL8UTQLE Uj8vC8cRwdmbMRg6JBTN3QP2WlPWdd4BY3gak3YBXBl1qzvYqEhe7uTZIkmSzvlTSZC4 bIPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=8ZW+x5+R2o7rfC0WHEPGCf9ASLJX1ELsdyA6Y8UQPp4=; fh=LWlv3U+xZ3+vQt4tlJRIlKl5VzN7iFjjE/bzRmlxKDA=; b=jdL07ptgmrTGj0y8igD0xBzGgqo67MdLtuPQl/HmKzmo51ORuU8fPNGnbajKx9P5lc 6Ks3AD2BFqe8KcbUeG6qHubsRbxStqYM8yrRfr7kBMMB28eUJdobo/WrEdyinyhMTtly FGLWINgXHOo9ZvRsp0aM2wACuRWaIgwim2RyrEe7mGd1j/Z2+z91i4Mw8qbhmUSJK43d WAzJg9iv5LnT/E31P5qVhaGCKPrkqDAz+3WqkYmMUmhQMwcCbE8Ud3vG90eOOh1yrhFw i2SmBPfMtjrCTOft6yBrlE5AU0xxs+PXeIomjEaCCd6XQ0Mwa1gRto6Ml+Ec86K27hgK 3v0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NT7nCNSb; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id om3-20020a17090b3a8300b002792440fc3bsi11469407pjb.185.2023.10.24.06.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 06:23:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=NT7nCNSb; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8DF6B8031D95; Tue, 24 Oct 2023 06:22:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234473AbjJXNW3 (ORCPT + 26 others); Tue, 24 Oct 2023 09:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234617AbjJXNVV (ORCPT ); Tue, 24 Oct 2023 09:21:21 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E6D91712; Tue, 24 Oct 2023 06:21:00 -0700 (PDT) Date: Tue, 24 Oct 2023 13:20:58 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1698153658; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZW+x5+R2o7rfC0WHEPGCf9ASLJX1ELsdyA6Y8UQPp4=; b=NT7nCNSb2e42nHRxlw0MB2fqjH1ef8As0BvAtweFTSLeoOo2ZaMLO7wkyS30lqIWvtMm93 JtbDhrfMM1N3DpMyYywRLi9gkSUUMI9ch/9vvzzGa/BecuX1oMjYwP9ziKI696NR8SpqJd Zo3WdJI+m0OVvm41Yh6KkaicN+3A/1l69TDKI1AteHX7QDOma8Zz9D5lp4kiqy5zHKZXmJ CxabS7/LhAiGxqBA7xE6kGnKtoruUAyjJ+fbSd7ZfG3Tcn9tk78uu82NEm38w8EmA6fyHM j3InhnXDkl6ekqyfEw18eFBJX2ppjtAiiM73QTuNlmtjneUmNeC/+JgZL3Yj7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1698153658; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ZW+x5+R2o7rfC0WHEPGCf9ASLJX1ELsdyA6Y8UQPp4=; b=fqbwbdQCb8PFGZ99yx/8tMLb0tqneOaJ6LuszNz+2IhQhpiRxRGD0HKYj0NGa4t4l8BfJ2 kRsvMY3/EkGaVZDQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169815365810.3135.10571621932502453882.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 06:22:57 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778667764290204326 X-GMAIL-MSGID: 1780643304025328354 The following commit has been merged into the x86/microcode branch of tip: Commit-ID: ba48aa32388ac652256baa8d0a6092d350160da0 Gitweb: https://git.kernel.org/tip/ba48aa32388ac652256baa8d0a6092d350160da0 Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Tue, 24 Oct 2023 15:05:54 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c index 0ed96d2..e306fee 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cpu) static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev = get_cpu_device(cpu); + struct device *dev = get_cpu_device(cpu); microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }