From patchwork Fri Oct 20 11:37:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 156059 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp992365vqb; Fri, 20 Oct 2023 04:42:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEM5DbXqdvMaO2S7Zeh8WijT9dZ2MzdnCm1Rrwe7KkCIc1S9ohaNCKsQCzOUEKlkJ877lbd X-Received: by 2002:a05:6870:698a:b0:1e9:9c34:af67 with SMTP id my10-20020a056870698a00b001e99c34af67mr1822172oab.18.1697802130961; Fri, 20 Oct 2023 04:42:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697802130; cv=none; d=google.com; s=arc-20160816; b=b3elrhwhkOQHfDrLczOoORvsCcDHmNliHaTjwzbJ2WbHqqZrPA+fmUrSIqVaA0ynSN ndEmO71VPPuu1Uwwau6nQgctjsC8tQUnW/ntJuWmGPng2wT/8OBQSFYC4+tJOR9HUKXT BcG5ESZ0ccY4eEqusenpY9QubonCg6zeNBLx2rSzmZifprRIXcdDKATHqm34f3uS2Zor J5sW9Zr22M071vh6VjMn07cJ2aEXm1tc+qQpr7PJmd01tcDLxsCCzLTAliSDPsN0RDH5 F5WSgeF/DtMQNsCfA80nmHtUqHH+xjMa7xRfxxJCv+4Jy1P15v9HDW/HVjPdhMNCsvPZ vc4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=oWLNPxAL6RB4jWe7j4BW9JKrK+K+JTutnur4CH8rKmM=; fh=LWlv3U+xZ3+vQt4tlJRIlKl5VzN7iFjjE/bzRmlxKDA=; b=tnYCHYIEuqmPlyHcZtiZjTruF9Ue55VJoncxh430oQpjD8M+L2V3gaxY+5FXMjVHny HhfJSmEyW/FzKumTeMfNN1/nUomSV8mo1fhvROtmhgPML3OQOODcjkuzbC1vJEsRgov+ azncIzf8Gj5qXSgZr12RXYek3RfR780GsEfyfXzhBVNsZ9/75XOsx40a0RclmqZOpWJ3 55Eg+f4zmhgnZWZJNYanD5VWk7wUK6cj/NE0YKAT5nIbOI9dCnNdL9xQvKA0zCRJohPs dWVyfBoICPttg6YocGuWiZJiipo23fUeLEwDI2g9vC8IiWU7nE/j6J6hzzPDpxSqlh3F 3OVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="Gvj2cJ/1"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id b14-20020a63714e000000b00573fc592e9dsi1527332pgn.848.2023.10.20.04.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 04:42:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="Gvj2cJ/1"; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1586880229D7; Fri, 20 Oct 2023 04:40:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377429AbjJTLjv (ORCPT + 25 others); Fri, 20 Oct 2023 07:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377456AbjJTLjA (ORCPT ); Fri, 20 Oct 2023 07:39:00 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EFC92108; Fri, 20 Oct 2023 04:38:10 -0700 (PDT) Date: Fri, 20 Oct 2023 11:37:52 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1697801873; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWLNPxAL6RB4jWe7j4BW9JKrK+K+JTutnur4CH8rKmM=; b=Gvj2cJ/1KNv8N6SZFVfv1jZQLYcrITN+MS5g9AxvrQfEc+hNd9cjFZs6lmZQYmtZ5iGp8W Vu88PQBMhw1LBGt/0458z/FuYTL2+hvvEksp3I1VikmK56Q11o9sQJSWsaMLASOzCzpaOu 2i4+8TLPpzQk/UeGS9RXtePA6uys880YbPu+iVe+EENyX7geGtHlY/r+Axc55/jshXsHf4 5vdmx6BU8zNvl2UY54AnHE1NSGLIS72BRiMVBsyg8q1jME6WXAES68253xC2TDR093qYny U92GxBwYgD0XX/VT5squ5vOUwsoNyKCDKD3NMiZBdnuHmP2fMAbKwapp5taZKg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1697801873; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oWLNPxAL6RB4jWe7j4BW9JKrK+K+JTutnur4CH8rKmM=; b=puXd1RnAYzg/PpcdGJbfHWwIQMMeCz/9sj3LfC7sW6mWBjuwJayiQejKFnmfW+IjRem3Xm KAnUhWfpaHFfvmDg== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/microcode] x86/microcode: Clean up mc_cpu_down_prep() Cc: Thomas Gleixner , "Borislav Petkov (AMD)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231002115903.028651784@linutronix.de> References: <20231002115903.028651784@linutronix.de> MIME-Version: 1.0 Message-ID: <169780187253.3135.16969663955261216142.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 20 Oct 2023 04:40:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778667764290204326 X-GMAIL-MSGID: 1780274566811737529 The following commit has been merged into the x86/microcode branch of tip: Commit-ID: d91172afa89d1bb7ada97625d761bcdefdd4f9f6 Gitweb: https://git.kernel.org/tip/d91172afa89d1bb7ada97625d761bcdefdd4f9f6 Author: Thomas Gleixner AuthorDate: Mon, 02 Oct 2023 13:59:55 +02:00 Committer: Borislav Petkov (AMD) CommitterDate: Thu, 19 Oct 2023 15:53:58 +02:00 x86/microcode: Clean up mc_cpu_down_prep() This function has nothing to do with suspend. It's a hotplug callback. Remove the bogus comment. Drop the pointless debug printk. The hotplug core provides tracepoints which track the invocation of those callbacks. Signed-off-by: Thomas Gleixner Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de --- arch/x86/kernel/cpu/microcode/core.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c index 0ed96d2..e306fee 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cpu) static int mc_cpu_down_prep(unsigned int cpu) { - struct device *dev; - - dev = get_cpu_device(cpu); + struct device *dev = get_cpu_device(cpu); microcode_fini_cpu(cpu); - - /* Suspend is in progress, only remove the interface */ sysfs_remove_group(&dev->kobj, &mc_attr_group); - pr_debug("%s: CPU%d\n", __func__, cpu); - return 0; }