From patchwork Mon Oct 9 10:26:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 149925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:403:3b70:6f57 with SMTP id x8csp1769053vqo; Mon, 9 Oct 2023 03:27:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkgM2k56glS4tzXqmDc1K7hCwW2/FidbXR1YuW35tI69+mMZuXWw67SflRFS4jVHc06HgR X-Received: by 2002:a05:6a21:6d9f:b0:13a:dd47:c31a with SMTP id wl31-20020a056a216d9f00b0013add47c31amr16560411pzb.20.1696847224492; Mon, 09 Oct 2023 03:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696847224; cv=none; d=google.com; s=arc-20160816; b=l1x0rcrjyOiDRSz5K4U9WfjcK5xI+PiocxKSxkWCxmePcecD8SWjqmVQ+CQWf5v6C1 DHd55wvBbdxyl7HghiBKIIqRrHYu2QrqweREVfWym5BCKQeA80VWuI3fM0iZFe7YcRXF 4swCBuawoq5jhshx7muVCBMzYWeKnFaiBHrfwnxWH5A95vTroGPSRxj5gnn5GRBJi8a6 deYfAwjGNo8PkldadjqmeeboFx+g9D/lxjhtMGaV194ajurIPNdDitajB7k4neOo+aaP FD84JOjFAhDKscgHP4V9JPWXcxsA87AyDTab43tXtxkNM1iX3cvpCVaC9q+s14lXu8UN YeFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=DyXDB2RjMjnG7l+WBXSVkSVvXeO5Nmgyz2NOdWFwmKY=; fh=98PO9cUXyB5KzM7iQQrkqvLNVc4QFHsO4opbmVeOgeo=; b=koD4Y8NBRRVqFkIVp+lwtINxtRx+VcGvfydkzPSAM2EYvA1mp1ZYWf5vHBOj8UUVDv d8ItlRxw8eeZSXJlv4DtGgBOx7vTYlhsMbF38He7a+ExN6pGOp0k6QJj47HWaQ/0cqJA kYDC4hrYw6u60s6ZvzDsQN+JQ772l37le5uZEOA7+8ahR9KRoGY6njCAgAA84Dl1HmqO tpzUbP1t00jPDRfXkuf8k+pN9tKuOdS6JwKTwWfoFia42cOC4oRyg27KHGk6k4Hl25sA vSiUelvR9VIxUpOuy+pVNikJSuS2TE4ojg5XA9GqNhdr6ud6uJExODikAgyC/Or1FKzP vtVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MW5I7ICz; dkim=neutral (no key) header.i=@linutronix.de header.b=y5a7OYLe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id q20-20020a656854000000b005891f64e424si9208385pgt.785.2023.10.09.03.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 03:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=MW5I7ICz; dkim=neutral (no key) header.i=@linutronix.de header.b=y5a7OYLe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 5FF718042A84; Mon, 9 Oct 2023 03:27:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345696AbjJIK0S (ORCPT + 18 others); Mon, 9 Oct 2023 06:26:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234423AbjJIK0P (ORCPT ); Mon, 9 Oct 2023 06:26:15 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EC8B9C; Mon, 9 Oct 2023 03:26:13 -0700 (PDT) Date: Mon, 09 Oct 2023 10:26:10 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1696847171; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyXDB2RjMjnG7l+WBXSVkSVvXeO5Nmgyz2NOdWFwmKY=; b=MW5I7ICzN+/9QF82r4z5i3uxlGEUJV8TKtkNbHdaz8ktv2mXggdRVC8nQ0OTa7pSJtCJmD qnKzhvX4kcPpNhXFHMWRxM3HRdvzTDgl2bOpwSSRnPyTkTJQkdID+xiIyFvt+80mfqV6+T cpUQDDSj3ZMcz4OFag5dsMCvIRvLauuP+4q4qN1vopKMMsUPggJX1v1UCVuNR59Wog2PCX nA8i79ZopR5tQjuywPyVhnTNpQMDm+5zo+2I+OlCcX6hMU7GNLCFFJ6EhmcfXtG7lpL9bP IUDtuBvvi8bZhw2ErBv7R9+nhzBSug6sHjDoLQ+d+hEZyF/35eJqUZv+h5/WtQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1696847171; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DyXDB2RjMjnG7l+WBXSVkSVvXeO5Nmgyz2NOdWFwmKY=; b=y5a7OYLeGt27fEG1i6abYiHZpRvdS79xIc6DWQ5q080az9RhU2pt8vJIGQZkeK8J+EXfZD MAbCxyT+7E3aRnAQ== From: "tip-bot2 for Ingo Molnar" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/nohz: Use consistent variable names in find_new_ilb() and kick_ilb() Cc: Ingo Molnar , "Joel Fernandes (Google)" , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20231006102518.2452758-3-mingo@kernel.org> References: <20231006102518.2452758-3-mingo@kernel.org> MIME-Version: 1.0 Message-ID: <169684717095.3135.11399115758656470787.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 03:27:00 -0700 (PDT) X-Spam-Level: ** X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779001399916719630 X-GMAIL-MSGID: 1779273275576841124 The following commit has been merged into the sched/core branch of tip: Commit-ID: b6dd6984832a2868f78879fce30d6965ae899d02 Gitweb: https://git.kernel.org/tip/b6dd6984832a2868f78879fce30d6965ae899d02 Author: Ingo Molnar AuthorDate: Fri, 06 Oct 2023 12:25:17 +02:00 Committer: Ingo Molnar CommitterDate: Mon, 09 Oct 2023 12:21:23 +02:00 sched/nohz: Use consistent variable names in find_new_ilb() and kick_ilb() Use 'ilb_cpu' consistently in both functions. Signed-off-by: Ingo Molnar Reviewed-by: Joel Fernandes (Google) Link: https://lore.kernel.org/r/20231006102518.2452758-3-mingo@kernel.org --- kernel/sched/fair.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2b63a14..f82b301 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11514,18 +11514,18 @@ static inline int on_null_domain(struct rq *rq) */ static inline int find_new_ilb(void) { - int ilb; const struct cpumask *hk_mask; + int ilb_cpu; hk_mask = housekeeping_cpumask(HK_TYPE_MISC); - for_each_cpu_and(ilb, nohz.idle_cpus_mask, hk_mask) { + for_each_cpu_and(ilb_cpu, nohz.idle_cpus_mask, hk_mask) { - if (ilb == smp_processor_id()) + if (ilb_cpu == smp_processor_id()) continue; - if (idle_cpu(ilb)) - return ilb; + if (idle_cpu(ilb_cpu)) + return ilb_cpu; } return nr_cpu_ids;