[tip:,locking/core] futex/requeue: Remove unnecessary ‘NULL’ initialization from futex_proxy_trylock_atomic()
| Message ID | 169643577653.3135.1339527957884113798.tip-bot2@tip-bot2 |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:254a:b0:403:3b70:6f57 with SMTP id
hf10csp241489vqb;
Wed, 4 Oct 2023 09:09:48 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHaCiNlFeAQjrM6bmljDW/sDaLLxngo0e7NO24BcIAyi/UCM1r3tFsTL+hm9g1x/7XcBGK5
X-Received: by 2002:a05:6358:4297:b0:135:57d0:d173 with SMTP id
s23-20020a056358429700b0013557d0d173mr2802339rwc.20.1696435788598;
Wed, 04 Oct 2023 09:09:48 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1696435788; cv=none;
d=google.com; s=arc-20160816;
b=JVR88MBcMpaaFeIY/61mdL6AdJBd6iFssLw13nMBPXGyrQ4S6fem1Ey6FmtePBtvQh
/QvVheYTR1sz3VmzuKrBbwcjSZ0XGlg9AboFFvRIq336/9RSVGT0ah/Yxv3eauqEG3Yo
XCEmw3NVtWFgppgQxWukwj5dtl5Mgcax3GS/atJj9y89NiKpKnMEXfA6IN3JLNh29HeT
9eeXRdFX/qcJp9BbRGwSzJ6XFZJHUk+4QkCJuZgj06fJRJ7L4IxRLCxOV9D7aKCkKGjI
W0ElzutDdX54y2/k1pl3gIH3rShcVjMODsX4GMv86l7v991ZrjjrZ/ZHExZDLjXxEhty
bsDQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:robot-unsubscribe
:robot-id:message-id:mime-version:references:in-reply-to:cc:subject
:to:reply-to:sender:from:dkim-signature:dkim-signature:date;
bh=tco2oLrQfsIAEtlgl8Nce5/Ay0Sr42yRCzzDGiBrR/Q=;
fh=caeQzssjWoCqvfJEgbZ/hQjkbGoQYdHqE3UvgyfpGiE=;
b=IggxYZRk7X104Dj6kfhPO1TYEV3SvH0YAFyyz/EzRr8Xor6y+k9H5Jxup+znsI8pr4
n6yePjC0efsDGsNEYBP3YGc4NkTGWFuvcI3VAhvJDVBAuPoeEOdaiwdWIREi4anA2Iia
XvQmI+68slxLRmS+AYuLDClzwi3bnFhSEFk5O0ohKtQiPtK/4ExCwgHUB9ETUpZ2VMlF
bWyS+pMookHMcWbPhf8uXolsySNfhomvGjUxCB2WccGCcs7yp/BDyPgLFMTw3RWByLH2
jAj/V96i11OblPGM/zKO9UH7Wul0xx1x1YSD8314fUEKRANCLA2hXI25CcWL7slLk3uu
CdvA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linutronix.de header.s=2020 header.b=xmvEdK1L;
dkim=neutral (no key) header.i=@linutronix.de header.s=2020e
header.b=+JlsNjIz;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: from snail.vger.email (snail.vger.email. [23.128.96.37])
by mx.google.com with ESMTPS id
139-20020a630091000000b00565e01815f2si4031147pga.732.2023.10.04.09.09.47
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 04 Oct 2023 09:09:48 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linutronix.de header.s=2020 header.b=xmvEdK1L;
dkim=neutral (no key) header.i=@linutronix.de header.s=2020e
header.b=+JlsNjIz;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.37 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by snail.vger.email (Postfix) with ESMTP id 0ECE9802A546;
Wed, 4 Oct 2023 09:09:47 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S233707AbjJDQJq (ORCPT <rfc822;ezelljr.billy@gmail.com>
+ 19 others); Wed, 4 Oct 2023 12:09:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44182 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S233451AbjJDQJo (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 4 Oct 2023 12:09:44 -0400
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A967ABF;
Wed, 4 Oct 2023 09:09:38 -0700 (PDT)
Date: Wed, 04 Oct 2023 16:09:36 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
s=2020; t=1696435777;
h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=tco2oLrQfsIAEtlgl8Nce5/Ay0Sr42yRCzzDGiBrR/Q=;
b=xmvEdK1LeY9SnwT0MxVzAbsXBO2w3pW80AydelL8KdlB3VIcFO0h4vp1qnAm+uTUW4rqAM
89wIXdF9Al3SiNX3EYp3PCL2yV5IPI1vQiKPOkrHvRsH5NTJSbMVjbEIBMTKChYHaAhPcx
ynlLS1iG9ao77IUB+6n9S0V3YKwWriYte/Q5l2GrAiRVvAe8GXnsH9uVEmqQtVo+AmVLle
iDoihTnilhO76HcgxsQQWdaS8erieWBOrLpfH99fsyiyxq6PkuCMRUHWMWwMV+9dKnTqxM
34nZTdrdzIjX0BCabwSVhWFAQP7xbndrgRrBQPYymHchc9BVwJdksqQBOjSzXQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
s=2020e; t=1696435777;
h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=tco2oLrQfsIAEtlgl8Nce5/Ay0Sr42yRCzzDGiBrR/Q=;
b=+JlsNjIzx0e3wu1n2YiM46cZY6K2of5+o37DGo6vsQpyOJF7zV3AdgHGIwREsrUmX9K5xm
csiA0CGqmk8XbCAQ==
From: "tip-bot2 for Li zeming" <tip-bot2@linutronix.de>
Sender: tip-bot2@linutronix.de
Reply-to: linux-kernel@vger.kernel.org
To: linux-tip-commits@vger.kernel.org
Subject: [tip: locking/core] futex/requeue: Remove unnecessary
=?utf-8?b?4oCYTlVMTOKAmQ==?= initialization from futex_proxy_trylock_atomic()
Cc: Li zeming <zeming@nfschina.com>, Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20230725195047.3106-1-zeming@nfschina.com>
References: <20230725195047.3106-1-zeming@nfschina.com>
MIME-Version: 1.0
Message-ID: <169643577653.3135.1339527957884113798.tip-bot2@tip-bot2>
Robot-ID: <tip-bot2@linutronix.de>
Robot-Unsubscribe: Contact <mailto:tglx@linutronix.de> to get blacklisted from
these emails
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]);
Wed, 04 Oct 2023 09:09:47 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1778841853544346108
X-GMAIL-MSGID: 1778841853544346108
|
| Series |
[tip:,locking/core] futex/requeue: Remove unnecessary ‘NULL’ initialization from futex_proxy_trylock_atomic()
|
|
Commit Message
tip-bot2 for Thomas Gleixner
Oct. 4, 2023, 4:09 p.m. UTC
The following commit has been merged into the locking/core branch of tip: Commit-ID: 01a99a750a4f414c221781de2e5570e0ceae04b5 Gitweb: https://git.kernel.org/tip/01a99a750a4f414c221781de2e5570e0ceae04b5 Author: Li zeming <zeming@nfschina.com> AuthorDate: Wed, 26 Jul 2023 03:50:47 +08:00 Committer: Ingo Molnar <mingo@kernel.org> CommitterDate: Wed, 04 Oct 2023 18:04:47 +02:00 futex/requeue: Remove unnecessary ‘NULL’ initialization from futex_proxy_trylock_atomic() 'top_waiter' is assigned unconditionally before first use, so it does not need an initialization. [ mingo: Created legible changelog. ] Signed-off-by: Li zeming <zeming@nfschina.com> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20230725195047.3106-1-zeming@nfschina.com --- kernel/futex/requeue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/futex/requeue.c b/kernel/futex/requeue.c index a0a7995..16a3645 100644 --- a/kernel/futex/requeue.c +++ b/kernel/futex/requeue.c @@ -269,7 +269,7 @@ futex_proxy_trylock_atomic(u32 __user *pifutex, struct futex_hash_bucket *hb1, union futex_key *key2, struct futex_pi_state **ps, struct task_struct **exiting, int set_waiters) { - struct futex_q *top_waiter = NULL; + struct futex_q *top_waiter; u32 curval; int ret;