From patchwork Thu Sep 14 05:43:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tao Zhang X-Patchwork-Id: 139544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp312951vqi; Thu, 14 Sep 2023 05:32:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgUBooGGtyJiYRg23dItYmlnaoxrnRKVjPnNyeW5mxWN92+kHqwfvrZz8WbuRfm+OeiUow X-Received: by 2002:a17:90b:e03:b0:268:c5c7:f7f1 with SMTP id ge3-20020a17090b0e0300b00268c5c7f7f1mr4531747pjb.29.1694694739655; Thu, 14 Sep 2023 05:32:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694694739; cv=none; d=google.com; s=arc-20160816; b=LDXhXUHXZ5BxFeMLdImus6Pyz79XRP9ig7czl/CJCK6mGEOgR9xMGN1DaGL97vsEcu Wi1KJv44cnGtBPpNEgWQxsOrBp3s0q4VhZb4pBGgLPDuITJ2dQpTQrGKJ4xPQRfofvcG PvT8pW9XXp1qPiJfm/8jH75ssHg3f2pDDUTYLVv7zA/+LNyrW8f5TTJaG+0HHlUGQVmF RVpkXUDf24KwaAvSMj80wX4knIpmTEfvXqisNpap8Cjovc747os1wyO3nAL1eCrI8aek 6SQKvWkBMgGHLVp9NlDBgiNzQX3C7eJHKT5tlQjVUeKA9Lfu1HIoAtLZEmkleg9ixKxC fOpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2+FYJqvd8KPGLBxHJyZuzJMgY6Vqc6U1VDQqXT1I4S0=; fh=n/cywDBrV54XLbQm/aXN5C7dSeQ+T0voxuinVQDvrSM=; b=LWV+wRQLdoXV/siucJxGe/uaUSSp43rglWVV3kqYN4SZLYYbiqL+6jND+HXkwE+YzN aVQhpviTbH5+JFzaTMBfgprcBlXPYWpzcYliD4PMM6UJodMXdUG2z2vZL9M/OvgYjBfA 4dDfmdY/0sOn1B4myS7toCdbx9NafIzryOb2imMcM2DKDrnUhWrQqo6D88Gl0i15Xwrd b5ae9NctOp0HzLuGmgBqCacOR5alHPt4UAEh0llSDfIrUWTFg3U5P8/cxnVayrCe2USU 6rDRWaPCOv8iTUV9Brb2KKMleLYxfqUVp8e+lzN6sjjCup9EaqtQ6ROx3NKcBqOB6gEt vIaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=L9mcCiOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id ne16-20020a17090b375000b0026b36c6355csi3561352pjb.187.2023.09.14.05.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 05:32:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=L9mcCiOI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E71BD82B928F; Wed, 13 Sep 2023 22:44:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235016AbjINFoh (ORCPT + 35 others); Thu, 14 Sep 2023 01:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234944AbjINFoa (ORCPT ); Thu, 14 Sep 2023 01:44:30 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9E8FBB; Wed, 13 Sep 2023 22:44:26 -0700 (PDT) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38E5XDtv027831; Thu, 14 Sep 2023 05:44:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=2+FYJqvd8KPGLBxHJyZuzJMgY6Vqc6U1VDQqXT1I4S0=; b=L9mcCiOIdgTQo/mT8KH97iMgLoiq7kHV63ijEl2S8iT63pIRrbsd9Zq5ZGWXFfjtkvOJ P7ROS0xnYoHC8WFeQEU3FLVap2ob33itMEZ8lDUghjjOQ1KPDjoPlp3AVei9VLagdnu5 UK1akjsQNcsnNplejp5PzMgRDReKg9mXe7WDi+nV2YGzTdETb7I0f6dE9zvkwPHgfmfg GCUZDH9rmgFkbH/lOn3Sot0CBqswJvlVMG030pZtBANNzwJsEZHiJWSC31ZR93z1IHBw c04IvOJansHExL9rYl1OzGV3xGsR95rrFmyZRp0ZXgH/BA5KxlG5qSb3ltpsWomJsQDm dw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t3v4h80q3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 05:44:07 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38E5hucX013690 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Sep 2023 05:43:56 GMT Received: from taozha-gv.qualcomm.com (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 13 Sep 2023 22:43:51 -0700 From: Tao Zhang To: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , Konrad Dybcio , Mike Leach , Rob Herring , Krzysztof Kozlowski CC: Tao Zhang , Jinlong Mao , Leo Yan , Greg Kroah-Hartman , , , , , Tingwei Zhang , Yuanfang Zhang , Trilok Soni , Hao Zhang , , Subject: [PATCH v9 01/13] coresight-tpdm: Remove the unnecessary lock Date: Thu, 14 Sep 2023 13:43:12 +0800 Message-ID: <1694670204-11515-2-git-send-email-quic_taozha@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1694670204-11515-1-git-send-email-quic_taozha@quicinc.com> References: <1694670204-11515-1-git-send-email-quic_taozha@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: z0RwEls5dI1s7eVerMYmmx3NJ0Nvdw4t X-Proofpoint-GUID: z0RwEls5dI1s7eVerMYmmx3NJ0Nvdw4t X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-14_03,2023-09-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309140050 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 22:44:42 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777016231501669116 X-GMAIL-MSGID: 1777016231501669116 Remove the unnecessary lock "CS_{UN,}LOCK" in TPDM driver. This lock is only needed while writing the data to Coresight registers. Signed-off-by: Tao Zhang --- drivers/hwtracing/coresight/coresight-tpdm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c index f4854af..b645612 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -114,11 +114,9 @@ static void tpdm_init_default_data(struct tpdm_drvdata *drvdata) { u32 pidr; - CS_UNLOCK(drvdata->base); /* Get the datasets present on the TPDM. */ pidr = readl_relaxed(drvdata->base + CORESIGHT_PERIPHIDR0); drvdata->datasets |= pidr & GENMASK(TPDM_DATASETS - 1, 0); - CS_LOCK(drvdata->base); } /*