From patchwork Mon Aug 21 08:36:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jing Zhang X-Patchwork-Id: 136371 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp2913783vqi; Mon, 21 Aug 2023 03:46:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9nFKQZshOrz5Hp3cM8zjbzG5TaR4BIUpAfn/kcAGHZLpTszDqQZ4n3Nym4JDQAhraqVbR X-Received: by 2002:a17:90b:11cd:b0:25c:18ad:6b82 with SMTP id gv13-20020a17090b11cd00b0025c18ad6b82mr9379798pjb.21.1692614801647; Mon, 21 Aug 2023 03:46:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692614801; cv=none; d=google.com; s=arc-20160816; b=gxPUaSD2/MDrA4pkSWp10qna9GGouxOKNm9COkSt1VeMMg/5yAXLoFqdD2ziHQVOff uYlVHcw7ALe7MYXLKQmZsXPSNKm30Wkd+OXIszxHDb/FR3bILx9rsk9l4vBxJwpnG0w/ tuYeC1rnHP5xAvLrdGtidirUABFxnkFSPQQj5QyItDyT+vO5NXeaKRLH9fwvP1yfIdoc 55bKp6LSoR24dWppSfwJ1U1Sx3PuVKZnvuZcqxoB3SLjyEpTS3Ma3ISCxlbQvrEF4jo3 w6+Gd+vPbWY9uCPiH3aBPGoUxmnP+f34oQmn/pTasGyEgLNzSb7kfpeKeXdiQqKxVAlt ksKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=lQHIc2+NtE9PIa+Qpna2QOL4nyMq9WTbopBBbtzVgnY=; fh=7pF9AUGuuVLtftwWy2EJKaooMcBit4LAHr6bHM40jlQ=; b=ZimnEc81AmTTJJul50JOa6f/5AWkK2OF8//V/U5KFCg/JUcBZdTcCjzu/xpi8eTAXg uSAc9XcnD7z2FkljO0aNPfSxbRhvhXbQk+tLdtPnP1UF0OrAS8ObhYFTnwaw8b4gDiVX aP5ZOVTA5f77oJOgm1F5HcQUgLsksAaDdvG54d8l3RLjyxnVambNXkte6q5ejekaadfJ V7KlJQcovDOgU/+ysNu5/hTbjk2SGls/VjIMCG55IHPSTThh2qwqI4WiUyPrBmbd+PEE RpjlVxKALo21rylLssw1B3ecSzCmK3lX/GQETA1b3jD/fsuqsq8ydD6yIVUh5Ald+ED1 L+UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r21-20020a17090aa09500b0026d0d197d53si8238355pjp.189.2023.08.21.03.46.28; Mon, 21 Aug 2023 03:46:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234065AbjHUIgm (ORCPT + 99 others); Mon, 21 Aug 2023 04:36:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234043AbjHUIgg (ORCPT ); Mon, 21 Aug 2023 04:36:36 -0400 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 445EABB; Mon, 21 Aug 2023 01:36:34 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VqEq8D0_1692606989; Received: from srmbuffer011165236051.sqa.net(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VqEq8D0_1692606989) by smtp.aliyun-inc.com; Mon, 21 Aug 2023 16:36:30 +0800 From: Jing Zhang To: John Garry , Ian Rogers Cc: Will Deacon , James Clark , Arnaldo Carvalho de Melo , Mark Rutland , Mike Leach , Leo Yan , Namhyung Kim , Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Jiri Olsa , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Jing Zhang , Shuai Xue Subject: [PATCH v7 4/8] perf jevents: Support more event fields Date: Mon, 21 Aug 2023 16:36:13 +0800 Message-Id: <1692606977-92009-5-git-send-email-renyu.zj@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1692606977-92009-1-git-send-email-renyu.zj@linux.alibaba.com> References: <1692606977-92009-1-git-send-email-renyu.zj@linux.alibaba.com> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774835258182439280 X-GMAIL-MSGID: 1774835258182439280 The previous code assumes an event has either an "event=" or "config" field at the beginning. For CMN neither of these may be present, as an event is typically "type=xx,eventid=xxx". If EventCode and ConfigCode is not added in the alias JSON file, the event description will add "event=0" by default. So, even if the event field is added "eventid=xxx" and "type=xxx", the CMN events final parsing result will be "event=0, eventid=xxx, type=xxx". Therefore, when EventCode and ConfigCode are missing in JSON, "event=0" is no longer added by default. And add EventIdCode and Type to the event field. I compared pmu_event.c before and after compiling with JEVENT_ARCH=all, they are consistent. Signed-off-by: Jing Zhang --- tools/perf/pmu-events/jevents.py | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py index f57a8f2..369c8bf 100755 --- a/tools/perf/pmu-events/jevents.py +++ b/tools/perf/pmu-events/jevents.py @@ -275,11 +275,14 @@ class JsonEvent: } return table[unit] if unit in table else f'uncore_{unit.lower()}' - eventcode = 0 + eventcode = None if 'EventCode' in jd: eventcode = int(jd['EventCode'].split(',', 1)[0], 0) if 'ExtSel' in jd: - eventcode |= int(jd['ExtSel']) << 8 + if eventcode is None: + eventcode = int(jd['ExtSel']) << 8 + else: + eventcode |= int(jd['ExtSel']) << 8 configcode = int(jd['ConfigCode'], 0) if 'ConfigCode' in jd else None self.name = jd['EventName'].lower() if 'EventName' in jd else None self.topic = '' @@ -317,7 +320,11 @@ class JsonEvent: if precise and self.desc and '(Precise Event)' not in self.desc: extra_desc += ' (Must be precise)' if precise == '2' else (' (Precise ' 'event)') - event = f'config={llx(configcode)}' if configcode is not None else f'event={llx(eventcode)}' + event = None + if eventcode is not None: + event = f'event={llx(eventcode)}' + elif configcode is not None: + event = f'config={llx(configcode)}' event_fields = [ ('AnyThread', 'any='), ('PortMask', 'ch_mask='), @@ -327,10 +334,15 @@ class JsonEvent: ('Invert', 'inv='), ('SampleAfterValue', 'period='), ('UMask', 'umask='), + ('NodeType', 'type='), + ('EventIdCode', 'eventid='), ] for key, value in event_fields: if key in jd and jd[key] != '0': - event += ',' + value + jd[key] + if event: + event += ',' + value + jd[key] + else: + event = value + jd[key] if filter: event += f',{filter}' if msr: