From patchwork Fri Aug 4 05:33:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Kent X-Patchwork-Id: 130976 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:44a:b0:3f2:4152:657d with SMTP id ez10csp63900vqb; Thu, 3 Aug 2023 23:26:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6SUvo+hP92UAAuT2YccdLS29AaGX6VPHyfk9kW2rhk021+i+rPmUJtvSnHnLnrO4XNsYY X-Received: by 2002:ac2:5b5a:0:b0:4fd:fad6:5495 with SMTP id i26-20020ac25b5a000000b004fdfad65495mr519637lfp.18.1691130418563; Thu, 03 Aug 2023 23:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691130418; cv=none; d=google.com; s=arc-20160816; b=iWpTuxCfsBT3S+VIIqMhYmygWc8foojOc/ETVdXoQDJcQN07rBeeE8IhzVfjwfYfKM PZiE74OfwnTbDjrfJkbGHl4ol0/yKlww7dr5AUoLQqoSNBpKxV0rCkPLjHtBVgYht3Cj QJcmXiOs+zjIICc+eWBnuHii+cPaCZuacvMLz2UvZRS/kKcH3MJHuVL90OHEnuv/wIc6 hGaf96v/xA+Myda1YLd5akfvewUvJgG4khkWrpZzy2+ohQJ+X5IFA1xdiha6aevQts2A SYQlJ2y66d/QYQVxg+4z/trPj26w/PP3TPE7aLlEXNnbSN8q1plMDzxInsOvjHixSFuO /zMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=tttNzxnECBEGpOtOcBmMYNeXtvARAwVnw39wqL41p6Q=; fh=HyMFn70SBfxcLdBFbfHTPsucKGij4W5w+6oBv1I/GOk=; b=KA1LBWhZ/sL1VNsEmLbgooIkTqFiuAV7NPZGUFqhTwdG4Mht41EhCkGqSFrrZ97xEv 192uibL0nnlNRjdA8PqLAEgmEcBvLeRgGyignmkHH4FBCheXCvK/LKEiphd6gRUJdH5T KeVjGPHsVxCCj61uTtu+dZ4uKvVpPoV8Hg3NNqZwQoCdRPdFba+ca+R6Y5HW+dKR7f+O mb0W2HoJ5dplz4BJjECL7/1vdoHIIF83D6q02DzVtRdw9uXewDZOt9DYzjjTy5q4T4V2 pSHdmhx1dXP2/u7BgogsbQc3aZNI0Z8zFCaWTVSMn61rSCfYSi6ssFVB94UBuSkalNzd Osmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a50ec8f000000b0052228ec4a89si1089038edr.65.2023.08.03.23.26.34; Thu, 03 Aug 2023 23:26:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231951AbjHDFkQ (ORCPT + 99 others); Fri, 4 Aug 2023 01:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbjHDFkK (ORCPT ); Fri, 4 Aug 2023 01:40:10 -0400 Received: from smtp01.aussiebb.com.au (smtp01.aussiebb.com.au [121.200.0.92]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97688E46; Thu, 3 Aug 2023 22:40:05 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp01.aussiebb.com.au (Postfix) with ESMTP id 6CB371015A9; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) X-Virus-Scanned: Debian amavisd-new at smtp01.aussiebb.com.au Received: from smtp01.aussiebb.com.au ([127.0.0.1]) by localhost (smtp01.aussiebb.com.au [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3WRgSlxFvley; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) Received: by smtp01.aussiebb.com.au (Postfix, from userid 116) id 61AD71015A4; Fri, 4 Aug 2023 15:33:19 +1000 (AEST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from donald.themaw.net (2403-580e-4b40-0-7968-2232-4db8-a45e.ip6.aussiebb.net [IPv6:2403:580e:4b40:0:7968:2232:4db8:a45e]) by smtp01.aussiebb.com.au (Postfix) with ESMTP id 746C2101592; Fri, 4 Aug 2023 15:33:18 +1000 (AEST) Subject: [PATCH 2/2] autofs: use wake_up() instead of wake_up_interruptible(() From: Ian Kent To: Al Viro , Christian Brauner Cc: autofs mailing list , linux-fsdevel , Kernel Mailing List , Fedor Pchelkin , Takeshi Misawa , Alexey Khoroshilov , Matthew Wilcox , Andrey Vagin Date: Fri, 04 Aug 2023 13:33:18 +0800 Message-ID: <169112719813.7590.4971499386839952992.stgit@donald.themaw.net> In-Reply-To: <169112719161.7590.6700123246297365841.stgit@donald.themaw.net> References: <169112719161.7590.6700123246297365841.stgit@donald.themaw.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773278769371827571 X-GMAIL-MSGID: 1773278769371827571 In autofs_wait_release() wake_up() is used to wake up processes waiting on a mount callback to complete which matches the wait_event_killable() in autofs_wait(). But in autofs_catatonic_mode() the wake_up_interruptible() was not also changed at the time autofs_wait_release() was changed. Signed-off-by: Ian Kent --- fs/autofs/waitq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/autofs/waitq.c b/fs/autofs/waitq.c index efdc76732fae..33dd4660d82f 100644 --- a/fs/autofs/waitq.c +++ b/fs/autofs/waitq.c @@ -32,7 +32,7 @@ void autofs_catatonic_mode(struct autofs_sb_info *sbi) wq->status = -ENOENT; /* Magic is gone - report failure */ kfree(wq->name.name - wq->offset); wq->name.name = NULL; - wake_up_interruptible(&wq->queue); + wake_up(&wq->queue); if (!--wq->wait_ctr) kfree(wq); wq = nwq;