From patchwork Fri Jul 28 08:21:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 127429 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp293580vqg; Fri, 28 Jul 2023 01:58:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlFxgQMNPicvSlUFWyBUzD11E7GdvHHVmuN48s4nRIJ3VTISLTnqJq7v5aHOrEth5btX/hgQ X-Received: by 2002:a17:907:9621:b0:992:103c:43fa with SMTP id gb33-20020a170907962100b00992103c43famr6262519ejc.30.1690534695484; Fri, 28 Jul 2023 01:58:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690534695; cv=none; d=google.com; s=arc-20160816; b=UCrb+5gFpBdxLlMerw9M7RSREN0RbopMpTpmrLEto8VPlTaWeBsh9k4FY5yFDvFx8K GnpBIkZYIWCaoeeCar1+azaxfwoaEynRPbPvjQ2bQZxBOlU515Y5lgltuH++WF8hy3DJ 09u9NuZOn3JqbKPUZghk0q7XQ4NFbatTb+CBUZHlXlkVxwpTh3kox9lgGZndWaWEH4Bq 42wUyRw5HOi33JF6+s2/eUIltWyb1r7fPIziqBsGgmsaDCzsoIfEKQw5SF5X+Bscnw5f lJKgNFVWR4K0mUZzftItMOemoiiaMKhyb4Gd6dl/Qk/YxE7RoSuqSuo2YUZSDFi8Z0DB 00lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=vbdquQpgk4n9HAlhi8cxuSh9d1y+3JXXGaBXsoEW6M8=; fh=x7LrESRZSncmuzg71q80qTubzaARBhqhhTJQojIQNbY=; b=ZvodomYlesmu0tbGqDDPFQLc9MHoBDIepHFYjfoR/HjZ6/nQwvu/KCrATF3UMdxYaU wZi8UB76sV429ZanMF+pgxDPteDkwa2kdWWZLHB6mSxjwRFcYpxUlsirqjHX7fw77Nyw REHV6635VH7+50+jkxEbdMz/6obmCzVoBpbzT+61O3k2ZkIPhG692gvAKQ9RbGtz87qo EmT4E10HVGBir5ZC9LdZWTlrJP6vHceAkaRHQCPE+GXjtP8JwILwk9oxpirvgLwYbioD 2H5EPqm9l9dt/4gK0Rlp42czK8xFUGng/hEizmZetBp6MSo9yyseQmltX6huXLMWA3SD PFmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Trr2qBEv; dkim=neutral (no key) header.i=@linutronix.de header.b="Y3iS/tHZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rl19-20020a170907217300b00988f21df36esi2453131ejb.594.2023.07.28.01.57.51; Fri, 28 Jul 2023 01:58:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=Trr2qBEv; dkim=neutral (no key) header.i=@linutronix.de header.b="Y3iS/tHZ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234877AbjG1IXf (ORCPT + 99 others); Fri, 28 Jul 2023 04:23:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234938AbjG1IW3 (ORCPT ); Fri, 28 Jul 2023 04:22:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3C2030E0; Fri, 28 Jul 2023 01:21:23 -0700 (PDT) Date: Fri, 28 Jul 2023 08:21:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1690532482; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbdquQpgk4n9HAlhi8cxuSh9d1y+3JXXGaBXsoEW6M8=; b=Trr2qBEvMeNW9Z5IQJBYeFH15nBJOfRtkqFYsdxe2VAXvo1rjO34EbQjEen8wtL99T/S/4 2R34RAoEu64Y3zvaSumjoXEnb42qaGsKCvWcUwfg8YuH3r2t8FVRChY2XB3bIfUwPe5wZC 6dt2+ZsgfSuSV3lOJB46vQOX1iPBh0Sf2B0d006q3lai25ciG93GuLNgVYBLdCgJgBA3GI TieCzbWe/uuc23h9sNOJ4eNJIE7MgpZO4vbM71kr3x3owv0rHzGjQRNttGiPOXlQBWFpZe N/EbtLiWFaetLMuNNGwojQI5eM6t4hlEg+GM7V37XGUjakzFbXRvKeqmEmQeUQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1690532482; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vbdquQpgk4n9HAlhi8cxuSh9d1y+3JXXGaBXsoEW6M8=; b=Y3iS/tHZFLUGSj6hh4K5M0cD6iIhULH3haEVQ5j/p9oN8agKAh2cOX/8arOHVXU+JMUM0P nvOG3hWE+f6nN3Bw== From: "tip-bot2 for Sohil Mehta" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: x86/core] x86/smpboot: Remove a stray comment about CPU hotplug Cc: Sohil Mehta , Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230727180533.3119660-2-sohil.mehta@intel.com> References: <20230727180533.3119660-2-sohil.mehta@intel.com> MIME-Version: 1.0 Message-ID: <169053248168.28540.18322875262543490504.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772602672358442687 X-GMAIL-MSGID: 1772654109209350422 The following commit has been merged into the x86/core branch of tip: Commit-ID: 52defa4a5e719a57992aed52c8d3e214e75ac276 Gitweb: https://git.kernel.org/tip/52defa4a5e719a57992aed52c8d3e214e75ac276 Author: Sohil Mehta AuthorDate: Thu, 27 Jul 2023 18:05:31 Committer: Thomas Gleixner CommitterDate: Fri, 28 Jul 2023 10:17:53 +02:00 x86/smpboot: Remove a stray comment about CPU hotplug This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.com --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd..6a09a02 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); }