From patchwork Thu Jun 29 22:09:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: longli@linuxonhyperv.com X-Patchwork-Id: 114461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9947718vqr; Thu, 29 Jun 2023 15:18:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlF76tleXdK3r4L8Bx3O+kD2q2MUhHgA/d7CucNNzVPU7KO0BIghe7EYok7R9n6GjT7obGd6 X-Received: by 2002:a05:6a00:138a:b0:675:8521:ddc7 with SMTP id t10-20020a056a00138a00b006758521ddc7mr1371163pfg.0.1688077098708; Thu, 29 Jun 2023 15:18:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688077098; cv=none; d=google.com; s=arc-20160816; b=ScScUjFSZFbXomFnulkGj/8V8cTsEMl4DjEt6aedKz8AKv3IhcGs+jQnIw4npQkuci vWScPjkVRqkydbafYExl5m5nOBNXgj5BRKVAZKIUSgNvUhjOjtwzGO+eFqX5HERXFfxe B5VEGfXB4yGOkkQ9mzwtCe+n5TczRL9KyKr3gqI0aB8xtTGWinyi/I4x2qin8pKXEBUo 9mqhD75aMNUlHhTYJPRtpbblJRFjYZATqAucxK6Dua9a+quhDOyoUp1gGnBCbIh43RSb UVXA/6k2rMSWmO2O4u/gq+C0Aig/kLDNM+D3lyAgBHy5QVdJz6x2AA45D4QnCG7hE0cD iT7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature:dkim-filter; bh=sNVCTU5gFBqe2BQjTeFzfJALosLnCbsvG4CoTL1NyEs=; fh=YiLWLbt9AyPVMVZuk1otT49UqAfek5CAeZ4PLLtfDgc=; b=z1JXlv/N+8ipYg6ZdyOvRpcIOULYMegNf/A59ZAkViW3KAVkCvgKgrZBIyeYApRuqE DiBDEpI4PXgMPiBKTzaumDAousql1+010obI0bDflyExkp+FvdyflHfWybSdfa1d3cDw QaLyyb/LU8qYyicEMVweFXqG+1e7KLA84rVp9Xph2BQ7Kpuy1HP31C09gRT1Nk80pYXp KDXxFDoeeC++WYOmpXcSLGFesqDXfSYH59uw7WWJTqdN0bi3pnX5Pzo6ZXpXl8JZUy0X 4vSYjQtYUdFLuGkqPUQnkeaA18wW6cuza3yKxpcgefEqHmoCjdh+GaOrjSkXZ9tu3X0q yxlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxonhyperv.com header.s=default header.b=FDaBTtSq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxonhyperv.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o3-20020a056a0015c300b0067a39a4c12bsi7271094pfu.81.2023.06.29.15.18.04; Thu, 29 Jun 2023 15:18:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxonhyperv.com header.s=default header.b=FDaBTtSq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxonhyperv.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232316AbjF2WKF (ORCPT + 99 others); Thu, 29 Jun 2023 18:10:05 -0400 Received: from linux.microsoft.com ([13.77.154.182]:41696 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230012AbjF2WJ5 (ORCPT ); Thu, 29 Jun 2023 18:09:57 -0400 Received: by linux.microsoft.com (Postfix, from userid 1004) id 20A7220AECAD; Thu, 29 Jun 2023 15:09:56 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 20A7220AECAD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com; s=default; t=1688076596; bh=sNVCTU5gFBqe2BQjTeFzfJALosLnCbsvG4CoTL1NyEs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FDaBTtSqHtUX0HV8fAgs5RDMLHjO7gn4fSzK5XPajhYEnBJnZnjChdh81UVoWPqro DRLG+Vx8mrN3oaM/KcdZMq2puu07wo5Eajn+HxTooK1XuAfynP0YfMvXqQRJ9+2xWv +w/ReMKXpbzZcy6YvSZRQPqWoVvNVBszicCyAvA8= From: longli@linuxonhyperv.com To: "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Leon Romanovsky , Shradha Gupta , Ajay Sharma , Shachar Raindel , Stephen Hemminger , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux-rdma@vger.kernel.org, Long Li , stable@vger.kernel.org Subject: [PATCH net v4 2/2] net: mana: Use the correct WQE count for ringing RQ doorbell Date: Thu, 29 Jun 2023 15:09:31 -0700 Message-Id: <1688076571-24938-3-git-send-email-longli@linuxonhyperv.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1688076571-24938-1-git-send-email-longli@linuxonhyperv.com> References: <1688076571-24938-1-git-send-email-longli@linuxonhyperv.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770077131802436382?= X-GMAIL-MSGID: =?utf-8?q?1770077131802436382?= From: Long Li The hardware specification specifies that WQE_COUNT should set to 0 for the Receive Queue. Although currently the hardware doesn't enforce the check, in the future releases it may check on this value. Cc: stable@vger.kernel.org Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)") Reviewed-by: Haiyang Zhang Reviewed-by: Dexuan Cui Signed-off-by: Long Li --- Change log: v4: Split the original patch into two: one for batching doorbell, one for setting the correct wqe count drivers/net/ethernet/microsoft/mana/gdma_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c index 8f3f78b68592..3765d3389a9a 100644 --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c @@ -300,8 +300,11 @@ static void mana_gd_ring_doorbell(struct gdma_context *gc, u32 db_index, void mana_gd_wq_ring_doorbell(struct gdma_context *gc, struct gdma_queue *queue) { + /* Hardware Spec specifies that software client should set 0 for + * wqe_cnt for Receive Queues. This value is not used in Send Queues. + */ mana_gd_ring_doorbell(gc, queue->gdma_dev->doorbell, queue->type, - queue->id, queue->head * GDMA_WQE_BU_SIZE, 1); + queue->id, queue->head * GDMA_WQE_BU_SIZE, 0); } void mana_gd_ring_cq(struct gdma_queue *cq, u8 arm_bit)