From patchwork Mon Jun 5 15:08:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 103323 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2753170vqr; Mon, 5 Jun 2023 08:09:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7q+1rZLxofiGxkt2m0AOc8FkmxU2qXsJH6qYnzHj5pzDiQD/+ltWmhci8yRjAbT30AgofF X-Received: by 2002:a05:6a20:2590:b0:10b:92b8:9845 with SMTP id k16-20020a056a20259000b0010b92b89845mr4036729pzd.7.1685977796305; Mon, 05 Jun 2023 08:09:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685977796; cv=none; d=google.com; s=arc-20160816; b=uxgNR1czOxXhzRWP3N3mpvEPZ/A9kxKYpzzSiJof16pdUFbHOkiWIexWBup7ZR2A/t 2TgwDuzXm+m8AtrQ/tj/+glCXEuawjlnZE5AdbooQSXwf7RC08602/GdCbt2kTGiSI90 PCcFjrf/1DgjbySfJuC+70p/8ZecdWH6WGOQHsrMYs95SRXe50kR/iI4wLKAEHHXebrz 7vNK/Bh8cTO4egC7sz3cxiQp9q8zCxxhEVyU8YvHMIMGFLrSFmXE6BblxFr0EyfbTe3i RFnAeA13Nz+R3z7Kdu5gCM695ITNAQXZwUBAwiA8o2mPBlgt6a23mYXYKZHYnoyYTJnq ZVFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=VWaW9fnh5vUHZdZt/dtxYV4BBWkrmqOyozBfaB549So=; b=LeSxlTMv6A0JFTrVOP93DNK+DT6+KOtImUvMMjacXjt0vYH1Tc4pCuvlFpzd88y3gN TL9GzTbTgyXGL0IOzel4TBUhieXgB6Y8wnClj5SOExwdnv3TvlkQPgWMuKcqAQ58QL9R 8Z8SD464CLPGI66N7qKGwZbSFkhaElvMD1HPeWwSQea4Lun9/WFd5zknY2MnOoYDJ+Mg iCN4PPyNyXV3PIqbJeuPl47oQb+WdW4obdiCzEc5gb8YYYsUTpSi5ZTFa0ZRnC6P2W2S uSlI2sJFkQN6L2DlSMv8JUWcjShUHiNxKPaTzoZ/be0hb93PDouhN1LpbV0PqaixdOAg eoDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=qxbgp0Lp; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h189-20020a6253c6000000b0063c56e46f9esi5449073pfb.294.2023.06.05.08.09.43; Mon, 05 Jun 2023 08:09:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=qxbgp0Lp; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234469AbjFEPIv (ORCPT + 99 others); Mon, 5 Jun 2023 11:08:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233842AbjFEPI3 (ORCPT ); Mon, 5 Jun 2023 11:08:29 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DB2DE8; Mon, 5 Jun 2023 08:08:28 -0700 (PDT) Date: Mon, 05 Jun 2023 15:08:26 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1685977707; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VWaW9fnh5vUHZdZt/dtxYV4BBWkrmqOyozBfaB549So=; b=qxbgp0LpJ0pR3t8915lzBTbEuL+0+26zeEuvkcchcei8XLzGog0MJflkE0CQFLnt9Jb326 uA0Ktx2aqWi7r83nR9a5SULyl/wAS0AurkAWqm2GgiIV6+4TlVicL/NxSI/meHXVrmXv9Q KJkc2EnoeF1uUsqLb3YdY9ZFVee5i70p6aJD0f/K8IVSK92JBzKuUoW5hxT+j1OTkvgNA0 6BBlQPPaRwVHTo/MJj6WInzmbqm/s47TrPEkQt7BjISMzSM2IGIMZp2lGmAXaAKvTMzo/V kCoISDUpRS/JFyVgs91MiaWzNZU3g1NDyYahX7Ah4G/Ij16GochL/mP0DqxH/A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1685977707; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VWaW9fnh5vUHZdZt/dtxYV4BBWkrmqOyozBfaB549So=; b=UYTGxgagK0f7lNO0a9Z4gmyEPio66F3W9NNlKkugJ2NRhax1Ho3qTFYMuWP6n0i+ZvmXF4 QGRe1waFYGWGHUDQ== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: timers/core] posix-timers: Clarify posix_timer_rearm() comment Cc: Thomas Gleixner , Frederic Weisbecker , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230425183313.724863461@linutronix.de> References: <20230425183313.724863461@linutronix.de> MIME-Version: 1.0 Message-ID: <168597770638.404.10111309739897353369.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764176023816231112?= X-GMAIL-MSGID: =?utf-8?q?1767875853568474016?= The following commit has been merged into the timers/core branch of tip: Commit-ID: 93a62291070d2836b7cbaf20febadae6ae33934a Gitweb: https://git.kernel.org/tip/93a62291070d2836b7cbaf20febadae6ae33934a Author: Thomas Gleixner AuthorDate: Tue, 25 Apr 2023 20:49:22 +02:00 Committer: Thomas Gleixner CommitterDate: Mon, 05 Jun 2023 17:03:38 +02:00 posix-timers: Clarify posix_timer_rearm() comment Yet another incomprehensible piece of art. Signed-off-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Link: https://lore.kernel.org/r/20230425183313.724863461@linutronix.de --- kernel/time/posix-timers.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c index fb92036..f1a7c62 100644 --- a/kernel/time/posix-timers.c +++ b/kernel/time/posix-timers.c @@ -275,15 +275,9 @@ static void common_hrtimer_rearm(struct k_itimer *timr) } /* - * This function is exported for use by the signal deliver code. It is - * called just prior to the info block being released and passes that - * block to us. It's function is to update the overrun entry AND to - * restart the timer. It should only be called if the timer is to be - * restarted (i.e. we have flagged this in the sys_private entry of the - * info block). - * - * To protect against the timer going away while the interrupt is queued, - * we require that the it_requeue_pending flag be set. + * This function is called from the signal delivery code if + * info->si_sys_private is not zero, which indicates that the timer has to + * be rearmed. Restart the timer and update info::si_overrun. */ void posixtimer_rearm(struct kernel_siginfo *info) {