diff mbox series

[v2] bus: mhi: host: Skip MHI reset if device is in RDDM

Message ID 1683772404-13192-1-git-send-email-quic_qianyu@quicinc.com
State New
Headers
Series [v2] bus: mhi: host: Skip MHI reset if device is in RDDM |

Commit Message

Qiang Yu May 11, 2023, 2:33 a.m. UTC 
  In RDDM EE, device can not process MHI reset issued by host. In case of MHI
power off, host is issuing MHI reset and polls for it to get cleared until
it times out. Since this timeout can not be avoided in case of RDDM, skip
the MHI reset in this scenarios.

Fixes: a0f5a630668c ("bus: mhi: Move host MHI code to "host" directory")
Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
---
v1->v2: use ~75 columns in commit text,	add Fixes tag

 drivers/bus/mhi/host/pm.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jeffrey Hugo May 11, 2023, 1:52 p.m. UTC | #1 
On 5/10/2023 8:33 PM, Qiang Yu wrote:
> In RDDM EE, device can not process MHI reset issued by host. In case of MHI
> power off, host is issuing MHI reset and polls for it to get cleared until
> it times out. Since this timeout can not be avoided in case of RDDM, skip
> the MHI reset in this scenarios.
> 
> Fixes: a0f5a630668c ("bus: mhi: Move host MHI code to "host" directory")

This doesn't seem like the correct fixes tag.  That commit looks like it 
just moves code around, but does not add code.  What is the commit that 
added the relevant code?  That commit probably predates the move.

> Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com>
> ---
diff mbox series

Patch

diff --git a/drivers/bus/mhi/host/pm.c b/drivers/bus/mhi/host/pm.c
index 0834590..8a4362d 100644
--- a/drivers/bus/mhi/host/pm.c
+++ b/drivers/bus/mhi/host/pm.c
@@ -470,6 +470,10 @@  static void mhi_pm_disable_transition(struct mhi_controller *mhi_cntrl)
 
 	/* Trigger MHI RESET so that the device will not access host memory */
 	if (!MHI_PM_IN_FATAL_STATE(mhi_cntrl->pm_state)) {
+		/* Skip MHI RESET if in RDDM state */
+		if (mhi_cntrl->rddm_image && mhi_get_exec_env(mhi_cntrl) == MHI_EE_RDDM)
+			goto skip_mhi_reset;
+
 		dev_dbg(dev, "Triggering MHI Reset in device\n");
 		mhi_set_mhi_state(mhi_cntrl, MHI_STATE_RESET);
 
@@ -495,6 +499,7 @@  static void mhi_pm_disable_transition(struct mhi_controller *mhi_cntrl)
 		}
 	}
 
+skip_mhi_reset:
 	dev_dbg(dev,
 		 "Waiting for all pending event ring processing to complete\n");
 	mhi_event = mhi_cntrl->mhi_event;