From patchwork Sat Apr 29 07:18:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 88852 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1438777vqo; Sat, 29 Apr 2023 00:21:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4rg5e9eAcz2o/f3kg17Xpe5rCAKt4v5ih3PoX+ytBNKsC6KJvs0Z0vR2Ip0E0wwax5qzyj X-Received: by 2002:a05:6a00:9aa:b0:63b:89a9:529f with SMTP id u42-20020a056a0009aa00b0063b89a9529fmr10812239pfg.14.1682752878670; Sat, 29 Apr 2023 00:21:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682752878; cv=none; d=google.com; s=arc-20160816; b=Q37qn4Eah0jcd7cFxCESJ68IKklmwGmQdAkzhAWeR0WIZtenXBBFF6H32Mk7zhm1ha yYWhfnuvMH+v6aTLfMBQwYrSDNDqz4g4YhfSWa2+U/LjPoRlBPzbePcWNqm3P+hdY/Pm 6qZ9/S4r4I7DxTugs+CItKlWQMIBkbzhVjW8EpHp2OobdCDL1mGREGN1WUP47XZEDKJt nzdXqh57jwWMKhD3OyzM1zN2iMBG3R42WSpBHx9+tBLwUbt+gSi9GB/OfkE1wAhC8fdJ LnwmqiSdgI4yDcHuiapIhFmLFCDpi+lLan7hP3YwiUY9TuxvA/p7yz1W9igMEfgVp8pH rQgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=mkrQ3qXTqvUZ8dRo8djDoctPziqkTMN6F8HLDnBOlb8=; b=HggKbHYQKmQ8cyEk8Ck/s4tADrM2AmFahh9lWEUaaP1cBmkyUWrmw+9cCK/c2pB5Uk eoOfn46CWRQOcfAjw0JALRW8p/K24yPpxVbRa6zKTZjvOyCdT+tpF45SBxSfa9a4OjCm PBLaIQVijE36GNlKSYQ6TTFV/eXLG5StDE64ixNNJVpKxWhvGRQJvP4LCIqZsDTpKizs j35F9nffpLjjr9f+PpGJi+75d9s3N7t1wh46rKUAay+G9eOxm8d2p1nAcsQXo7DtsURR WGH9ykBS4tq1ygJr2asYY5jke2e8nEMiOJ+DmkzAlaMJvpx74WrZwpfmAHckQEOBS2Bi 9nvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dR3ZEYSI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020aa796b7000000b0063b71d46b6dsi22773070pfk.75.2023.04.29.00.21.04; Sat, 29 Apr 2023 00:21:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=dR3ZEYSI; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbjD2HSQ (ORCPT + 99 others); Sat, 29 Apr 2023 03:18:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230181AbjD2HSK (ORCPT ); Sat, 29 Apr 2023 03:18:10 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F371BFB; Sat, 29 Apr 2023 00:18:09 -0700 (PDT) Date: Sat, 29 Apr 2023 07:18:07 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1682752688; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mkrQ3qXTqvUZ8dRo8djDoctPziqkTMN6F8HLDnBOlb8=; b=dR3ZEYSIzOTilnGsihQqwu/uN/2dKbCq82mVmDNLihGttbpDUcD1rYC8dmM9bcGg84Hzcp 0Ti3cAfUiHlvtKERZUvuSZcTGU0jhjV9bp1RoMpBTbLYC8uxycItn5nvQdM/bpctjC8Am5 Js3JoodAFWOCu9suOCjOrmT9wyAcecCockWSsH3lkvtLyewHEWOaa0XIdI9yeA6YFA7I64 KIHIT0aAB8jLqfaU6gkIZnrvqB5odUkjY7t7lMbDn4BMtcfgFYttYupZ4aH3687fGFTYtT 3uYIuD4D2Afg/DvDC2l0HyYYeqjaqc+h19jbW5YriXOmqftCJdcdSJM+gPG8Fw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1682752688; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mkrQ3qXTqvUZ8dRo8djDoctPziqkTMN6F8HLDnBOlb8=; b=ypaiUGiVtJfuuWJwgx9h1gKO5ndhpNGzvNOczQJJ0tBIde4tUl1QEEj3nvBIMcdppTb+km Jc6ICnauzZuetaBA== From: "tip-bot2 for Uros Bizjak" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: locking/core] locking/arch: Wire up local_try_cmpxchg() Cc: Uros Bizjak , "Peter Zijlstra (Intel)" , Ingo Molnar , Linus Torvalds , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20230405141710.3551-4-ubizjak@gmail.com> References: <20230405141710.3551-4-ubizjak@gmail.com> MIME-Version: 1.0 Message-ID: <168275268758.404.9378473866164918066.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764493350261108675?= X-GMAIL-MSGID: =?utf-8?q?1764494282557069589?= The following commit has been merged into the locking/core branch of tip: Commit-ID: d994f2c8e2410ebcb928df67baa6f04e29bc9d3e Gitweb: https://git.kernel.org/tip/d994f2c8e2410ebcb928df67baa6f04e29bc9d3e Author: Uros Bizjak AuthorDate: Wed, 05 Apr 2023 16:17:08 +02:00 Committer: Ingo Molnar CommitterDate: Sat, 29 Apr 2023 09:09:16 +02:00 locking/arch: Wire up local_try_cmpxchg() Implement target specific support for local_try_cmpxchg() and local_cmpxchg() using typed C wrappers that call their _local counterpart and provide additional checking of their input arguments. Signed-off-by: Uros Bizjak Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/20230405141710.3551-4-ubizjak@gmail.com Cc: Linus Torvalds --- arch/alpha/include/asm/local.h | 12 ++++++++++-- arch/loongarch/include/asm/local.h | 13 +++++++++++-- arch/mips/include/asm/local.h | 13 +++++++++++-- arch/powerpc/include/asm/local.h | 11 +++++++++++ arch/x86/include/asm/local.h | 13 +++++++++++-- 5 files changed, 54 insertions(+), 8 deletions(-) diff --git a/arch/alpha/include/asm/local.h b/arch/alpha/include/asm/local.h index fab26a1..0fcaad6 100644 --- a/arch/alpha/include/asm/local.h +++ b/arch/alpha/include/asm/local.h @@ -52,8 +52,16 @@ static __inline__ long local_sub_return(long i, local_t * l) return result; } -#define local_cmpxchg(l, o, n) \ - (cmpxchg_local(&((l)->a.counter), (o), (n))) +static __inline__ long local_cmpxchg(local_t *l, long old, long new) +{ + return cmpxchg_local(&l->a.counter, old, new); +} + +static __inline__ bool local_try_cmpxchg(local_t *l, long *old, long new) +{ + return try_cmpxchg_local(&l->a.counter, (s64 *)old, new); +} + #define local_xchg(l, n) (xchg_local(&((l)->a.counter), (n))) /** diff --git a/arch/loongarch/include/asm/local.h b/arch/loongarch/include/asm/local.h index 65fbbae..83e995b 100644 --- a/arch/loongarch/include/asm/local.h +++ b/arch/loongarch/include/asm/local.h @@ -56,8 +56,17 @@ static inline long local_sub_return(long i, local_t *l) return result; } -#define local_cmpxchg(l, o, n) \ - ((long)cmpxchg_local(&((l)->a.counter), (o), (n))) +static inline long local_cmpxchg(local_t *l, long old, long new) +{ + return cmpxchg_local(&l->a.counter, old, new); +} + +static inline bool local_try_cmpxchg(local_t *l, long *old, long new) +{ + typeof(l->a.counter) *__old = (typeof(l->a.counter) *) old; + return try_cmpxchg_local(&l->a.counter, __old, new); +} + #define local_xchg(l, n) (atomic_long_xchg((&(l)->a), (n))) /** diff --git a/arch/mips/include/asm/local.h b/arch/mips/include/asm/local.h index 08366b1..5daf6fe 100644 --- a/arch/mips/include/asm/local.h +++ b/arch/mips/include/asm/local.h @@ -94,8 +94,17 @@ static __inline__ long local_sub_return(long i, local_t * l) return result; } -#define local_cmpxchg(l, o, n) \ - ((long)cmpxchg_local(&((l)->a.counter), (o), (n))) +static __inline__ long local_cmpxchg(local_t *l, long old, long new) +{ + return cmpxchg_local(&l->a.counter, old, new); +} + +static __inline__ bool local_try_cmpxchg(local_t *l, long *old, long new) +{ + typeof(l->a.counter) *__old = (typeof(l->a.counter) *) old; + return try_cmpxchg_local(&l->a.counter, __old, new); +} + #define local_xchg(l, n) (atomic_long_xchg((&(l)->a), (n))) /** diff --git a/arch/powerpc/include/asm/local.h b/arch/powerpc/include/asm/local.h index bc4bd19..45492fb 100644 --- a/arch/powerpc/include/asm/local.h +++ b/arch/powerpc/include/asm/local.h @@ -90,6 +90,17 @@ static __inline__ long local_cmpxchg(local_t *l, long o, long n) return t; } +static __inline__ bool local_try_cmpxchg(local_t *l, long *po, long n) +{ + long o = *po, r; + + r = local_cmpxchg(l, o, n); + if (unlikely(r != o)) + *po = r; + + return likely(r == o); +} + static __inline__ long local_xchg(local_t *l, long n) { long t; diff --git a/arch/x86/include/asm/local.h b/arch/x86/include/asm/local.h index 349a47a..56d4ef6 100644 --- a/arch/x86/include/asm/local.h +++ b/arch/x86/include/asm/local.h @@ -120,8 +120,17 @@ static inline long local_sub_return(long i, local_t *l) #define local_inc_return(l) (local_add_return(1, l)) #define local_dec_return(l) (local_sub_return(1, l)) -#define local_cmpxchg(l, o, n) \ - (cmpxchg_local(&((l)->a.counter), (o), (n))) +static inline long local_cmpxchg(local_t *l, long old, long new) +{ + return cmpxchg_local(&l->a.counter, old, new); +} + +static inline bool local_try_cmpxchg(local_t *l, long *old, long new) +{ + typeof(l->a.counter) *__old = (typeof(l->a.counter) *) old; + return try_cmpxchg_local(&l->a.counter, __old, new); +} + /* Always has a lock prefix */ #define local_xchg(l, n) (xchg(&((l)->a.counter), (n)))