From patchwork Mon Apr 24 14:47:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Masami Hiramatsu (Google)" X-Patchwork-Id: 87078 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp2800017vqo; Mon, 24 Apr 2023 07:52:33 -0700 (PDT) X-Google-Smtp-Source: AKy350acjGesrIaOCfN4ZREW9eWpXL+iZiwVJfVPAcOOv94HWvQ1hs3wmNf1pvHRcx7ZcH63/HHc X-Received: by 2002:a05:6a20:a49e:b0:f0:2893:8a34 with SMTP id y30-20020a056a20a49e00b000f028938a34mr13150392pzk.52.1682347952918; Mon, 24 Apr 2023 07:52:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682347952; cv=none; d=google.com; s=arc-20160816; b=I2d7E4qf2jPSwnEi+CB+6kgLOxIGQo5QMiO9uAcW6EKYyln2ZMk1WQQuhX3FlhJOJ4 CFhM67Ruk25P1ZAleJyNlGMOPekA57e5yCrZC1vGhBsvj32m7NoZLfNGf10EA5/6/Lx+ kLsFsuTs9p7ZOSeoGpggyYQiSf/ltNND3N+JSqwxPRWhuuOf9614v/2dwFq/MzJAJfSF 6Soj02AqhMClXrx5GLcrvYP3qxGgTuUCZ1hFg3MfRmMjNrj07q60a0jBj7KQ1AUwYmvR mUPtjFZxVekIV4f0kU7P0M7g3dGvVn7BSQHyYk/3QYOAhhW8M7yyFREAsXmeHiVsqfJL OE5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RrKNYglzmreK2qrmszTs6goC6jfunvFE4p5ITpr+5F0=; b=dHuYVd5SmzwhEBHrc3E2Bm5QhbDveFxCpsuXF8OpK9ra4Zk//cCaS64tjDqAjYq2uI SbQltJIlv5boUT5ZZ0wLLJYchJddnrCTYR8ML3Su5pJ14Ov0kcNdv643hJB9ShKCHmyK jllZDj4VxmVIkd5DU2QCDE10As8awl50yZLbBdMJoekQG9OKqbglyOtfnVDYqrQ0Jr6M UQl3gBr8Hpuhp7keYakMFHnbEqtos2C+dMY+45jhFjsIQ6Itavboo5RtGWcdbaBnleqq JEDB309/3xo2JwMpn42nG9FgpzvnbG62iDRIItKakR92Gc5Ty4p5gCUeB/GDTd3cZzpz TAZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iQ3N4EoY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a36-20020a631a24000000b0051b856ffbc1si11079408pga.659.2023.04.24.07.52.18; Mon, 24 Apr 2023 07:52:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iQ3N4EoY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231945AbjDXOr6 (ORCPT + 99 others); Mon, 24 Apr 2023 10:47:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231867AbjDXOrp (ORCPT ); Mon, 24 Apr 2023 10:47:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 172467AA5; Mon, 24 Apr 2023 07:47:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5126C62380; Mon, 24 Apr 2023 14:47:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A330C433D2; Mon, 24 Apr 2023 14:47:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682347649; bh=JMzuvPGaUtd3Ue61+R7r8JPv3Iwr1kA9f/gFM8QNZ7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iQ3N4EoYsMtU4cw91xIWq/jA/E7a/LyrUdFGYsmjOEJfP6cfo4oxayyB6I4y+WqwI XchxfspYVCjSwyHSuKoKVwktY7cCWB+5hRRdlUkXUPtONCYdpPz2lcMqccX5F6Gv3l aUfW9jKfivObQHhdawhkeSRFYFRZJIKEAEAU3o/TcOaWUQ1jhEHN1xsngVidjPbSnA Gc+2lGwD2Ede4i8NFpQXRNnl5NBaayp8UmkBi/c/AQTX0DOWJOUBi2DzYDb+jtx8yC Yh6PHMessMFOkc2dxNu6efxavGZ5uNY9QXnRqLmRaOhEEMB6ah9EqG/ZnW0c8huUEq vOkc/aPd7/6fw== From: "Masami Hiramatsu (Google)" To: linux-trace-kernel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Steven Rostedt , mhiramat@kernel.org, Florent Revest , Mark Rutland , Will Deacon , Mathieu Desnoyers , Martin KaFai Lau , bpf@vger.kernel.org Subject: [PATCH v6 09/10] selftests/ftrace: Add BTF arguments test cases Date: Mon, 24 Apr 2023 23:47:25 +0900 Message-ID: <168234764510.2210510.12624573832612819462.stgit@mhiramat.roam.corp.google.com> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <168234755610.2210510.12133559313738141202.stgit@mhiramat.roam.corp.google.com> References: <168234755610.2210510.12133559313738141202.stgit@mhiramat.roam.corp.google.com> User-Agent: StGit/0.19 MIME-Version: 1.0 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1764069686871853631?= X-GMAIL-MSGID: =?utf-8?q?1764069686871853631?= From: Masami Hiramatsu (Google) Add test cases to check the BTF arguments correctly supported. Signed-off-by: Masami Hiramatsu (Google) --- .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 54 ++++++++++++++++++++ .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 10 ++++ .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 10 ++++ 3 files changed, 74 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc new file mode 100644 index 000000000000..15515f0a8c9a --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc @@ -0,0 +1,54 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: Generic dynamic event - add/remove probes with BTF arguments +# requires: dynamic_events "":README + +KPROBES= +FPROBES= + +if grep -qF "p[:[/][]] []" README ; then + KPROBES=yes +fi +if grep -qF "f[:[/][]] [%return] []" README ; then + FPROBES=yes +fi + +if [ -z "$KPROBES" -a "$FPROBES" ] ; then + exit_unsupported +fi + +echo 0 > events/enable +echo > dynamic_events + +TP=kfree + +if [ "$FPROBES" ] ; then +echo "f:fpevent $TP object" >> dynamic_events +echo "t:tpevent $TP ptr" >> dynamic_events + +grep -q "fpevent.*object=object" dynamic_events +grep -q "tpevent.*ptr=ptr" dynamic_events + +echo > dynamic_events + +echo "f:fpevent $TP "'$$args' >> dynamic_events +echo "t:tpevent $TP "'$$args' >> dynamic_events + +grep -q "fpevent.*object=object" dynamic_events +grep -q "tpevent.*ptr=ptr" dynamic_events +! grep -q "tpevent.*_data" dynamic_events +fi + +echo > dynamic_events + +if [ "$KPROBES" ] ; then +echo "p:kpevent $TP object" >> dynamic_events +grep -q "kpevent.*object=object" dynamic_events + +echo > dynamic_events + +echo "p:kpevent $TP "'$$args' >> dynamic_events +grep -q "kpevent.*object=object" dynamic_events +fi + +clear_trace diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc index 549daa162d84..fb92566916a9 100644 --- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc @@ -85,4 +85,14 @@ fi # %return suffix errors check_error 'f vfs_read^%hoge' # BAD_ADDR_SUFFIX +# BTF arguments errors +if grep -q "" README; then +check_error 'f vfs_read $$args ^$$args' # DOUBLE_ARGS +check_error 'f vfs_read%return ^$$args' # NOFENTRY_ARGS +check_error 'f vfs_read ^hoge' # NO_BTFARG +else +check_error 'f vfs_read $$args' # NOSUP_BTFARG +check_error 't kfree $$args' # NOSUP_BTFARG +fi + exit 0 diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc index 97c08867490a..f2d1edbb650a 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc @@ -103,4 +103,14 @@ check_error 'p vfs_read^%hoge' # BAD_ADDR_SUFFIX check_error 'p ^vfs_read+10%return' # BAD_RETPROBE fi +# BTF arguments errors +if grep -q "" README; then +check_error 'p vfs_read $$args ^$$args' # DOUBLE_ARGS +check_error 'r vfs_read ^$$args' # NOFENTRY_ARGS +check_error 'p vfs_read+8 ^$$args' # NOFENTRY_ARGS +check_error 'p vfs_read ^hoge' # NO_BTFARG +else +check_error 'p vfs_read $$args' # NOSUP_BTFARG +fi + exit 0