From patchwork Thu Apr 20 11:26:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Masami Hiramatsu (Google)" X-Patchwork-Id: 85871 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp261993vqo; Thu, 20 Apr 2023 04:33:24 -0700 (PDT) X-Google-Smtp-Source: AKy350Yg4y4wkj9q2HuPM3m5imNyAwITGBPOnISJoJnuRPumBx1+zKDWShc60KqDE6M5lEA3qIdo X-Received: by 2002:a17:90b:81:b0:24b:59c1:dad0 with SMTP id bb1-20020a17090b008100b0024b59c1dad0mr318787pjb.7.1681990404021; Thu, 20 Apr 2023 04:33:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681990404; cv=none; d=google.com; s=arc-20160816; b=L5vAc4w40SIhA2jo+nNsxuKZxXJ12FBaB12nYQRSvKzOSJxjJ4KgBD3/EAxEJCGF4Q OPVoYH+c+uvk3AkZoujGZXYD3OvI8jsv3ZAwlufLxVCJb8URAX/3BqLbc1zKzaGxAsl8 FAXe96RSaLJPGkjRTAXvdUD3d75Un5T0u2IfKrVRo5qSw+rwV8l7NZOWnPpAHU7ZyH+H KBZzly7IjVRKP4B3ccTpYObpr02fEFy3aJqcLqnJV1iXu6UqlmYtU4ed68Hfcjq/ALqM B5U0SyVn9rgWN+lsV0+zH7vl9o4hk0Tf9RFNTiR2BEgT68L60q7Aj4EN1X4yWKTe2H4Y D3DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RrKNYglzmreK2qrmszTs6goC6jfunvFE4p5ITpr+5F0=; b=a3kQgi8B8aum8VJELNAKIsVndEOCADDcX5q5cRyIi/RbKAIHS4jIXgF/jea24gArd2 A8Gg9Rgm55liPoowQTfEQd4LixbJX3q4YQz2Tq6fc2l75OAA2CEZj1+uH1ptdB3FD++r b3muImO5oPq9oY9/PHrJ6LVztN3QwME2R1x0OXEdr7TWHwrMcM4IvatNxeejjH2mAOH5 CH8LjLH9zFRgD79WS0Ce2Ow1aQ5mo4wukbA5bA922uyYPQW4/Vr1g1c+PXocgilJjqS8 X9BjOi369dG1oDiovlhyIMziaBbcsbo3CsItSkPfGmUO3SqHmnUMR076mSazadaXDFgS /TUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IySFugKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h8-20020a170902680800b001a67ffb3546si1596145plk.231.2023.04.20.04.33.11; Thu, 20 Apr 2023 04:33:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IySFugKI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234860AbjDTL2T (ORCPT + 99 others); Thu, 20 Apr 2023 07:28:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234728AbjDTL16 (ORCPT ); Thu, 20 Apr 2023 07:27:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6708983E0; Thu, 20 Apr 2023 04:27:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCDC664852; Thu, 20 Apr 2023 11:27:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96D55C4339B; Thu, 20 Apr 2023 11:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681990022; bh=JMzuvPGaUtd3Ue61+R7r8JPv3Iwr1kA9f/gFM8QNZ7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IySFugKIUT2dEWjVXdKzZwZgpZCG4MYXlHqWVQAdHl9Cbb/s3CqMmq2QYhVCgJUXX VeHdv6jUpOwreOtK9HmssmqGtAEVU0CRB6yz4mYW0KlqpjrgwKkVsOt/geHTIpGnWX 821KZV2sm+3JI/8Wk3MrKHcmFhEEenMHUfHRCBMX2SojdnHltiY4Kc9IOJYtX5flRO 1qjzQsE/LJHRZ86r+85i+WtswxNOUX2p+9Djvjp0S1HUG+wMZ/plQvPCwO/rEWvsE8 Zk2sPfLRcI8afYT/ZdQHkMbG66a5YeJhuuV61D/PFxpLl/P9WUe1IQi7QCGRYBP+5F 2S3WDCTfZPJoA== From: "Masami Hiramatsu (Google)" To: linux-trace-kernel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Steven Rostedt , mhiramat@kernel.org, Florent Revest , Mark Rutland , Will Deacon , Mathieu Desnoyers , Martin KaFai Lau , bpf@vger.kernel.org Subject: [PATCH v5 9/9] selftests/ftrace: Add BTF arguments test cases Date: Thu, 20 Apr 2023 20:26:57 +0900 Message-ID: <168199001790.1795549.440521983895126009.stgit@mhiramat.roam.corp.google.com> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog In-Reply-To: <168198993129.1795549.8306571027057356176.stgit@mhiramat.roam.corp.google.com> References: <168198993129.1795549.8306571027057356176.stgit@mhiramat.roam.corp.google.com> User-Agent: StGit/0.19 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763694769680313287?= X-GMAIL-MSGID: =?utf-8?q?1763694769680313287?= From: Masami Hiramatsu (Google) Add test cases to check the BTF arguments correctly supported. Signed-off-by: Masami Hiramatsu (Google) --- .../ftrace/test.d/dynevent/add_remove_btfarg.tc | 54 ++++++++++++++++++++ .../ftrace/test.d/dynevent/fprobe_syntax_errors.tc | 10 ++++ .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc | 10 ++++ 3 files changed, 74 insertions(+) create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc new file mode 100644 index 000000000000..15515f0a8c9a --- /dev/null +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_btfarg.tc @@ -0,0 +1,54 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +# description: Generic dynamic event - add/remove probes with BTF arguments +# requires: dynamic_events "":README + +KPROBES= +FPROBES= + +if grep -qF "p[:[/][]] []" README ; then + KPROBES=yes +fi +if grep -qF "f[:[/][]] [%return] []" README ; then + FPROBES=yes +fi + +if [ -z "$KPROBES" -a "$FPROBES" ] ; then + exit_unsupported +fi + +echo 0 > events/enable +echo > dynamic_events + +TP=kfree + +if [ "$FPROBES" ] ; then +echo "f:fpevent $TP object" >> dynamic_events +echo "t:tpevent $TP ptr" >> dynamic_events + +grep -q "fpevent.*object=object" dynamic_events +grep -q "tpevent.*ptr=ptr" dynamic_events + +echo > dynamic_events + +echo "f:fpevent $TP "'$$args' >> dynamic_events +echo "t:tpevent $TP "'$$args' >> dynamic_events + +grep -q "fpevent.*object=object" dynamic_events +grep -q "tpevent.*ptr=ptr" dynamic_events +! grep -q "tpevent.*_data" dynamic_events +fi + +echo > dynamic_events + +if [ "$KPROBES" ] ; then +echo "p:kpevent $TP object" >> dynamic_events +grep -q "kpevent.*object=object" dynamic_events + +echo > dynamic_events + +echo "p:kpevent $TP "'$$args' >> dynamic_events +grep -q "kpevent.*object=object" dynamic_events +fi + +clear_trace diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc index 549daa162d84..fb92566916a9 100644 --- a/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/dynevent/fprobe_syntax_errors.tc @@ -85,4 +85,14 @@ fi # %return suffix errors check_error 'f vfs_read^%hoge' # BAD_ADDR_SUFFIX +# BTF arguments errors +if grep -q "" README; then +check_error 'f vfs_read $$args ^$$args' # DOUBLE_ARGS +check_error 'f vfs_read%return ^$$args' # NOFENTRY_ARGS +check_error 'f vfs_read ^hoge' # NO_BTFARG +else +check_error 'f vfs_read $$args' # NOSUP_BTFARG +check_error 't kfree $$args' # NOSUP_BTFARG +fi + exit 0 diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc index 97c08867490a..f2d1edbb650a 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc @@ -103,4 +103,14 @@ check_error 'p vfs_read^%hoge' # BAD_ADDR_SUFFIX check_error 'p ^vfs_read+10%return' # BAD_RETPROBE fi +# BTF arguments errors +if grep -q "" README; then +check_error 'p vfs_read $$args ^$$args' # DOUBLE_ARGS +check_error 'r vfs_read ^$$args' # NOFENTRY_ARGS +check_error 'p vfs_read+8 ^$$args' # NOFENTRY_ARGS +check_error 'p vfs_read ^hoge' # NO_BTFARG +else +check_error 'p vfs_read $$args' # NOSUP_BTFARG +fi + exit 0